aboutsummaryrefslogtreecommitdiffstats
path: root/lib/arel
Commit message (Collapse)AuthorAgeFilesLines
* Support `columns_for_distinct`Yasuo Honda2013-10-141-2/+2
|
* Merge pull request #204 from trptcolin/visitor_dispatch_cachingAaron Patterson2013-09-111-3/+6
|\ | | | | Cache visitor dispatch on a per-visitor basis
| * Cache visitor dispatch on a per-visitor basisColin Jones2013-08-141-3/+6
| |
* | Improve performance of #uniq across a large number of nodesSam2013-08-301-1/+4
|/
* record who created the node when $DEBUG is trueAaron Patterson2013-05-201-1/+8
|
* call super from initializeAaron Patterson2013-05-178-0/+10
|
* Make visitors threadsafe by removing @last_columnErnie Miller2013-04-2815-381/+385
| | | | | | | | | | | | | | | | | | | | | | The last_column feature of the ToSql visitor and its descendants is what enabled quoting based on the column last visited -- in other words, if you have a standard condition like an equality with a string attribute on the left side and an integer on the right side, then when ARel visits the node, it'll first visit the left side attribute, setting the column of the string attribute as the last column, and resulting in the right side of the condition getting the appropriate quoting. The downside is that this means that visitors can't be shared between threads, because of the state mutation. It also makes for some really weird behavior in the event that the visitor visits a node that happens to contain an attribute you weren't expecting to be there, since it'll potentially quote something based on that attribute. So, it prevents reversing an equality condition. column = value will work, but not value = column, since the last column wouldn't be the column you're hoping for. This is a first pass at fixing this by changing the signature of the visit methods to accept the currently-relevant attribute, if any.
* ARel -> ArelXavier Noria2013-04-145-8/+8
| | | | | | | The project uses "Arel" most of the time, but there were a few "ARel" here and there. I checked with @brynary back in 2010 to pick one for the Rails documentation guidelines and "Arel" was chosen and documented. This patch chooses "Arel" vs "ARel" based on that.
* Revert issue #99 fixesEduardo Mourao2013-03-151-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are two commits involving issue #99 which should be reverted. First of all, #99 is not an issue in Arel at all. Second, the fix provides pretty much destroys the purpose of pagination by cause full table scans. The original code (it seems I can't simply revert the commits) is 900 times slower than this one. ``` SELECT * FROM ( SELECT raw_sql_.*, rownum raw_rnum_ FROM (SELECT "LANCAMENTOS".* FROM "LANCAMENTOS" ) raw_sql_ ) WHERE raw_rnum_ between 1 and 30 ---------------------------------------------------------------------------------- | Id | Operation | Name | Rows | Bytes | Cost (%CPU)| Time | ----------------------------------------------------------------------------------- | 0 | SELECT STATEMENT | | 4636K| 2701M| 23442 (2)| 00:04:42 | |* 1 | VIEW | | 4636K| 2701M| 23442 (2)| 00:04:42 | | 2 | COUNT | | | | | | | 3 | TABLE ACCESS FULL| LANCAMENTOS | 4636K| 738M| 23442 (2)| 00:04:42 | ----------------------------------------------------------------------------------- Predicate Information (identified by operation id): --------------------------------------------------- 1 - filter("RAW_RNUM_"<=30 AND "RAW_RNUM_">=1) Statistics ----------------------------------------------------------- 4 user calls 13 physical read total multi block requests 202588160 physical read total bytes 202588160 cell physical IO interconnect bytes 0 commit cleanout failures: block lost 0 IMU commits 0 IMU Flushes 0 IMU contention 0 IMU bind flushes 0 IMU mbu flush SELECT * FROM ( SELECT raw_sql_.*, rownum raw_rnum_ FROM (SELECT "LANCAMENTOS".* FROM "LANCAMENTOS" ) raw_sql_ WHERE rownum <= 30 ) WHERE raw_rnum_ >= 0 ----------------------------------------------------------------------------------- | Id | Operation | Name | Rows | Bytes | Cost (%CPU)| Time | ----------------------------------------------------------------------------------- | 0 | SELECT STATEMENT | | 30 | 18330 | 2 (0)| 00:00:01 | |* 1 | VIEW | | 30 | 18330 | 2 (0)| 00:00:01 | |* 2 | COUNT STOPKEY | | | | | | | 3 | TABLE ACCESS FULL| LANCAMENTOS | 30 | 5010 | 2 (0)| 00:00:01 | ----------------------------------------------------------------------------------- Predicate Information (identified by operation id): --------------------------------------------------- 1 - filter("RAW_RNUM_">=0) 2 - filter(ROWNUM<=30) Statistics ----------------------------------------------------------- 4 user calls 0 physical read total multi block requests 0 physical read total bytes 0 cell physical IO interconnect bytes 0 commit cleanout failures: block lost 0 IMU commits 0 IMU Flushes 0 IMU contention 0 IMU bind flushes 0 IMU mbu flush ```
* call the columns hash methodAaron Patterson2013-03-141-3/+3
|
* Support Float::INFINITY in rangesTim Pope2013-02-191-2/+18
|
* Merge pull request #161 from Noemj/masterAaron Patterson2013-02-051-0/+10
|\ | | | | Mysql2 prepared statements bind substitution fix
| * Fixed the bind param visiting for mysql2 prepared statements caseNoemj2013-02-041-0/+10
| |
* | Merge pull request #160 from t0m/issue_99_oracle_optimizationRafael Mendonça França2013-01-311-1/+1
|\ \ | | | | | | Small change to oracle paging code to trigger stopkey optimization
| * | Add oracle paging optimization discussed in issue 99tom2013-01-081-1/+1
| | |
* | | fixing bind param visiting in the dot visitorAaron Patterson2013-01-301-1/+1
| |/ |/|
* | Denied the quoting of SqlLiteralsNoemj2013-01-291-0/+1
|/
* avoid extra string objects in the inner join caseAaron Patterson2012-10-151-1/+6
|
* more roflscaling strings in the visitorAaron Patterson2012-10-121-8/+26
|
* adding some roflscale to the sql visitorAaron Patterson2012-10-121-13/+96
|
* Merge pull request #141 from sunaku/GH-138Aaron Patterson2012-09-241-0/+4
|\ | | | | feature: add Arel::SelectManager#projections method
| * GH-138: add Arel::SelectManager#projections methodSuraj N. Kurapati2012-09-211-0/+4
| |
* | Merge pull request #140 from sunaku/GH-139Aaron Patterson2012-09-241-4/+4
|\ \ | | | | | | bugfix: some aggregations lacked DISTINCT emission
| * | GH-139: some aggregations lacked DISTINCT emissionSuraj N. Kurapati2012-09-211-4/+4
| |/
* / to_sql: add support for emitting SQL subqueriesSuraj N. Kurapati2012-09-221-0/+4
|/
* Add equality to ALL THE THINGS (that matter)Ernie Miller2012-08-1815-2/+187
| | | | | | | | | | | | People are often trying to use ARel nodes inside ActiveRecord, and when they do so, lots of things can break, because ActiveRecord relies on Array#uniq and sometimes hash key equality to handle values that end up in wheres, havings, etc. By implementing equality for all the nodes, we should hopefully be able to prevent any nodes (even nodes containing other nodes) from failing an equality check they should otherwise pass, and alleviate many of these errors. Fixes #130
* Add Nodes::TableAlias#engineJon Leighton2012-07-131-0/+4
| | | | | Eventually #engine should go away, but until that time, this means that Table and Nodes::TableAlias can be used more interchangeably.
* Remove ArgumentError.Jon Leighton2012-07-131-2/+1
| | | | | | | | | | It is untested. There is no `@frame` variable. Presumably it is supposed to be `@framing`, but changing that shows that some of the tests *are* setting frame twice. I don't see why this level of strictness is necessary. If someone disagrees, they should add a test for this behaviour and make the other tests pass.
* Fix in [] to be false, in [] to be trueErnie Miller2012-06-141-2/+10
| | | | This is in response to discussion on 62207fa
* Do not generate NOT IN (NULL) when empty rightSantiago Pastorino2012-06-131-1/+1
|
* Include Predications in GroupingErnie Miller2012-05-194-7/+8
| | | | | | Also, removed unused ordering.rb file, since it is identical to the one being created in unary.rb already, and isn't required anywhere.
* Revert "Revert "Merge pull request #113 from xuanxu/remove_relation""Aaron Patterson2012-03-272-8/+0
| | | | This reverts commit 6e8d1587091e00a84ea24ab92d9e836c3c38bcb8.
* Revert "Merge pull request #113 from xuanxu/remove_relation"Aaron Patterson2012-03-272-0/+8
| | | | | This reverts commit 9978fc40a8a5a262670279129a335845ad647f48, reversing changes made to b45466757424b98e1fe9699042d23550fd5b8751.
* Remove deprecated Relation moduleJuanjo Bazán2012-03-272-8/+0
|
* Adds visit_Arel_Nodes_InfixOperation to Arel::Visitors::DepthFirstBenedikt Deicke2012-03-221-0/+1
|
* Patch Informix Visitor so that it includes joinsJordan2012-02-291-1/+1
|
* Must support aliases for OVER operator.Alexander Staubo2012-02-231-0/+2
|
* Add #extract, which produces ANSI SQL function EXTRACT(<field> from <expr>).Alexander Staubo2012-02-235-0/+38
|
* Support ANSI SQL2003 window functions.Alexander Staubo2012-02-2210-1/+189
|
* added a module for visiting and transforming bind valuesAaron Patterson2012-02-212-2/+26
|
* bind parameters can be differentiated from sql literalsAaron Patterson2012-02-204-0/+6
|
* Oracle limit and offset issue when query is ordered, issue #99 solved.babinho2012-02-171-2/+1
|
* Borked the tests, so I'm reverting for now.Aaron Patterson2012-02-091-0/+10
| | | | | | | Revert "Merge pull request #81 from parndt/master" This reverts commit f3214d9ff0b7a3efb14f7e9cb93c51d3468c16d8, reversing changes made to fc787a42c0febcee41e13d16e06b72492ab00468.
* Merge pull request #81 from parndt/masterAaron Patterson2012-02-091-10/+0
|\ | | | | Removed lib/arel/sql/engine.rb
| * Merge remote-tracking branch 'rails/master'Philip Arndt2011-11-031-1/+1
| |\
| * | Removed lib/arel/sql/engine.rb because it's not required anymore.Philip Arndt2011-09-141-10/+0
| | |
* | | while using activerecord-sqlserver-adapter 3.1.5 with Rails 3.1 with Arel ↵Adam H2012-01-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2.2.1 we encountered the error uninitialized constant Arel::Nodes::Visitors::DepthFirst apparently Arel was trying to call a relative namespace with Visitors::DepthFirst.new(block).accept self we fixed this by making it call an absolute namespace with ::Arel::Visitors::DepthFirst.new(block).accept self
* | | bumping to 3.0.0Aaron Patterson2012-01-124-12/+12
| | |
* | | Ensure @last_column is cleared after visiting objectNorman Clarke2012-01-071-1/+1
| | |
* | | calling cache methods against the connectionAaron Patterson2011-11-192-22/+16
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-20 00:53:27 +0000