Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | No need to quote MySQL LIMIT | Jean Boussier | 2015-07-10 | 1 | -1/+1 |
| | |||||
* | Special limited delete handling in MSSQL | Tamir Duberstein | 2015-02-23 | 2 | -2/+19 |
| | | | | | Refernce: https://technet.microsoft.com/en-us/library/ms175486%28v=sql.105%29.aspx | ||||
* | Delete should respect 'limit' | Bradford Folkens | 2015-02-23 | 1 | -3/+3 |
| | | | | | Conflicts: lib/arel/visitors/to_sql.rb | ||||
* | Change the interface of `having` to match that of `where` | Sean Griffin | 2015-01-27 | 3 | -8/+11 |
| | | | | | | These two clauses have nearly identical semantics with regards to how they would be constructed as an AST. It doesn't make sense for their interfaces to be separate. | ||||
* | Allow a type caster to be given to the `Arel::Table` object | Sean Griffin | 2014-12-29 | 1 | -1/+22 |
| | | | | | | | | | This will allow most consuming code to avoid the deprecation introduced in 008445d6fd5f825d9b445ac75a7be67f0f7ab52c. The only code which will be affected is code that is building the `Arel::Table` object manually, rather than calling `arel_table` on an Active Record class. Hopefully this case will be rare enough that we don't need to introduce any additional APIs to work around it. | ||||
* | {Matches,DoesNotMatch} support the ESCAPE clause with PostgreSQL | Kazuya NUMATA | 2014-12-25 | 1 | -2/+14 |
| | | | | | to_SQL already has supported the ESCAPE clause in #318. PostgreSQL can use the ESCAPE clause too. | ||||
* | Remove deprecated method "Table#primary_key" | Sean Griffin | 2014-11-26 | 1 | -3/+18 |
| | | | | | | | The only place this method was still used is on the MSSQL visitor. The visitor has all of the objects required to inline this lookup there. Since the `primary_key` method on the connection adapter will perform a query when called, we can cache the result on the visitor. | ||||
* | remove extra space before 'ORDER BY' | Nihad Abbasov | 2014-11-26 | 1 | -1/+0 |
| | |||||
* | Support Oracle bind parameter value | Yasuo Honda | 2014-11-20 | 1 | -0/+4 |
| | |||||
* | Use class objects rather than strings for the dispatch cache | Sean Griffin | 2014-11-18 | 2 | -18/+10 |
| | | | | | | | | The only reason we're using strings is to pre-populate the cache, but `Class#name` returns a new string instance on every call. This is a pretty major source of memory usage. We don't technically need to pre-populate the cache, and not doing so allows us to go back to using cache objects | ||||
* | Add order to BindParams in the ToSql collector | Sean Griffin | 2014-11-17 | 2 | -2/+7 |
| | | | | | | | | | | | | This removes the need for us to do the re-ordering by walking the AST in ActiveRecord. We're using a block to communicate with the collector, since the collector needs to be the thing which knows about the index, while the visitor is the thing that needs to know the syntax. The BindParam needs to know about neither of these things, so it's been changed to stop being a subclass of SqlLiteral I could also see an alternative implementation using format strings if for some reason blocks cause a problem. | ||||
* | cache the dispatch table on the depth first visitor | Aaron Patterson | 2014-11-10 | 2 | -6/+21 |
| | | | | | We know the API for the depth first visitor in advance, so it's OK to calcuate this cache in advance | ||||
* | oops! that should not have been checked in | Aaron Patterson | 2014-11-04 | 1 | -2/+1 |
| | |||||
* | Completes 08e6491 in reusing `maybe_visit` | claudiob | 2014-10-23 | 1 | -3/+3 |
| | | | | | | | | | :sweat: I don't know why the tests did not fail, but to keep the same syntax as before, `collector =` is required. Maybe `visit` changes `collector` in-place, so the result is the same, but since I'm not sure about the side effects, I think this PR is needed to. Sorry! :sweat: | ||||
* | Reuse `maybe_visit` method | claudiob | 2014-10-23 | 2 | -18/+4 |
| | | | | | This commit simply removes duplicated code by reusing the existing `maybe_visit` method. | ||||
* | {Matches,DoesNotMatch} support the ESCAPE clause | Tamir Duberstein | 2014-09-25 | 1 | -2/+14 |
| | |||||
* | move the dispatch table to be per-instance | Aaron Patterson | 2014-09-22 | 6 | -19/+37 |
| | | | | | | | visitors are not shared among threads, so any mutations to the cache should be OK. The cache is also pre-populated on construction, but we should pull that out so we can share the cache among visitors in the future. | ||||
* | connections should cache these values, so remove the cache in arel | Aaron Patterson | 2014-09-22 | 1 | -4/+3 |
| | |||||
* | Merge pull request #167 from pparidans/informix-v9-support | Rafael Mendonça França | 2014-09-17 | 1 | -1/+1 |
|\ | | | | | Informix versions < 10 use 'FIRST' keyword instead of 'LIMIT' | ||||
| * | Informix versions < 10 use 'FIRST' keyword instead of 'LIMIT' | Pierre Paridans | 2014-09-16 | 1 | -1/+1 |
| | | | | | | | | Still supported in versions 10+ | ||||
* | | Merge pull request #137 from dimko/visit_set | Rafael Mendonça França | 2014-09-17 | 3 | -0/+3 |
|\ \ | |/ |/| | Added a visitor for Set objects | ||||
| * | added a visitor for Set objects | Dimko | 2012-09-18 | 3 | -0/+3 |
| | | |||||
* | | Wrap group_by sql with a subquery for limiting rows in Oracle. | Chris Dinger | 2014-09-16 | 1 | -1/+1 |
| | | | | | | | | Fixes #128 | ||||
* | | `Extract#as` should not mutate the receiver | Tamir Duberstein | 2014-09-13 | 1 | -8/+1 |
| | | | | | | | | Fixes https://github.com/rails/rails/issues/16913 | ||||
* | | Merge pull request #277 from sergey-alekseev/wrap-nested-gropings-only-once | Rafael Mendonça França | 2014-09-12 | 1 | -2/+6 |
|\ \ | | | | | | | Wrap nested Nodes::Grouping in brackets only once | ||||
| * | | Wrap nested Nodes::Grouping in brackets only once | Sergey Alekseev | 2014-05-26 | 1 | -2/+6 |
| | | | |||||
* | | | Windowing: Calling #rows or #range should assign framing only once. | Alexander Staubo | 2014-06-22 | 1 | -0/+2 |
| | | | |||||
* | | | Windowing support for PARTITION BY clause. | Alexander Staubo | 2014-06-20 | 2 | -0/+8 |
| | | | |||||
* | | | Modify Visitors::Dot's API to use collectors | Jiri Pospisil | 2014-06-14 | 1 | -2/+2 |
| | | | |||||
* | | | Make sure visit_Arel_Nodes_With works with collectors | Jiri Pospisil | 2014-06-12 | 1 | -2/+3 |
| | | | |||||
* | | | Remove unused values variable | Vipul A M | 2014-06-01 | 1 | -2/+0 |
| | | | |||||
* | | | Merge pull request #276 from brocktimus/master | Rafael Mendonça França | 2014-05-28 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Fixing method signature for unsupported visits in the ToSQL Visitor | ||||
| * | | | Fixing method signature for unsupported visits in the ToSQL Visitor | Brock Trappitt | 2014-05-26 | 1 | -1/+1 |
| |/ / | |||||
* / / | Fix typo `delegte` => `delegate` | Vipul A M | 2014-05-25 | 1 | -1/+1 |
|/ / | |||||
* | | Support to add the casting node to the AST at build time | Yasuo Honda | 2014-05-05 | 1 | -1/+1 |
| | | | | | | | | Ref https://github.com/rails/arel/commit/93d72131bcc24ccb5536bec672d2dac94f8de651 | ||||
* | | Add collector argument to address ArgumentError: wrong number of arguments ↵ | Yasuo Honda | 2014-05-02 | 1 | -1/+1 |
| | | | | | | | | (2 for 1) | ||||
* | | always add a space before keywords (it is easier) | Aaron Patterson | 2014-04-11 | 1 | -9/+3 |
| | | |||||
* | | Allow INSERT INTO <table> SELECT queries | Jean Boussier | 2014-04-10 | 1 | -1/+7 |
| | | |||||
* | | fix spacing so that Rails is happy | Aaron Patterson | 2014-04-09 | 1 | -3/+9 |
| | | |||||
* | | rhs bind parameters should be visited | Aaron Patterson | 2014-04-09 | 1 | -1/+1 |
| | | |||||
* | | fix bind values in insert statements | Aaron Patterson | 2014-04-09 | 2 | -8/+12 |
| | | |||||
* | | adding a bind value collector | Aaron Patterson | 2014-04-09 | 1 | -1/+4 |
| | | |||||
* | | add a compile method for some backwards compatibility | Aaron Patterson | 2014-04-09 | 1 | -0/+4 |
| | | |||||
* | | make the bindvalue visitor backwards compatible | Aaron Patterson | 2014-04-09 | 1 | -1/+4 |
| | | |||||
* | | fixing BINARY tests | Aaron Patterson | 2014-04-08 | 2 | -4/+5 |
| | | |||||
* | | fixing EXTRACT | Aaron Patterson | 2014-04-08 | 1 | -2/+10 |
| | | |||||
* | | fixing OVER | Aaron Patterson | 2014-04-08 | 1 | -9/+9 |
| | | |||||
* | | fixing insert manager | Aaron Patterson | 2014-04-08 | 1 | -5/+9 |
| | | |||||
* | | fixing test_table.rb | Aaron Patterson | 2014-04-08 | 1 | -9/+9 |
| | | |||||
* | | fixing ibm db | Aaron Patterson | 2014-04-08 | 1 | -2/+4 |
| | |