| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
|
|\ \
| | |
| | |
| | |
| | | |
* master:
finally stop returning strings
|
| | | |
|
|\| |
| | |
| | |
| | |
| | | |
* master:
loop over cores twice to make the collector implementation more convenient
|
| | | |
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* master:
build the ast rather than passing around strings
move the ORDER BY to the RowNumber method
move all the "ORDER BY" together
use if / else so my brain stops hurting
refactor mssql nodes to move away from string interpolation
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
this lets our old depth first and dot visitors to work normally
|
| | | |
|
| | | |
|
|\| |
| | |
| | |
| | |
| | | |
* master:
removing unused join_sql method
|
| | | |
|
| | | |
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* master:
remove order_clauses since we do not use it
fix whitespace and unsupported method args
Add Regexp and NotRegexp nodes for PostgreSQL
Revert "Merge pull request #253 from corrupt952/master"
flatten object.children in visit_Arel_Node_And
Added right and full outer joins
Conflicts:
lib/arel/visitors/to_sql.rb
lib/arel/visitors/visitor.rb
|
| | | |
|
| |\ \
| | | |
| | | | |
Add Regexp and NotRegexp nodes for PostgreSQL
|
| | | | |
|
| |/ / |
|
| | |
| | |
| | |
| | |
| | | |
This reverts commit 6d3ed6d96c4a3ac85b97d81bad95b7254b2aa2d4, reversing
changes made to a35fede61ac1a2fcff519ad052f2fcb8808922b9.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|/ / |
|
| | |
|
| | |
|
| |
| |
| |
| | |
also fixed the test case for : test/visitors/test_to_sql.rb:22 which pass in the parameter attribute e.g the parameter a.
|
| |
| |
| |
| |
| | |
If we add the casting node to the ast at build time, then we can avoid
doing the lookup at visit time.
|
|\ \
| | |
| | | |
Assign value from attribute test
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Such queries become possible for mortals:
```ruby
table.where(table[:qux].eq 'zomg').compile_update(table[:foo] => table[:bar])
```
Arguably much more sane than using `engine.connection.quote_column_name`
or `engine.connection.visitor.accept` on the right hand (bar), which is
totally leaking the abstraction.
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| | |
In commit 68a95542e1a7a79d9777223fbffd2b982fed0268 the last_column feature of ToSql was removed. The visit_Arel_Nodes_Matches and visit_Arel_Nodes_DoesNotMatch methods are overwritten in the PostgreSQL class, but were not updated appropriately. This commit fixes the issue accordingly.
This bug affects at least all update_all statements in Rails 4.0.2 that have subqueries with ILIKE statements on PostgreSQL. The bug is present in Arel 4.0.1 and later, so it probably affects most Rails 4.0.2 projects.
It would be highly appreciated if Arel 4 could get a point release as well. Thanks for your continued work.
|
| |
| |
| | |
Documenting the library's behavior. People and other libraries (cf. Squeel) have come to depend on this behavior, and so am submitting this pull request to specify it authoritatively.
|
| | |
|
| |
| |
| |
| | |
`UpdateManager#key`
|
| | |
|
|\ \
| | |
| | | |
Support `columns_for_distinct` with Oracle adapter
|
| | | |
|
|/ / |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The last_column feature of the ToSql visitor and its descendants is what
enabled quoting based on the column last visited -- in other words, if
you have a standard condition like an equality with a string attribute
on the left side and an integer on the right side, then when ARel visits
the node, it'll first visit the left side attribute, setting the
column of the string attribute as the last column, and resulting in the
right side of the condition getting the appropriate quoting.
The downside is that this means that visitors can't be shared between
threads, because of the state mutation. It also makes for some really
weird behavior in the event that the visitor visits a node that happens
to contain an attribute you weren't expecting to be there, since it'll
potentially quote something based on that attribute. So, it prevents
reversing an equality condition. column = value will work, but not value
= column, since the last column wouldn't be the column you're hoping
for.
This is a first pass at fixing this by changing the signature of the
visit methods to accept the currently-relevant attribute, if any.
|
| |
| |
| |
| |
| |
| |
| | |
The project uses "Arel" most of the time, but there were a few "ARel"
here and there. I checked with @brynary back in 2010 to pick one for
the Rails documentation guidelines and "Arel" was chosen and documented.
This patch chooses "Arel" vs "ARel" based on that.
|