aboutsummaryrefslogtreecommitdiffstats
path: root/lib/arel/visitors
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'master' into collectorAaron Patterson2014-04-081-2/+3
|\ | | | | | | | | * master: finally stop returning strings
| * finally stop returning stringsAaron Patterson2014-04-081-2/+3
| |
* | Merge branch 'master' into collectorAaron Patterson2014-04-081-3/+3
|\| | | | | | | | | * master: loop over cores twice to make the collector implementation more convenient
| * loop over cores twice to make the collector implementation more convenientAaron Patterson2014-04-081-3/+3
| |
* | Merge branch 'master' into collectorAaron Patterson2014-04-081-10/+22
|\| | | | | | | | | | | | | | | | | * master: build the ast rather than passing around strings move the ORDER BY to the RowNumber method move all the "ORDER BY" together use if / else so my brain stops hurting refactor mssql nodes to move away from string interpolation
| * build the ast rather than passing around stringsAaron Patterson2014-04-081-12/+10
| |
| * move the ORDER BY to the RowNumber methodAaron Patterson2014-04-081-4/+4
| |
| * move all the "ORDER BY" togetherAaron Patterson2014-04-081-7/+9
| |
| * use if / else so my brain stops hurtingAaron Patterson2014-04-081-1/+1
| |
| * refactor mssql nodes to move away from string interpolationAaron Patterson2014-04-081-1/+13
| |
* | fixing mysql visitorAaron Patterson2014-04-081-19/+42
| |
* | oracle tests passingAaron Patterson2014-04-081-19/+28
| |
* | postgresql visitor is workingAaron Patterson2014-04-082-12/+13
| |
* | fix sqlite visitorAaron Patterson2014-04-081-2/+3
| |
* | push reduction visitors to a reduction base classAaron Patterson2014-04-085-20/+36
| | | | | | | | this lets our old depth first and dot visitors to work normally
* | select manager tests are passingAaron Patterson2014-04-081-14/+25
| |
* | more select manager tests passingAaron Patterson2014-04-082-14/+36
| |
* | Merge branch 'master' into collectorAaron Patterson2014-04-081-19/+0
|\| | | | | | | | | * master: removing unused join_sql method
| * removing unused join_sql methodAaron Patterson2014-04-081-19/+0
| |
* | making some of the sql manager tests passAaron Patterson2014-04-082-48/+91
| |
* | Merge branch 'master' into collectorAaron Patterson2014-04-086-14/+42
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | * master: remove order_clauses since we do not use it fix whitespace and unsupported method args Add Regexp and NotRegexp nodes for PostgreSQL Revert "Merge pull request #253 from corrupt952/master" flatten object.children in visit_Arel_Node_And Added right and full outer joins Conflicts: lib/arel/visitors/to_sql.rb lib/arel/visitors/visitor.rb
| * remove order_clauses since we do not use itAaron Patterson2014-04-081-11/+0
| |
| * Merge pull request #248 from chewi/masterAaron Patterson2014-04-073-0/+18
| |\ | | | | | | Add Regexp and NotRegexp nodes for PostgreSQL
| | * Add Regexp and NotRegexp nodes for PostgreSQLJames Le Cuirot2014-04-083-0/+18
| | |
| * | fix whitespace and unsupported method argsAaron Patterson2014-04-072-2/+2
| |/
| * Revert "Merge pull request #253 from corrupt952/master"Aaron Patterson2014-04-071-1/+1
| | | | | | | | | | This reverts commit 6d3ed6d96c4a3ac85b97d81bad95b7254b2aa2d4, reversing changes made to a35fede61ac1a2fcff519ad052f2fcb8808922b9.
| * flatten object.children in visit_Arel_Node_AndKazuki Hasegawa2014-04-031-1/+1
| |
| * Added right and full outer joinsStephen Prater & Fire-Dragon-DoL2014-03-303-1/+13
| |
* | to_sql is passingAaron Patterson2014-04-081-57/+97
| |
* | fixing some tests in to_sqlAaron Patterson2014-04-081-67/+112
| |
* | bind visitor working with collector objectAaron Patterson2014-04-083-11/+14
|/
* remove the default parameter and updated commentAlex Lin2014-03-252-3/+3
|
* removed the attribute that was left in for testingAlex Lin2014-03-251-1/+1
|
* Removed all the fiels in lib/arel/visitors/ which needs dependency on 'a' ↵Alex Lin2014-03-2415-380/+367
| | | | also fixed the test case for : test/visitors/test_to_sql.rb:22 which pass in the parameter attribute e.g the parameter a.
* add the casting node to the AST at build timeAaron Patterson2014-03-242-15/+29
| | | | | If we add the casting node to the ast at build time, then we can avoid doing the lookup at visit time.
* Merge pull request #246 from cmohanprasath/assign_value_from_attribute_testAaron Patterson2014-02-241-2/+7
|\ | | | | Assign value from attribute test
| * Allow assignment right member to reference columnsLoic Nageleisen2014-02-111-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | Such queries become possible for mortals: ```ruby table.where(table[:qux].eq 'zomg').compile_update(table[:foo] => table[:bar]) ``` Arguably much more sane than using `engine.connection.quote_column_name` or `engine.connection.visitor.accept` on the right hand (bar), which is totally leaking the abstraction.
* | Remove deprecated Arel::SqlLiteralRafael Mendonça França2014-02-103-3/+0
|/
* PostgreSQL bugfix for invalid SQL in subqueriesvanderhoorn2014-02-051-0/+2
| | | | | | | In commit 68a95542e1a7a79d9777223fbffd2b982fed0268 the last_column feature of ToSql was removed. The visit_Arel_Nodes_Matches and visit_Arel_Nodes_DoesNotMatch methods are overwritten in the PostgreSQL class, but were not updated appropriately. This commit fixes the issue accordingly. This bug affects at least all update_all statements in Rails 4.0.2 that have subqueries with ILIKE statements on PostgreSQL. The bug is present in Arel 4.0.1 and later, so it probably affects most Rails 4.0.2 projects. It would be highly appreciated if Arel 4 could get a point release as well. Thanks for your continued work.
* Documented the case-insensitive nature of the match feature.Robb Shecter2013-12-051-0/+4
| | | Documenting the library's behavior. People and other libraries (cf. Squeel) have come to depend on this behavior, and so am submitting this pull request to specify it authoritatively.
* Remove deprecated calls from the testsRafael Mendonça França2013-12-051-2/+2
|
* Remove deprecated calls to using `UpdateManager` without setting ↵Vipul A M2013-11-101-11/+1
| | | | `UpdateManager#key`
* Fix warning of shadowing variableRafael Mendonça França2013-10-241-2/+2
|
* Merge pull request #211 from yahonda/support_columns_for_distinct_oracleAaron Patterson2013-10-211-2/+2
|\ | | | | Support `columns_for_distinct` with Oracle adapter
| * Support `columns_for_distinct`Yasuo Honda2013-10-141-2/+2
| |
* | fix one deprecation warningAaron Patterson2013-10-141-1/+1
|/
* Cache visitor dispatch on a per-visitor basisColin Jones2013-08-141-3/+6
|
* Make visitors threadsafe by removing @last_columnErnie Miller2013-04-2815-381/+385
| | | | | | | | | | | | | | | | | | | | | | The last_column feature of the ToSql visitor and its descendants is what enabled quoting based on the column last visited -- in other words, if you have a standard condition like an equality with a string attribute on the left side and an integer on the right side, then when ARel visits the node, it'll first visit the left side attribute, setting the column of the string attribute as the last column, and resulting in the right side of the condition getting the appropriate quoting. The downside is that this means that visitors can't be shared between threads, because of the state mutation. It also makes for some really weird behavior in the event that the visitor visits a node that happens to contain an attribute you weren't expecting to be there, since it'll potentially quote something based on that attribute. So, it prevents reversing an equality condition. column = value will work, but not value = column, since the last column wouldn't be the column you're hoping for. This is a first pass at fixing this by changing the signature of the visit methods to accept the currently-relevant attribute, if any.
* ARel -> ArelXavier Noria2013-04-142-2/+2
| | | | | | | The project uses "Arel" most of the time, but there were a few "ARel" here and there. I checked with @brynary back in 2010 to pick one for the Rails documentation guidelines and "Arel" was chosen and documented. This patch chooses "Arel" vs "ARel" based on that.
* Revert issue #99 fixesEduardo Mourao2013-03-151-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are two commits involving issue #99 which should be reverted. First of all, #99 is not an issue in Arel at all. Second, the fix provides pretty much destroys the purpose of pagination by cause full table scans. The original code (it seems I can't simply revert the commits) is 900 times slower than this one. ``` SELECT * FROM ( SELECT raw_sql_.*, rownum raw_rnum_ FROM (SELECT "LANCAMENTOS".* FROM "LANCAMENTOS" ) raw_sql_ ) WHERE raw_rnum_ between 1 and 30 ---------------------------------------------------------------------------------- | Id | Operation | Name | Rows | Bytes | Cost (%CPU)| Time | ----------------------------------------------------------------------------------- | 0 | SELECT STATEMENT | | 4636K| 2701M| 23442 (2)| 00:04:42 | |* 1 | VIEW | | 4636K| 2701M| 23442 (2)| 00:04:42 | | 2 | COUNT | | | | | | | 3 | TABLE ACCESS FULL| LANCAMENTOS | 4636K| 738M| 23442 (2)| 00:04:42 | ----------------------------------------------------------------------------------- Predicate Information (identified by operation id): --------------------------------------------------- 1 - filter("RAW_RNUM_"<=30 AND "RAW_RNUM_">=1) Statistics ----------------------------------------------------------- 4 user calls 13 physical read total multi block requests 202588160 physical read total bytes 202588160 cell physical IO interconnect bytes 0 commit cleanout failures: block lost 0 IMU commits 0 IMU Flushes 0 IMU contention 0 IMU bind flushes 0 IMU mbu flush SELECT * FROM ( SELECT raw_sql_.*, rownum raw_rnum_ FROM (SELECT "LANCAMENTOS".* FROM "LANCAMENTOS" ) raw_sql_ WHERE rownum <= 30 ) WHERE raw_rnum_ >= 0 ----------------------------------------------------------------------------------- | Id | Operation | Name | Rows | Bytes | Cost (%CPU)| Time | ----------------------------------------------------------------------------------- | 0 | SELECT STATEMENT | | 30 | 18330 | 2 (0)| 00:00:01 | |* 1 | VIEW | | 30 | 18330 | 2 (0)| 00:00:01 | |* 2 | COUNT STOPKEY | | | | | | | 3 | TABLE ACCESS FULL| LANCAMENTOS | 30 | 5010 | 2 (0)| 00:00:01 | ----------------------------------------------------------------------------------- Predicate Information (identified by operation id): --------------------------------------------------- 1 - filter("RAW_RNUM_">=0) 2 - filter(ROWNUM<=30) Statistics ----------------------------------------------------------- 4 user calls 0 physical read total multi block requests 0 physical read total bytes 0 cell physical IO interconnect bytes 0 commit cleanout failures: block lost 0 IMU commits 0 IMU Flushes 0 IMU contention 0 IMU bind flushes 0 IMU mbu flush ```
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-17 04:57:11 +0000