Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | push reduction visitors to a reduction base class | Aaron Patterson | 2014-04-08 | 1 | -4/+4 |
| | | | | this lets our old depth first and dot visitors to work normally | ||||
* | bind visitor working with collector object | Aaron Patterson | 2014-04-08 | 1 | -4/+4 |
| | |||||
* | removed the attribute that was left in for testing | Alex Lin | 2014-03-25 | 1 | -1/+1 |
| | |||||
* | Removed all the fiels in lib/arel/visitors/ which needs dependency on 'a' ↵ | Alex Lin | 2014-03-24 | 1 | -1/+1 |
| | | | | also fixed the test case for : test/visitors/test_to_sql.rb:22 which pass in the parameter attribute e.g the parameter a. | ||||
* | Fix warning of shadowing variable | Rafael Mendonça França | 2013-10-24 | 1 | -2/+2 |
| | |||||
* | Cache visitor dispatch on a per-visitor basis | Colin Jones | 2013-08-14 | 1 | -3/+6 |
| | |||||
* | Make visitors threadsafe by removing @last_column | Ernie Miller | 2013-04-28 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | The last_column feature of the ToSql visitor and its descendants is what enabled quoting based on the column last visited -- in other words, if you have a standard condition like an equality with a string attribute on the left side and an integer on the right side, then when ARel visits the node, it'll first visit the left side attribute, setting the column of the string attribute as the last column, and resulting in the right side of the condition getting the appropriate quoting. The downside is that this means that visitors can't be shared between threads, because of the state mutation. It also makes for some really weird behavior in the event that the visitor visits a node that happens to contain an attribute you weren't expecting to be there, since it'll potentially quote something based on that attribute. So, it prevents reversing an equality condition. column = value will work, but not value = column, since the last column wouldn't be the column you're hoping for. This is a first pass at fixing this by changing the signature of the visit methods to accept the currently-relevant attribute, if any. | ||||
* | visitors can define their own cache strategy for dispatch. fixes #57 | Aaron Patterson | 2011-06-27 | 1 | -4/+8 |
| | |||||
* | visiting via superclass is OK, since module definitions help delegate | Aaron Patterson | 2011-01-04 | 1 | -1/+0 |
| | |||||
* | fixing tests for oracle visitor | Aaron Patterson | 2011-01-03 | 1 | -1/+2 |
| | |||||
* | make sure we raise type errors with unknown classes | Aaron Patterson | 2010-12-01 | 1 | -0/+1 |
| | |||||
* | fixing tests in 1.9 | Aaron Patterson | 2010-11-30 | 1 | -1/+1 |
| | |||||
* | adding deprecated support for walking ancestor trees | Aaron Patterson | 2010-11-30 | 1 | -0/+7 |
| | |||||
* | adding a base class visitor | Aaron Patterson | 2010-10-19 | 1 | -0/+19 |