| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
Ref https://github.com/rails/arel/commit/93d72131bcc24ccb5536bec672d2dac94f8de651
|
| |
|
|
| |
(2 for 1)
|
| | |
|
| | |
|
| |
|
|
| |
also fixed the test case for : test/visitors/test_to_sql.rb:22 which pass in the parameter attribute e.g the parameter a.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The last_column feature of the ToSql visitor and its descendants is what
enabled quoting based on the column last visited -- in other words, if
you have a standard condition like an equality with a string attribute
on the left side and an integer on the right side, then when ARel visits
the node, it'll first visit the left side attribute, setting the
column of the string attribute as the last column, and resulting in the
right side of the condition getting the appropriate quoting.
The downside is that this means that visitors can't be shared between
threads, because of the state mutation. It also makes for some really
weird behavior in the event that the visitor visits a node that happens
to contain an attribute you weren't expecting to be there, since it'll
potentially quote something based on that attribute. So, it prevents
reversing an equality condition. column = value will work, but not value
= column, since the last column wouldn't be the column you're hoping
for.
This is a first pass at fixing this by changing the signature of the
visit methods to accept the currently-relevant attribute, if any.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two commits involving issue #99 which should be reverted.
First of all, #99 is not an issue in Arel at all. Second, the fix provides pretty much destroys the purpose of pagination by cause full table scans.
The original code (it seems I can't simply revert the commits) is 900 times slower than this one.
```
SELECT * FROM (
SELECT raw_sql_.*, rownum raw_rnum_
FROM (SELECT "LANCAMENTOS".* FROM "LANCAMENTOS" ) raw_sql_
)
WHERE raw_rnum_ between 1 and 30
----------------------------------------------------------------------------------
| Id | Operation | Name | Rows | Bytes | Cost (%CPU)| Time |
-----------------------------------------------------------------------------------
| 0 | SELECT STATEMENT | | 4636K| 2701M| 23442 (2)| 00:04:42 |
|* 1 | VIEW | | 4636K| 2701M| 23442 (2)| 00:04:42 |
| 2 | COUNT | | | | | |
| 3 | TABLE ACCESS FULL| LANCAMENTOS | 4636K| 738M| 23442 (2)| 00:04:42 |
-----------------------------------------------------------------------------------
Predicate Information (identified by operation id):
---------------------------------------------------
1 - filter("RAW_RNUM_"<=30 AND "RAW_RNUM_">=1)
Statistics
-----------------------------------------------------------
4 user calls
13 physical read total multi block requests
202588160 physical read total bytes
202588160 cell physical IO interconnect bytes
0 commit cleanout failures: block lost
0 IMU commits
0 IMU Flushes
0 IMU contention
0 IMU bind flushes
0 IMU mbu flush
SELECT * FROM (
SELECT raw_sql_.*, rownum raw_rnum_
FROM (SELECT "LANCAMENTOS".* FROM "LANCAMENTOS" ) raw_sql_
WHERE rownum <= 30
)
WHERE raw_rnum_ >= 0
-----------------------------------------------------------------------------------
| Id | Operation | Name | Rows | Bytes | Cost (%CPU)| Time |
-----------------------------------------------------------------------------------
| 0 | SELECT STATEMENT | | 30 | 18330 | 2 (0)| 00:00:01 |
|* 1 | VIEW | | 30 | 18330 | 2 (0)| 00:00:01 |
|* 2 | COUNT STOPKEY | | | | | |
| 3 | TABLE ACCESS FULL| LANCAMENTOS | 30 | 5010 | 2 (0)| 00:00:01 |
-----------------------------------------------------------------------------------
Predicate Information (identified by operation id):
---------------------------------------------------
1 - filter("RAW_RNUM_">=0)
2 - filter(ROWNUM<=30)
Statistics
-----------------------------------------------------------
4 user calls
0 physical read total multi block requests
0 physical read total bytes
0 cell physical IO interconnect bytes
0 commit cleanout failures: block lost
0 IMU commits
0 IMU Flushes
0 IMU contention
0 IMU bind flushes
0 IMU mbu flush
```
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Aliased :minus to :except for the SelectManager
|
| |\
| |
| |
| |
| | |
* 2-0-stable:
should return nil instead of empty string
|
| | | |
|
| |\|
| |
| |
| |
| | |
* 2-0-stable:
we do not need to modify the AST
|
| | | |
|
| | | |
|
| | | |
|
| |/ |
|
| | |
|
| |
|
| |
correctly split order string by commas ignoring commas which separate function arguments
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
