Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Removed all the fiels in lib/arel/visitors/ which needs dependency on 'a' ↵ | Alex Lin | 2014-03-24 | 1 | -2/+2 |
| | | | | also fixed the test case for : test/visitors/test_to_sql.rb:22 which pass in the parameter attribute e.g the parameter a. | ||||
* | Make visitors threadsafe by removing @last_column | Ernie Miller | 2013-04-28 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | The last_column feature of the ToSql visitor and its descendants is what enabled quoting based on the column last visited -- in other words, if you have a standard condition like an equality with a string attribute on the left side and an integer on the right side, then when ARel visits the node, it'll first visit the left side attribute, setting the column of the string attribute as the last column, and resulting in the right side of the condition getting the appropriate quoting. The downside is that this means that visitors can't be shared between threads, because of the state mutation. It also makes for some really weird behavior in the event that the visitor visits a node that happens to contain an attribute you weren't expecting to be there, since it'll potentially quote something based on that attribute. So, it prevents reversing an equality condition. column = value will work, but not value = column, since the last column wouldn't be the column you're hoping for. This is a first pass at fixing this by changing the signature of the visit methods to accept the currently-relevant attribute, if any. | ||||
* | string join should be a unary op | Aaron Patterson | 2010-12-14 | 1 | -7/+0 |
| | |||||
* | adding a join source node | Aaron Patterson | 2010-12-14 | 1 | -16/+1 |
| | |||||
* | just return a blank string if the base from is not a join | Aaron Patterson | 2010-12-07 | 1 | -1/+2 |
| | |||||
* | attributes do not need a column member | Aaron Patterson | 2010-12-03 | 1 | -1/+1 |
| | |||||
* | doing a little cleanup on the visitors | Aaron Patterson | 2010-10-19 | 1 | -0/+2 |
| | |||||
* | from does not need to be a list | Aaron Patterson | 2010-09-20 | 1 | -1/+1 |
| | |||||
* | JoinSql visitor will visit left side if left is a join | Aaron Patterson | 2010-09-15 | 1 | -3/+9 |
| | |||||
* | OUTER JOIN should be LEFT OUTER JOIN | Aaron Patterson | 2010-09-12 | 1 | -1/+1 |
| | |||||
* | only visiting left side if left side is a JOIN | Aaron Patterson | 2010-09-12 | 1 | -1/+4 |
| | |||||
* | supporting StringJoin in the JoinSQL visitor | Aaron Patterson | 2010-09-12 | 1 | -0/+4 |
| | |||||
* | moving visitor logic to the visitor | Aaron Patterson | 2010-08-24 | 1 | -0/+4 |
| | |||||
* | adding string join nodes and a visitor to produce backwards compatible ↵ | Aaron Patterson | 2010-08-24 | 1 | -0/+21 |
"join_sql" |