aboutsummaryrefslogtreecommitdiffstats
path: root/lib/arel/visitors/join_sql.rb
Commit message (Collapse)AuthorAgeFilesLines
* Removed all the fiels in lib/arel/visitors/ which needs dependency on 'a' ↵Alex Lin2014-03-241-2/+2
| | | | also fixed the test case for : test/visitors/test_to_sql.rb:22 which pass in the parameter attribute e.g the parameter a.
* Make visitors threadsafe by removing @last_columnErnie Miller2013-04-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | The last_column feature of the ToSql visitor and its descendants is what enabled quoting based on the column last visited -- in other words, if you have a standard condition like an equality with a string attribute on the left side and an integer on the right side, then when ARel visits the node, it'll first visit the left side attribute, setting the column of the string attribute as the last column, and resulting in the right side of the condition getting the appropriate quoting. The downside is that this means that visitors can't be shared between threads, because of the state mutation. It also makes for some really weird behavior in the event that the visitor visits a node that happens to contain an attribute you weren't expecting to be there, since it'll potentially quote something based on that attribute. So, it prevents reversing an equality condition. column = value will work, but not value = column, since the last column wouldn't be the column you're hoping for. This is a first pass at fixing this by changing the signature of the visit methods to accept the currently-relevant attribute, if any.
* string join should be a unary opAaron Patterson2010-12-141-7/+0
|
* adding a join source nodeAaron Patterson2010-12-141-16/+1
|
* just return a blank string if the base from is not a joinAaron Patterson2010-12-071-1/+2
|
* attributes do not need a column memberAaron Patterson2010-12-031-1/+1
|
* doing a little cleanup on the visitorsAaron Patterson2010-10-191-0/+2
|
* from does not need to be a listAaron Patterson2010-09-201-1/+1
|
* JoinSql visitor will visit left side if left is a joinAaron Patterson2010-09-151-3/+9
|
* OUTER JOIN should be LEFT OUTER JOINAaron Patterson2010-09-121-1/+1
|
* only visiting left side if left side is a JOINAaron Patterson2010-09-121-1/+4
|
* supporting StringJoin in the JoinSQL visitorAaron Patterson2010-09-121-0/+4
|
* moving visitor logic to the visitorAaron Patterson2010-08-241-0/+4
|
* adding string join nodes and a visitor to produce backwards compatible ↵Aaron Patterson2010-08-241-0/+21
"join_sql"