Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Make visitors threadsafe by removing @last_column | Ernie Miller | 2013-04-28 | 1 | -75/+75 |
| | | | | | | | | | | | | | | | | | | | | | | The last_column feature of the ToSql visitor and its descendants is what enabled quoting based on the column last visited -- in other words, if you have a standard condition like an equality with a string attribute on the left side and an integer on the right side, then when ARel visits the node, it'll first visit the left side attribute, setting the column of the string attribute as the last column, and resulting in the right side of the condition getting the appropriate quoting. The downside is that this means that visitors can't be shared between threads, because of the state mutation. It also makes for some really weird behavior in the event that the visitor visits a node that happens to contain an attribute you weren't expecting to be there, since it'll potentially quote something based on that attribute. So, it prevents reversing an equality condition. column = value will work, but not value = column, since the last column wouldn't be the column you're hoping for. This is a first pass at fixing this by changing the signature of the visit methods to accept the currently-relevant attribute, if any. | ||||
* | ARel -> Arel | Xavier Noria | 2013-04-14 | 1 | -1/+1 |
| | | | | | | | The project uses "Arel" most of the time, but there were a few "ARel" here and there. I checked with @brynary back in 2010 to pick one for the Rails documentation guidelines and "Arel" was chosen and documented. This patch chooses "Arel" vs "ARel" based on that. | ||||
* | fixing bind param visiting in the dot visitor | Aaron Patterson | 2013-01-30 | 1 | -1/+1 |
| | |||||
* | Add #extract, which produces ANSI SQL function EXTRACT(<field> from <expr>). | Alexander Staubo | 2012-02-23 | 1 | -0/+6 |
| | |||||
* | Support ANSI SQL2003 window functions. | Alexander Staubo | 2012-02-22 | 1 | -0/+19 |
| | |||||
* | bind parameters can be differentiated from sql literals | Aaron Patterson | 2012-02-20 | 1 | -0/+1 |
| | |||||
* | Break Ordering into Ascending/Descending nodes, allow reversal | Ernie Miller | 2011-06-15 | 1 | -1/+0 |
| | |||||
* | Added Arel::Nodes::NamedFunction for representing generic SQL functions | Aaron Patterson | 2011-01-04 | 1 | -7/+18 |
| | |||||
* | top and limit can be visited | Aaron Patterson | 2011-01-03 | 1 | -0/+2 |
| | |||||
* | testing binary ops in the dot visitor | Aaron Patterson | 2010-12-25 | 1 | -14/+16 |
| | |||||
* | fix join dot visitors | Aaron Patterson | 2010-12-20 | 1 | -2/+0 |
| | |||||
* | adding a join source node | Aaron Patterson | 2010-12-14 | 1 | -2/+2 |
| | |||||
* | testing nary nodes in the depth first visitor | Aaron Patterson | 2010-12-10 | 1 | -1/+7 |
| | |||||
* | consolidating dot visitor methods | Aaron Patterson | 2010-12-06 | 1 | -12/+0 |
| | |||||
* | adding a test for the dot visitor | Aaron Patterson | 2010-12-06 | 1 | -2/+9 |
| | |||||
* | doing a little cleanup on the visitors | Aaron Patterson | 2010-10-19 | 1 | -3/+3 |
| | |||||
* | Support Attribute#asc and Attribute#desc to create orderings | Ernie Miller | 2010-09-29 | 1 | -0/+5 |
| | |||||
* | Support visiting Arel_Attribute_Float | Ernie Miller | 2010-09-29 | 1 | -0/+1 |
| | |||||
* | adding better dot file support for our nodes | Aaron Patterson | 2010-09-29 | 1 | -2/+36 |
| | |||||
* | fixing column escape for IN nodes. [resolves:5732] | Aaron Patterson | 2010-09-29 | 1 | -0/+5 |
| | |||||
* | adding offset edge | Aaron Patterson | 2010-09-24 | 1 | -0/+1 |
| | |||||
* | visiting value nodes in the dot visitor | Aaron Patterson | 2010-09-14 | 1 | -0/+4 |
| | |||||
* | adding orders edge to the dot visitor | Aaron Patterson | 2010-09-14 | 1 | -0/+1 |
| | |||||
* | Merge branch 'v1' of github.com:flavorjones/arel into v1 | Aaron Patterson | 2010-09-14 | 1 | -1/+6 |
|\ | | | | | | | | | | | | | | | | | * 'v1' of github.com:flavorjones/arel: sql visitor should emit a table alias name when visiting an attribute, if a table alias exists. dot visitor for binary nodes Conflicts: lib/arel/visitors/dot.rb | ||||
| * | dot visitor for binary nodes | Mike Dalessio | 2010-09-14 | 1 | -0/+7 |
| | | |||||
* | | adding AND nodes to dot visitor | Aaron Patterson | 2010-09-14 | 1 | -0/+1 |
|/ | |||||
* | visiting constraint edges of joins | Aaron Patterson | 2010-09-12 | 1 | -0/+5 |
| | |||||
* | supporting StringJoin in the JoinSQL visitor | Aaron Patterson | 2010-09-12 | 1 | -0/+1 |
| | |||||
* | equality should handle nil correctly | Aaron Patterson | 2010-09-10 | 1 | -0/+1 |
| | |||||
* | visiting symbols in the SQL visitor | Aaron Patterson | 2010-09-08 | 1 | -0/+1 |
| | |||||
* | visiting outer joins | Aaron Patterson | 2010-09-07 | 1 | -0/+1 |
| | |||||
* | getting better on joins | Aaron Patterson | 2010-09-07 | 1 | -0/+7 |
| | |||||
* | dot visitor can visit count nodes | Aaron Patterson | 2010-09-06 | 1 | -0/+5 |
| | |||||
* | adding string join nodes and a visitor to produce backwards compatible ↵ | Aaron Patterson | 2010-08-24 | 1 | -0/+5 |
| | | | | "join_sql" | ||||
* | dot visitor supports Arel::Nodes::UpdateStatement | Mike Dalessio | 2010-08-16 | 1 | -0/+6 |
| | |||||
* | dot visitor supports Arel::Nodes::Equality | Mike Dalessio | 2010-08-16 | 1 | -0/+5 |
| | |||||
* | dot visitor supports symbols | Mike Dalessio | 2010-08-16 | 1 | -0/+1 |
| | |||||
* | sql visitor can deal with TrueClass | Aaron Patterson | 2010-08-16 | 1 | -0/+8 |
| | |||||
* | quoting strings from equality statements, adding to_dot | Aaron Patterson | 2010-08-16 | 1 | -1/+7 |
| | |||||
* | insert manager implements "insert" | Aaron Patterson | 2010-08-13 | 1 | -3/+19 |
| | |||||
* | adding a dot visitor to make our lives easier | Aaron Patterson | 2010-08-13 | 1 | -0/+108 |