aboutsummaryrefslogtreecommitdiffstats
path: root/lib/active_storage
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Merge pull request #53 from colorfulfool/error-messagesGeorge Claghorn2017-07-142-2/+5
| |\ \ | | | | | | | | Useful error messages for two possible misconfigurations
| | * | Fail early if no storage service is specifiedcolorfulfool2017-07-151-0/+3
| | | |
| | * | Don't fail on boot because of missing S3 keys when S3 is not usedcolorfulfool2017-07-151-2/+2
| | |/
| * / Revert back to the original implementaion with varaiblesdixpac2017-07-141-2/+8
| |/ | | | | | | | | | | Revert `exist? and url` to the original implementation. Since the new one doesn't provide any benefits and makes implementation harder to follow.
| * Added rubocop / codeclimate config and fixed current offenses (#45)Cristian Bica2017-07-146-11/+11
| |
| * Remove few ivars from gcs_service implementationdixpac2017-07-131-8/+2
| |
| * Merge pull request #42 from quartzmo/gcs-site-urlGeorge Claghorn2017-07-121-2/+2
| |\ | | | | | | Update GCSService#url
| | * Update GCSService#urlChris Smith2017-07-121-2/+2
| | | | | | | | | | | | | | | Update google-cloud-storage dependency to 1.3 Refactor arguments to Google::Cloud::Storage::File#signed_url
| * | Revert "S3: slim down service implementation (#40)" (#41)David Heinemeier Hansson2017-07-121-24/+36
| |/ | | | | This reverts commit 6d3962461fb8d35fc9538d685fee96267663acf2.
| * S3: slim down service implementation (#40)Jeremy Daer2017-07-111-36/+24
| | | | | | | | | | | | | | * Use simple core API for duck-type compat with other clients * initialize: accept an existing client * initialize: accept arbitrary client args instead of a fixed, required set * download: use native get_object streaming, no need to implement range requests * exists?: use head_object (which returns immediately) rather than waiting for existence
| * Expose chunked downloadsGeorge Claghorn2017-07-102-6/+6
| |
* | Very incomplete first stabDavid Heinemeier Hansson2017-07-115-24/+112
|/
* Accept sgids for existing blobs created via direct upload as an attachableDavid Heinemeier Hansson2017-07-091-0/+4
|
* Direct uploads for S3David Heinemeier Hansson2017-07-097-2/+42
|
* Copypasta commentsDavid Heinemeier Hansson2017-07-091-3/+0
| | | | | | | | | | # Conflicts: # lib/active_storage/engine.rb # lib/active_storage/service.rb # lib/active_storage/service/disk_service.rb # lib/active_storage/service/s3_service.rb # test/service/s3_service_test.rb # test/test_helper.rb
* Instrument and log the servicesDavid Heinemeier Hansson2017-07-096-32/+168
|
* Merge pull request #27 from dixpac/fix_configuration_keys_symbolizationDavid Heinemeier Hansson2017-07-091-1/+1
|\ | | | | Symbolize all keys inside configuration nested hash
| * Symbolize all keys inside configuration nested hashdixpac2017-07-091-1/+1
| | | | | | | | | | Since configuration is a nested hash we need to symbolize all keys of the hash. Othervise fetcing will fail on start
* | Ensure binary encoding for downloadingDavid Heinemeier Hansson2017-07-091-1/+1
|/
* Use class methods scope now that we have multipleDavid Heinemeier Hansson2017-07-091-14/+16
|
* Clarify how a service can build other composed servicesJeremy Daer2017-07-093-34/+36
| | | | | | | | | * Service.build takes the literal YAML config hash for the service and a reference to the Configurator that's doing the building. * Services that compose additional services can use the Configurator to look them up and build them by name. See MirrorService for an example. References #23
* Service: clarify Service.build argumentsJeremy Daer2017-07-092-5/+5
| | | | | | | First arg is config for the service we're instantiating. Second arg is service configurations so we can look up and configure other services by name.
* Configure services that reference other servicesJeremy Daer2017-07-085-28/+69
| | | | | | | | * Move service configuration from the Engine to Service * Delegate configuration mechanics to internal Service::Configurator * Delegate service building to the concrete Service classes, allowing them to configure composed services. * Implement for the Mirror service.
* Mirror: explicit primary service and list of mirrorsJeremy Daer2017-07-081-10/+9
| | | | | | | | | | | | Pass separate primary service and list of mirrors rather than treating the first of the services list as the primary. Nice fit for keyword args, and something we've long wanted in the equivalent Basecamp file repository. Upload returns the results of the underlying service uploads rather than the io.rewind result. Rewind before uploading rather than afterward, and demonstrate that behavior with a test. Test that more than one mirror works.
* Merge pull request #21 from jeremy/disk-binary-ioDavid Heinemeier Hansson2017-07-091-8/+4
|\ | | | | Disk service: use binary IO throughout, not UTF-8
| * Disk service: use binary IO throughout, not UTF-8Jeremy Daer2017-07-081-8/+4
| |
* | Disk storage: ensure URLs end with the blob filename since some user agents ↵Jeremy Daer2017-07-083-5/+5
|/ | | | don't respect Content-Disposition filename
* Merge pull request #15 from robin850/documentationDavid Heinemeier Hansson2017-07-086-5/+100
|\ | | | | Add some documentation
| * Add some documentationRobin Dupret2017-07-076-5/+100
| |
* | Change type of created_at columns from time to datetimeGeorge Claghorn2017-07-071-8/+8
| | | | | | | | We intend to store a date and time, not merely a time.
* | It is an engine (because of tasks) not a railtieDavid Heinemeier Hansson2017-07-071-1/+1
|/
* Merge pull request #8 from robin850/fix-migrationsGeorge Claghorn2017-07-061-1/+1
|\ | | | | Fix the migration class name
| * Fix the migration class nameRobin Dupret2017-07-061-1/+1
| | | | | | | | | | | | Due to Active Support auto loading feature, the migration class shouldn't be name-spaced under the `ActiveStorage` constant, otherwise, running the migrations would throw an error.
* | Use safe navigationGeorge Claghorn2017-07-061-1/+1
| |
* | Remove unnecessary method delegationsGeorge Claghorn2017-07-061-1/+1
|/
* Fix testGeorge Claghorn2017-07-061-0/+2
| | | | | | | * S3 fails fast if the Content-MD5 header on an upload request is an invalid checksum. Send a valid but incorrect checksum. * Rescue the service-specific exception and raise the generic one.
* Merge branch 'master' into s3_integrityJohn Williams2017-07-061-2/+3
|\
| * StyleGeorge Claghorn2017-07-061-5/+3
| |
| * Adding server side integrity check for GCS ServiceStanislav Gospodinov2017-07-061-2/+5
| |
* | Send checksum to S3 to verify file integrityJohn Williams2017-07-061-2/+1
|/
* Fix hash usage consistency.Ra'Shaun Stovall2017-07-061-1/+1
| | | | | | | Unless this was intentional, being consistent with: https://github.com/rails/activestorage/blob/master/lib/active_storage/service/s3_service.rb#L8 Just showin' a lil' <3 while perusing the repo @dhh
* Check integrity after uploadsDavid Heinemeier Hansson2017-07-066-7/+19
|
* Dropped from the interfaceDavid Heinemeier Hansson2017-07-061-9/+0
|
* Need the byte helpersDavid Heinemeier Hansson2017-07-062-0/+2
|
* Compute checksum and byte_size client sideDavid Heinemeier Hansson2017-07-064-37/+15
| | | | | Then we can add integrity checks on uploads to prevent errors in transport.
* Remember to add streamingDavid Heinemeier Hansson2017-07-061-0/+1
|
* This is even more explaining and upload/download don't have some inherent ↵David Heinemeier Hansson2017-07-061-4/+2
| | | | need to synchronize chunk sizes anyway
* We have the technology!David Heinemeier Hansson2017-07-061-1/+1
|
* Convert magic number to constantDavid Heinemeier Hansson2017-07-061-2/+4
|
* Extract configuration into config/storage_configuration.ymlDavid Heinemeier Hansson2017-07-063-25/+56
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-13 09:10:18 +0000