| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| | |
Grammatical tense correction: "There exists two" => "There exist two".
Plurality correction: "can be reused inside others resources" => "can be reused inside other resources".
|
| |
| |
| |
| |
| |
| | |
In order to simplify profiling loading of initializers,
added instument for tracking load config initializer event from
`config/initializers`
|
| | |
|
|\ \
| | |
| | | |
[ci skip] Update gem versions for 3.2 and 3.1. Also change some words.
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Fix #10847: allow to pass a block to `cattr_reader`.
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Example:
class A
cattr_reader(:defr) { 'default_reader_value' }
end
A.defr # => 'default_reader_value'
|
|/ /
| |
| | |
[ci skip]
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
As of Rails 4.0 `remove_column` is no longer an alias for `remove_columns`.
The type is actually valid and used when issuing a rollback (new `change` method).
This reverts commit 9c9d4948e428a226a19aa92c17fa6ac5833c2fb8.
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Include URL helpers in TestController in bug report templates [ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | | |
[ci skip]
Fixes #12848.
|
|\ \ \
| |/ /
|/| | |
Update security.md [ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | | |
Hi Guys
I was reading through this guide last night and noticed a small mistake, would be great if you could update it.
I changed the word 'building' to 'build' in line 20.
"Web application frameworks are made to help developers building web applications"
|
| | |
| | |
| | |
| | |
| | | |
Product model name was pluralized in example in migrations guide.
[ci skip]
|
| | | |
|
|/ /
| |
| |
| |
| |
| | |
instead of 'rake test' as shortcut, use 'rake'.
Closes #12780 [ci skip]
|
| | |
|
| | |
|
|\ \
| |/
|/| |
Update workaround for "Outside the Scope of Strong Parameters"
|
| |
| |
| | |
Add .try to prevent undefined method error for NilClass.
|
| |
| |
| | |
The previous example of how to permit a hash of unknown keys used .tap, but had the side effect of logging an "Unpermitted parameters" message despite being a successful workaround. The proposed workaround is ever so slightly better, imo, because it won't result in an "Unpermitted parameters" message being logged.
|
|\ \ |
|
| | | |
|
| | | |
|
| | |
| | |
| | | |
see here 4d4ff531b8807ee88a3fc46875c7e76f613956fb
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
See rails/rails#12608
|
| | | |
|
| | |
| | |
| | | |
Code Highlighted
|
| | | |
|
| | |
| | |
| | | |
Code style adherence
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
So strings can be humanized without being capitalized:
'employee_salary'.humanize # => "Employee salary"
'employee_salary'.humanize(capitalize: false) # => "employee salary"
|
| | |
| | |
| | |
| | |
| | |
| | | |
I think it's confusing to say "Use them in views without escaping." We
use all keys in views without escaping - the escaping is done for us
automatically _unless_ we call html_safe or the key ends in _html.
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
[ci skip] Add actions to shallow table, change a tense in sentence, add
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Eagerload active_support/json/encoding in active_support/core_ext/object/to_json
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
TL;DR The primary driver is to remove autoload surprise.
This is related to #12106. (The root cause for that ticket is that
json/add defines Regexp#to_json among others, but here I'll reproduce
the problem without json/add.)
Before:
>> require 'active_support/core_ext/to_json'
=> true
>> //.as_json
NoMethodError: undefined method `as_json' for //:Regexp
from (irb):3
from /Users/godfrey/.rvm/rubies/ruby-2.0.0-p195/bin/irb:16:in `<main>'
>> //.to_json
=> "\"(?-mix:)\""
>> //.as_json
=> "(?-mix:)"
After:
>> require 'active_support/core_ext/to_json'
=> true
>> //.as_json
=> "(?-mix:)"
This is because ActiveSupport::JSON is autoloaded the first time
Object#to_json is called, which causes additional core extentions
(previously defined in active_support/json/encoding.rb) to be loaded.
When someone require 'active_support/core_ext', the expectation is
that it would add certain methods to the core classes NOW. The
previous behaviour causes additional methods to be loaded the first
time you call `to_json`, which could cause nasty surprises and other
unplesant side-effects.
This change moves all core extensions in to core_ext/json. AS::JSON is
still autoloaded on first #to_json call, but since it nolonger
include the core extensions, it should address the aforementioned bug.
*Requiring core_ext/object/to_json now causes a deprecation warnning*
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|