aboutsummaryrefslogtreecommitdiffstats
path: root/guides
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #32702 from bogdanvlviv/fix-description-for-31685Rafael França2018-04-251-2/+2
|\ | | | | Fix title for example of removing data from `session` [ci skip]
| * Fix title for example of removing data from `session` [ci skip]bogdanvlviv2018-04-231-2/+2
| | | | | | | | | | | | | | | | | | After #31685 the description says different what we expect to see in the example. Change `assign that key to be nil` to `or delete the key/value pair` in order to highlight what is shown in the example. Fix one more example of removing data from the session in favour of using `delete` since assigning to `nil` doesn't delete key from it.
* | Fix typo in migrations guide [ci skip]Daniel Colson2018-04-241-1/+1
| | | | | | | | Introduced in #32646
* | Merge pull request #32646 from derekprior/dp-schema-dumper-documentationSean Griffin2018-04-241-45/+35
|\ \ | | | | | | Update schema.rb documentation [CI SKIP]
| * | Update schema.rb documentation [CI SKIP]Derek Prior2018-04-241-45/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The documentation previously claimed that `db/schema.rb` was "the authoritative source for your database schema" while simultaneously also acknowledging that the file is generated. These two statements are incongruous and the guides accurately call out that many database constructs are unsupported by `schema.rb`. This change updates the comment at the top of `schema.rb` to remove the assertion that the file is authoritative. The documentation also previously referred vaguely to "issues" when re-running old migrations. This has been updated slightly to hint at the types of problems that one can encounter with old migrations. In sum, this change attempts to more accurately capture the pros, cons, and shortcomings of the two schema formats in the guides and in the comment at the top of `schema.rb`. [Derek Prior & Sean Griffin] Co-authored-by: Sean Griffin <sean@seantheprogrammer.com>
* | | Merge pull request #32471 from janko-m/use-image_processing-gemGeorge Claghorn2018-04-232-7/+18
|\ \ \ | |_|/ |/| | Use ImageProcessing gem for ActiveStorage variants
| * | Correct typosJanko Marohnić2018-04-231-2/+2
| | |
| * | Recommend using :resize_to_fit after allJanko Marohnić2018-04-231-2/+2
| | |
| * | Replace :resize_to_fit with :resize in the guideJanko Marohnić2018-04-231-1/+1
| | |
| * | Rename ActiveStorage.processor to .variant_processorJanko Marohnić2018-04-222-2/+2
| | |
| * | Use ImageProcessing gem for ActiveStorage variantsJanko Marohnić2018-04-182-6/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ImageProcessing gem is a wrapper around MiniMagick and ruby-vips, and implements an interface for common image resizing and processing. This is the canonical image processing gem recommended in [Shrine], and that's where it developed from. The initial implementation was extracted from Refile, which also implements on-the-fly transformations. Some features that ImageProcessing gem adds on top of MiniMagick: * resizing macros - #resize_to_limit - #resize_to_fit - #resize_to_fill - #resize_and_pad * automatic orientation * automatic thumbnail sharpening * avoids the complex and inefficient MiniMagick::Image class * will use "magick" instead of "convert" on ImageMagick 7 However, the biggest feature of the ImageProcessing gem is that it has an alternative implementation that uses libvips. Libvips is an alternative to ImageMagick that can process images very rapidly (we've seen up 10x faster than ImageMagick). What's great is that the ImageProcessing gem provides the same interface for both implementations. The macros are named the same, and the libvips implementation does auto orientation and thumbnail sharpening as well; only the operations/options specific to ImageMagick/libvips differ. The integration provided by this PR should work for both implementations. The plan is to introduce the ImageProcessing backend in Rails 6.0 as the default backend and deprecate the MiniMagick backend, then in Rails 6.1 remove the MiniMagick backend.
* | | Remove key from session by using session.delete (#31685)Rafael Barbolo2018-04-231-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove key from session by using session.delete You are not deleting a key from session when you assign nil to that key. * Update guides on how to destroy a user session In this commit, the user id is removed from session and controller's variables related to the user are nullified. [Rafael Mendonça França + Rafael Barbolo]
* | | Merge pull request #32689 from yhirano55/update-testing-guidesGuillermo Iguaran2018-04-221-13/+14
|\ \ \ | | | | | | | | Update results of command in Testing guides [ci skip]
| * | | Update results of command in Testing guides [ci skip]Yoshiyuki Hirano2018-04-231-13/+14
| | | | | | | | | | | | | | | | | | | | * Results of command in testing guides are different from actual ones. * Updated them.
* | | | Refactor guides javascriptsYoshiyuki Hirano2018-04-232-26/+34
| | | | | | | | | | | | | | | | | | | | * Remove `$` prefix from all variables (`$` prefix means jQuery object) * Old browsers doesn't support forEach. So use for instead of forEach.
* | | | :scissors: jQuery for Rails GuidesYoshiyuki Hirano2018-04-215-95/+88
|/ / / | | | | | | | | | | | | * Rewrite with Vanilla JS * Confirmed with Chrome, Safari, Firefox
* | | Merge pull request #32572 from nao0515ki/add_optional_true_to_self_joins_sectionRafael França2018-04-201-1/+1
|\ \ \ | | | | | | | | [ci skip] belongs_to in self join association needs optional: true, if it's over 5.0 ver of rails
| * | | [ci skip] belongs_to in self join association needs optional: true, if it's ↵nao0515ki2018-04-141-1/+1
| |/ / | | | | | | | | | over 5.0 ver of rails
* | | Merge pull request #32575 from ybakos/guides/testing/pluralize_class_namesRafael França2018-04-191-3/+3
|\ \ \ | | | | | | | | guides/testing: Pluralize controller and helper class names.
| * | | guides/testing: Pluralize controller and helper class names.Yong Bakos2018-04-141-3/+3
| |/ / | | | | | | | | | | | | | | | The Rails convention for controllers and helpers is plural, except where intentionally singular. Pluralize the controller and helper class names, to match convention.
* | | Merge pull request #32574 from DmytroVasin/rails-ujs-stoppable-eventsRafael França2018-04-191-4/+6
|\ \ \ | | | | | | | | Rails-ujs: Info about stoppable events
| * | | Fix stoppable events in tests and docs.Dmytro Vasin2018-04-141-4/+6
| |/ /
* | | Merge pull request #32401 from yhirano55/improve_css_in_guideRafael França2018-04-192-12/+2
|\ \ \ | |_|/ |/| | Improve css in guide
| * | Improve css in guideYoshiyuki Hirano2018-04-012-12/+2
| | | | | | | | | | | | | | | | | | | | | | | | * .clearfix is overridden. * .clear is not currently used. * #extraCol is not currently used. * table th, table td are overridden. Merged them. * Removed needless comment lines which are added on #6475
* | | [ci skip] Fix minor system testing documentation typo.Stephen2018-04-181-1/+1
| | |
* | | Merge pull request #32607 from yaroslav/feature/nonce-for-javascript_include_tagAndrew White2018-04-181-0/+6
|\ \ \ | | | | | | | | Add the `nonce: true` option for `javascript_include_tag` helper.
| * | | Add the `nonce: true` option for `javascript_include_tag` helper.Yaroslav Markin2018-04-171-0/+6
| | | |
* | | | Correct docs on naming of sprockets manifest filePaul2018-04-171-2/+2
|/ / / | | | | | | | | | Calling this an MD5 implies that it is generated consistently based on some input. However, this value is [completely random](https://github.com/rails/sprockets/blob/fbe6e450b6f25cf3ea494fcab0e34001d0b5a0b9/lib/sprockets/manifest_utils.rb#L11-L24).
* | | Merge pull request #32582 from cassidycodes/better-examplesRafael França2018-04-162-11/+11
|\ \ \ | | | | | | | | Inclusive Language in Documentation Examples
| * | | Use string-based fields. [ci skip]Cassidy Kobewka2018-04-161-4/+4
| | | |
| * | | Inclusive Language in Documentation Examples [ci skip]Cassidy Kobewka2018-04-152-11/+11
| | |/ | |/|
* | | Merge pull request #32596 from bogdanvlviv/add-reference-to-5_2-from-edge-guidesRyuta Kamizono2018-04-171-0/+1
|\ \ \ | | | | | | | | Add the reference to Rails Guides 5.2 from the Edge Guides
| * | | Add the reference to Rails Guides 5.2 from the Edge Guidesbogdanvlviv2018-04-171-0/+1
| |/ / | | | | | | | | | [ci skip]
* / / Update Rails minor version from 5.1 to 5.2 [ci skip]Jolyon Pawlyn2018-04-161-1/+1
|/ /
* | Update security.md with latest underground market pricesszTheory2018-04-131-1/+1
| | | | | | Updated underground market prices according to the 2017 Symantec ISTR (was previously citing the 2008 report)
* | Fix MySpace Samy worm link [ci skip]284km2018-04-121-1/+1
| | | | | | | | The old link https://samy.pl/popular/tech.html is 404 not found.
* | Remove link for the kindle version of guides on edgeRafael Mendonça França2018-04-111-1/+3
| | | | | | | | | | | | See https://github.com/rails/rails-docs-server/pull/8 for reason. [ci skip]
* | Specify which series I'm talking aboutRafael Mendonça França2018-04-101-1/+1
| | | | | | | | [ci skip]
* | Update our security policy to include all releases in the current seriesRafael Mendonça França2018-04-101-2/+2
| | | | | | | | | | | | | | | | | | | | | | We don't want people to jump from the last release in the previous series (4.2) straing to the first release in the current series that is support (5.1), so we should be supporting the entire series for severe security issues. This will not be a problem because usually we only have 3 releases in a series and backporting patches inside the same series is not harder than backporting to a previous series.
* | 4.2 is still maintainedRafael Mendonça França2018-04-101-1/+1
| | | | | | | | It is the last major release series.
* | Merge pull request #32508 from radar/radar/maintenance-policyRyuta Kamizono2018-04-101-3/+3
|\ \ | | | | | | | | | | | | Correct Maintenance Policy for Rails 5.2 [ci skip]
| * | Correct Maintenance Policy for Rails 5.2Ryan Bigg2018-04-101-3/+3
| | |
* | | Update bug report templatesbogdanvlviv2018-04-105-5/+5
|/ / | | | | | | Set Rails 5.2.0 in templates
* | [ci skip] Add securing rails app guide link to credential sectionYoshiyuki Hirano2018-04-071-0/+3
| | | | | | | | * In 5.2 release note, added [securing rails app guide](http://edgeguides.rubyonrails.org/security.html#custom-credentials) link to [credentials section](http://edgeguides.rubyonrails.org/5_2_release_notes.html#credentials).
* | [ci skip] Add :private option to delegate section in guideYoshiyuki Hirano2018-04-041-0/+8
| |
* | removes obsolete images in guides [ci skip]Xavier Noria2018-04-032-0/+0
| | | | | | | | Note that tab_yellow.gif exists, that is the one being used.
* | remove obsolete author imagesXavier Noria2018-04-036-0/+0
| | | | | | | | The credits page is gone after #32429, these images are now orphan.
* | Cleanup credits related code as it is removed now in PR #32429Prathamesh Sonpatki2018-04-032-10/+1
| |
* | Remove credits.html from Rails GuidesYoshiyuki Hirano2018-04-036-89/+1
| | | | | | | | * refs #32420
* | Add `action_view.finalize_compiled_template_methods` config optionSimon Coffey2018-04-021-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActionView::Template instances compile their source to methods on the ActionView::CompiledTemplates module. To prevent leaks in development mode, where templates can frequently change, a finalizer is added that undefines these methods[1] when the templates are garbage-collected. This is undesirable in the test environment, however, as templates don't change during the life of the test. Moreover, the cost of undefining a method is proportional to the number of descendants a class or module has, since the method cache must be cleared for all descendant classes. As ActionView::CompiledTemplates is mixed into every ActionView::TestCase (or in RSpec suites, every view spec example group), it can end up with a very large number of descendants, and undefining its methods can become very expensive. In large test suites, this results in a long delay at the end of the test suite as all template finalizers are run, only for the process to then exit. To avoid this unnecessary cost, this change adds a config option, `action_view.finalize_compiled_template_methods`, defaulting to true, and sets it to false in the test environment only. [1] https://github.com/rails/rails/blob/09b2348f7fc8d4e7191e70e06608c5909067e2aa/actionview/lib/action_view/template.rb#L118-L126
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 18:03:02 +0000