aboutsummaryrefslogtreecommitdiffstats
path: root/guides
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #35093 from rails/av-base-constructorAaron Patterson2019-01-301-2/+2
|\ | | | | Tighten up the AV::Base constructor
| * Tighten up the AV::Base constructorAaron Patterson2019-01-291-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The AV::Base constructor was too complicated, and this commit tightens up the parameters it will take. At runtime, AV::Base is most commonly constructed here: https://github.com/rails/rails/blob/94d54fa4ab641a0ddeb173409cb41cc5becc02a9/actionview/lib/action_view/rendering.rb#L72-L74 This provides an AV::Renderer instance, a hash of assignments, and a controller instance. Since this is the common case for construction, we should remove logic from the constructor that handles other cases. This commit introduces special constructors for those other cases. Interestingly, most code paths that construct AV::Base "strangely" are tests.
* | Add ActionCable channel/connection load hooksVladimir Dementyev2019-01-291-0/+2
|/
* Fix a tiny typo [ci skip]Robin Dupret2019-01-261-1/+1
| | | | Follow-up to #35055.
* document the possibility of app initializers running before gem initilizersbughit2019-01-251-0/+2
| | | and suggest a workaround
* Fix typo in ActionCable::Connection::TestCase referenceRicardo Diaz2019-01-241-1/+1
|
* Merge pull request #35021 from palkan/refactor/broadcasting-for-testingKasper Timm Hansen2019-01-241-2/+29
|\ | | | | Action Cable: move channel_name to Channel.broadcasting_for
| * fix fixture syntax in cable docs and guidesVladimir Dementyev2019-01-221-3/+3
| |
| * Move `channel_name` to Channel.broadcasting_forVladimir Dementyev2019-01-221-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | That would allow us to test broadcasting made with channel, e.g.: ```ruby class ChatRelayJob < ApplicationJob def perform_later(room, msg) ChatChannel.broadcast_to room, message: msg end end ``` To test this functionality we need to know the underlying stream name (to use `assert_broadcasts`), which relies on `channel_name`. We had to use the following code: ```ruby assert_broadcasts(ChatChannel.broadcasting_for([ChatChannel.channel_name, room]), 1) do ChatRelayJob.perform_now end ``` The problem with this approach is that we use _internal_ API (we shouldn't care about `channel_name` prefix in our code). With this commit we could re-write the test as following: ```ruby assert_broadcasts(ChatChannel.broadcasting_for(room), 1) do ChatRelayJob.perform_now end ```
* | Prefer ImageProcessing's resize_to_limit macro over resize_to_fitGeorge Claghorn2019-01-241-1/+1
| | | | | | | | Don't upsize images smaller than the specified dimensions.
* | Corrected spelling of ActionCable::Connection::TestCaseAlan Brown2019-01-221-1/+1
|/
* Merge pull request #34997 from alkesh26/typo-fix-webserverEileen M. Uchitelle2019-01-222-3/+3
|\ | | | | Replaced webserver with web server
| * Changed webserver to web server.alkesh262019-01-222-3/+3
| |
* | Add missing entries to guides' changelog file [ci skip]bogdanvlviv2019-01-211-0/+8
|/ | | | | | | We added "Action Mailbox Basics", "Action Text Overview" guides(#34812, #34878) I think it makes to mention about it in the changelog file. (Similar to 7200ec92f8) Note that entries retain original author since I just moved content from readme files to the guides.
* Merge pull request #34988 from bogdanvlviv/fix-development_dependencies_installRyuta Kamizono2019-01-201-1/+0
|\ | | | | Update "Development Dependencies Install" guide [ci skip]
| * Fix "Development Dependencies Install" guide [ci skip]bogdanvlviv2019-01-191-1/+0
| | | | | | | | | | Since we use [workspaces](https://yarnpkg.com/lang/en/docs/workspaces/) `yarn install` from the root should install all the javascript dependencies.
* | Preparing for 6.0.0.beta1 releaseRafael Mendonça França2019-01-181-0/+2
|/
* Change `SQLite3Adapter` to always represent boolean values as integersRafael Mendonça França2019-01-171-23/+0
|
* Merge pull request #34213 from matildasmeds/guides_session_guidelines_2Rafael França2019-01-171-68/+31
|\ | | | | Edit Security Guide's Session Guidelines & Custom Credentials [skip ci]
| * Merge branch 'master' into guides_session_guidelines_2Matilda Smeds2018-12-0946-584/+1279
| |\
| * | Update guides/source/security.mdDerek Prior2018-10-181-1/+1
| | |
| * | Update guides/source/security.mdDerek Prior2018-10-181-1/+1
| | |
| * | Edit Security Guide's Session Guidelines & Custom Credentials [skip ci]Matilda Smeds2018-10-141-68/+31
| | | | | | | | | | | | | | | | | | | | | * Edit Session Guidelines to achieve tighter prose and accuracy * Remove mentions related to earlier Rails versions * Add links to ActionController guide and Custom Credentials part * Clarify Custom Credentials part
* | | Minimize boilerplate setup code for JavaScript librariesJavan Makhmali2019-01-162-4/+3
| | |
* | | Merge pull request #34947 from bogdanvlviv/actioncable-testing-34933Kasper Timm Hansen2019-01-161-6/+4
|\ \ \ | | | | | | | | Add `rails test:channels` and fix Action Cable templates
| * | | Remove `frozen_string_literal` from Action Cable's template filesbogdanvlviv2019-01-161-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | Related to 837f602fa1b3281113dac965a8ef96de3cac8b02 Fix the testing guide.
* | | | Remove Decorator pattern in Overriding existing classes examplesMaurizio De Santis2019-01-161-11/+10
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Engines guide in the Overriding Models and Controllers section references the Decorator pattern, which isn't appropriate, since Decorator pattern is not about reopening existing classes, is about adding functionality to existing object instances; something that in Ruby is commonly implemented using Delegators. Moreover, the suggested naming convention for overrides, `app/decorators/**/*_decorator*.rb`, conflicts with a naming convention commonly used for View Model / Presentation Model decorators, adopted by popular gems such as `draper`, as well as by custom implementations.
* | | Refs #28025 nullify *_type column on polymorphic associations on :nu… ↵Laerti2019-01-151-2/+2
| | | | | | | | | | | | | | | | | | (#28078) This PR addresses the issue described in #28025. On `dependent: :nullify` strategy only the foreign key of the relation is nullified. However on polymorphic associations the `*_type` column is not nullified leaving the record with a NULL `*_id` but the `*_type` column is present.
* | | Document the ActionCable JS changes in the upgrade guide & release notesRichard Macklin2019-01-142-0/+52
| | |
* | | Add Action Cable Testing guidesVladimir Dementyev2019-01-143-3/+124
| | |
* | | Merge pull request #34932 from ↵Ryuta Kamizono2019-01-141-8/+8
|\ \ \ | | | | | | | | | | | | | | | | bogdanvlviv/fix-action-cable-guide-follow-up-34709 Fix "Action Cable Overview" guide [ci skip]
| * | | Fix "Action Cable Overview" guide [ci skip]bogdanvlviv2019-01-131-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix path to channel files. `rails generate channel Chat` generates `app/javascript/channels/chat_channel.js`. See also, railties/lib/rails/generators/rails/app/templates/app/javascript/packs/application.js.tt, actioncable/lib/rails/generators/channel/templates/javascript/index.js.tt by default `application.js` imports "channels", where `app/javascript/channels/index.js` loads all the channels within this directory and all subdirectories. Follow up #34709 Related to #33079
* | | | Merge `actioncable/README.md` to the Action Cable Overview guide [ci skip]bogdanvlviv2019-01-131-0/+30
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In #34709 we updated the guide, but `actioncable/README.md` is still outdated. Instead of fixing content in the file. I suggest not duplicate the info that is already in the guide and instead remove the info from the file and just add a message: "You can read more about Action Cable in the [Action Cable Overview](https://edgeguides.rubyonrails.org/action_cable_overview.html) guide." The same approach is being used for Action Mailbox and Action Text, see #34812 and #34878.
* | | Add Exim and Qmail support to Action MailboxGeorge Claghorn2019-01-121-6/+66
| | |
* | | Merge pull request #34902 from ↵Gannon McGibbon2019-01-111-1/+1
|\ \ \ | | | | | | | | | | | | | | | | lanzhiheng/improve-doc-in-routing-2-10-adding-member-routes improve doc in `Adding Member Routes` section of routing chapter.
| * | | [ci skip] improve doc in `Adding Member Routes` section of routing chapter.lanzhiheng2019-01-111-1/+1
| | | |
* | | | Merge pull request #34913 from ↵Gannon McGibbon2019-01-111-0/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | bogdanvlviv/docs_config_action_mailer_delivery_job Add info about `config.action_mailer.delivery_job` to the guide [ci skip]
| * | | | Add info about `config.action_mailer.delivery_job` to the guide [ci skip]bogdanvlviv2019-01-111-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also, add mention to `new_framework_defaults_6_0.rb` that `ActionMailer::Parameterized::DeliveryJob` is default for parameterized mail and will be removed. Related to #34692
* | | | | Add reasoning for `I18n.with_locale` and explanation that the problem isDusan Orlovic2019-01-101-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | about leak into subsequent requests. [ci skip]
* | | | | Merge pull request #34905 from javan/move-npm-packages-to-rails-scopeJavan Makhmali2019-01-102-4/+4
|\ \ \ \ \ | | | | | | | | | | | | Move all npm packages to @rails scope
| * | | | | Move all npm packages to @rails scopeJavan Makhmali2019-01-102-4/+4
| |/ / / / | | | | | | | | | | | | | | | Fixes #33083
* / / / / Add Postmark to the ingress lists [ci skip]George Claghorn2019-01-101-2/+2
|/ / / /
* | | | Merge pull request #34909 from davidalee/patch-2Prem Sichanugrist2019-01-101-3/+3
|\ \ \ \ | | | | | | | | | | Specify the type for the auto-generated primary key
| * | | | Specify the type for the auto-generated primary keyDavid A. Lee2019-01-091-3/+3
| | | | | | | | | | | | | | | Given the change to using `bigint` as type for auto-generated primary keys (as per https://github.com/rails/rails/pull/26266), I propose updating the Active Record Basics guide to explicitly state the type being used so as to avoid confusion as to the type of integer used, especially as the type can vary depending on the database used.
* | | | | Added Postmark ingress supportTomek Maszkowski2019-01-091-0/+36
|/ / / /
* | | | Enable `Lint/UselessAssignment` cop to avoid unused variable warnings (#34904)Ryuta Kamizono2019-01-091-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Enable `Lint/UselessAssignment` cop to avoid unused variable warnings Since we've addressed the warning "assigned but unused variable" frequently. 370537de05092aeea552146b42042833212a1acc 3040446cece8e7a6d9e29219e636e13f180a1e03 5ed618e192e9788094bd92c51255dda1c4fd0eae 76ebafe594fc23abc3764acc7a3758ca473799e5 And also, I've found the unused args in c1b14ad which raises no warnings by the cop, it shows the value of the cop.
* | | | Add OG tags to layout.html.erbtoshimaru2019-01-093-4/+18
|/ / /
* | | Revert "Revert "Merge pull request #34387 from ↵Kasper Timm Hansen2019-01-081-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | yhirano55/rails_info_properties_json"" I reverted the wrong commit. Damn it. This reverts commit f66a977fc7ae30d2a07124ad91924c4ee638a703.
* | | Revert "Merge pull request #34387 from yhirano55/rails_info_properties_json"Kasper Timm Hansen2019-01-081-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We had a discussion on the Core team and we don't want to expose this information as a JSON endpoint and not by default. It doesn't make sense to expose this JSON locally and this controller is only accessible in dev, so the proposed access from a production app seems off. This reverts commit 8eaffe7e89719ac62ff29c2e4208cfbeb1cd1c38, reversing changes made to b6e4305c3bca4c673996d0af9db0f4cfbf50215e.
* | | Add load hook for ActionText::RichTextGeorge Claghorn2019-01-071-0/+1
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-18 11:51:06 +0000