aboutsummaryrefslogtreecommitdiffstats
path: root/guides
Commit message (Collapse)AuthorAgeFilesLines
* Refer to rails command instead of rake in a bunch of placesDavid Heinemeier Hansson2015-12-188-26/+26
| | | | Still more to do. Please assist!
* Fix section about ApplicationRecord in upgrading guide [ci skip]Prathamesh Sonpatki2015-12-171-4/+4
|
* ApplicationRecord release notes entryGenadi Samokovarov2015-12-171-0/+19
| | | | [ci skip]
* ApplicationRecord documentation passGenadi Samokovarov2015-12-1713-162/+163
| | | | | | | This is a pass over the documentation which fills the missing gaps of `ApplicationRecord`. [ci skip]
* Fix documentation about ApplicationRecordRafael Mendonça França2015-12-161-1/+1
| | | | [ci skip]
* Merge pull request #22506 from derekprior/dp-redirect_to_back_or_defaultSean Griffin2015-12-162-3/+6
|\ | | | | Add `redirect_to_back_or_default`
| * Deprecate `redirect_to :back`Derek Prior2015-12-161-9/+4
| | | | | | | | | | | | | | Applications that use `redirect_to :back` can be forced to 500 by clients that do not send the HTTP `Referer` (sic) header. `redirect_back` requires the user to consider this possibility up front and avoids this trivially-caused application error.
| * Add `redirect_back` for safer referrer redirectsDerek Prior2015-12-162-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `redirect_to :back` is a somewhat common pattern in Rails apps, but it is not completely safe. There are a number of circumstances where HTTP referrer information is not available on the request. This happens often with bot traffic and occasionally to user traffic depending on browser security settings. When there is no referrer available on the request, `redirect_to :back` will raise `ActionController::RedirectBackError`, usually resulting in an application error. `redirect_back` takes a required `fallback_location` keyword argument that specifies the redirect when the referrer information is not available. This prevents 500 errors caused by `ActionController::RedirectBackError`.
* | Merge pull request #22567 from gsamokovarov/introduce-application-recordRafael França2015-12-167-132/+148
|\ \ | |/ |/| Introduce ApplicationRecord, an Active Record layer supertype
| * Introduce ApplicationRecord, an Active Record layer supertypeGenadi Samokovarov2015-12-167-132/+148
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's pretty common for folks to monkey patch `ActiveRecord::Base` to work around an issue or introduce extra functionality. Instead of shoving even more stuff in `ActiveRecord::Base`, `ApplicationRecord` can hold all those custom work the apps may need. Now, we don't wanna encourage all of the application models to inherit from `ActiveRecord::Base`, but we can encourage all the models that do, to inherit from `ApplicationRecord`. Newly generated applications have `app/models/application_record.rb` present by default. The model generators are smart enough to recognize that newly generated models have to inherit from `ApplicationRecord`, but only if it's present.
* | Merge pull request #22611 from existent-co-uk/patch-1Rafael França2015-12-161-2/+2
|\ \ | | | | | | Fix a couple of grammatical errors in security.md
| * | Fix a couple of grammatical errors in security.mdExistent Ltd2015-12-161-2/+2
| |/
* / Mention the correct way to halt callback chainsCarlos Souza2015-12-161-1/+1
|/ | | | | The previous title was misleading. [ci skip]
* Use a real migration version number in docsMatthew Draper2015-12-154-35/+35
| | | | | Even though this means more things to change when we bump after a release, it's more important that our examples are directly copyable.
* Use a deliberately-invalid migration version in all doc examplesMatthew Draper2015-12-154-35/+35
| | | | | | | | | | If we use a real version, at best that'll be an onerous update required for each release; at worst, it will encourage users to write new migrations against an older version than they're using. The other option would be to leave these bare, without any version specifier. But as that's just a variant spelling of "4.2", it would seem to raise the same concerns as above.
* Merge branch 'rails-rake-proxy'Kasper Timm Hansen2015-12-131-5/+7
|\
| * Implement Rake proxy for Rails' command line interface.Dharam Gollapudi2015-12-131-5/+7
|/ | | | | | | Allows any Rake task to be run through `bin/rails` such as `bin/rails db:migrate`, `bin/rails notes` etc. The Rake tasks are appended to Rails' help output, and blend in as standard commands.
* Merge pull request #22572 from prathamesh-sonpatki/fix-paintit-method-in-guidesArthur Nogueira Neves2015-12-131-2/+2
|\ | | | | Fix paintIt method in JavaScript guides [ci skip]
| * Fix paintIt method in JavaScript guides [ci skip]Prathamesh Sonpatki2015-12-131-2/+2
| | | | | | | | | | | | - Changed "paintIt" to "@paintIt" so that it can be called in an on click handler. - Closes #22568
* | let config.file_watcher be the way to enable the evented file watcherXavier Noria2015-12-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | Before this commit, the sole presence of the Listen constant enabled the evented file watcher (unless listen resorted to the polling backend). This way, applications may depend on listen for other stuff independently of this feature. Also, allows teams with mixed setups to decide at boot time whether the evented watcher should be enabled for each particular instance.
* | [ci skip] Fix articles spelling.Kasper Timm Hansen2015-12-131-1/+1
| | | | | | Tiny typo in the testing guide; articules should be articles.
* | Remove ActionController::TestCase from documentationeileencodes2015-12-123-34/+34
|/ | | | | | | | | | | | | | | | | | In Rails 5.1 `ActionController::TestCase` will be moved out of Rails into it's own gem. Please use `ActionDispatch::IntegrationTest` going foward. Because this will be moved to a gem I used `# :stopdoc:` instead of deleting the documentation. This will remove it from the Rails documentation but still leave the method documented for when we move it to a gem. Guides have been updated to use the routing structure used in Integration and all test examples have been updated to inherit from `ActionDispatch::IntegrationTest` instead of `ActionController::TestCase. Fixes #22496
* Merge pull request #22554 from y-yagi/fix_link_to_cocRafael França2015-12-111-1/+1
|\ | | | | fix links to code of conduct [ci skip]
| * fix links to code of conduct [ci skip]yuuji.yaginuma2015-12-111-1/+1
| | | | | | | | CoC text has been moved to the Rails website in 90bcb6d
* | Merge pull request #22367 from andreynering/docs-ar-enumsYves Senn2015-12-101-0/+30
|\ \ | |/ |/| | | Adding Enums section to AR Querying. [ci skip]
| * Adding Enums section to Active Record Querying Guide. [ci skip]Andrey Nering2015-12-081-0/+25
| |
* | Mention the debug_exception_response_format config in guidesJorge Bejar2015-12-091-0/+8
|/
* Introduce after_{create,update,delete}_commit callbacksGenadi Samokovarov2015-12-061-0/+19
| | | | | | | | | | | | | | | | Those are actually shortcuts for `after_commit`. Before: after_commit :add_to_index_later, on: :create after_commit :update_in_index_later, on: :update after_commit :remove_from_index_later, on: :destroy After: after_create_commit :add_to_index_later after_update_commit :update_in_index_later after_destroy_commit :remove_from_index_later
* Update autoloading_and_reloading_constants.mdpavlos2015-12-011-1/+1
| | | Fixed a typo
* Merge pull request #22343 from jeffminnear/patch-1Claudio B2015-12-011-2/+9
|\ | | | | Modify unscoped usage guide to include chaining [ci skip]
| * Modify unscoped usage guide to include chainingJeff Minnear2015-11-301-2/+9
| |
* | Merge pull request #22427 from eliotsykes/validation-message-proc-docYves Senn2015-11-301-1/+30
|\ \ | | | | | | | | | Document message validation option accepts Proc [ci skip]
| * | Document message validation option accepts ProcEliot Sykes2015-11-271-1/+30
| | |
* | | Merge pull request #22283 from the-undefined/routes-error-singular-resourceArthur Nogueira Neves2015-11-281-2/+2
|\ \ \ | | | | | | | | [ci skip] add `controller:` argument to routing.md
| * | | [ci skip] add `controller:` argument to routing.mdthe-undefined2015-11-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Passing a `Symbol` to the `to:` argument for a `get` route requires a `controller` argument to also be defined. The documentation is missing the `controller:` argument, which leaving out raises a routing exception: ```ruby get 'profile', to: :show ``` ``` $ rake routes ArgumentError: Missing :controller key on routes definition, please check your routes. ``` Adding the `controller:` argument maps the route correctly: ```ruby get 'profile', to: :show, controller: 'users' ``` ``` $ rake routes profile GET /profile(.:format) users#show ```
* | | | Merge pull request #22315 from takatoshiono/fix-configuring-docArthur Nogueira Neves2015-11-281-2/+2
|\ \ \ \ | |_|/ / |/| | | Fix set_autoload_paths and set_load_path document [ci skip]
| * | | Fix set_autoload_paths and set_load_path documentTakatoshi Ono2015-11-171-2/+2
| | | |
* | | | Merge pull request #22263 from mastahyeti/csrf-origin-checkRafael França2015-11-261-0/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Add option to verify Origin header in CSRF checks [Jeremy Daer + Rafael Mendonça França]
| * | | | Add option to verify Origin header in CSRF checksBen Toews2015-11-251-0/+2
| | | | |
* | | | | Remove valgrind note about linux only supportJacob Bednarz2015-11-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update the valgrind debugging documentation to remove the notes about being linux only as 3.11.0[1] introduces preliminary support for Mac OSX 10.11 (El Capitan). [1]: http://valgrind.org/docs/manual/dist.news.html
* | | | | Merge pull request #22374 from DNNX/patch-1Rafael França2015-11-231-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Simplify `RailsGuides::Generator#select_only` a bit
| * | | | | Simplify `RailsGuides::Generator#select_only` a bitViktar Basharymau2015-11-221-1/+1
| | |_|_|/ | |/| | | | | | | | The main goal is to improve readability, but as a side effect this commit makes the method a bit faster.
* / | | | [ci skip] Add `Translating Rails Guides` to contributing_to_ruby_on_railsyui-knk2015-11-231-0/+36
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | Docrails is private now (6cb1b6724c313c608cf4063fc22886faa19df9be), anyone who does not have access right to docrails can't read "Translating Rails Guides" in wiki of docrails. To prevent someone from giving up to translate, publish them on Rails Guide.
* | | | Merge pull request #22340 from rbr/change-configuration-exampleYves Senn2015-11-191-1/+1
|\ \ \ \ | | | | | | | | | | Change configuration-guide example [ci skip]
| * | | | Change configuration-guide examplerbr2015-11-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use an example from a default Rails app (4.2.5) rather than an outdated one in the Configuring Rails Components section. I picked config.time_zone as it currently is the only 'setting for Rails' left in a default config/application.rb. I stumbled upon this with investigating autoloading in a legacy app, which still included the example comment "# config.autoload_paths += %W(#{config.root}/extras)". Usually adding app/* directories to autoload_paths isn't necessary, so also finding this example within the current docs was a bit confusing initially. [ci skip]
* | | | | Fix a typoAlex Popov2015-11-191-1/+1
|/ / / /
* | | | guides, scaffold no longer used in getting started guide. Closes #22337.Yves Senn2015-11-191-6/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] Since the "Getting Started" guide no longer uses the scaffold generator we should rewrite references to that in the testing guide. The functional testing section was quite heavily based on such a scaffold test. I changed it to use `generate scaffold_controller` instead so that we can build up on the model foundation we already have.
* | | | [ci skip] Indentation in cache exampleszacharywelch2015-11-181-2/+2
| | | |
* | | | Revert "Fixed a few grammar issues."Rafael Mendonça França2015-11-182-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 16ce41b7f4449d6df15df30d69aef18da6510f36. Reason: See https://github.com/rails/rails/commit/16ce41b7f4449d6df15df30d69aef18da6510f36#commitcomment-14475125
* | | | Fixed a few grammar issues.David Chen2015-11-182-2/+2
| | | |