aboutsummaryrefslogtreecommitdiffstats
path: root/guides
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #33047 from artfuldodger/patch-3Eileen M. Uchitelle2018-06-041-1/+1
|\ | | | | Fix testing guide typo
| * Fix testing guide typoJon Evans2018-06-011-1/+1
| |
* | Correct default value of `unknown_asset_fallback`James Adam2018-06-041-1/+1
|/ | | | | `Rails.application.config.assets.unknown_asset_fallback` now defaults to `false` in an unmodified Rails application. [ci skip]
* Merge pull request #33039 from ↵Prem Sichanugrist2018-06-021-1/+1
|\ | | | | | | | | ybakos/guides/layouts_and_rendering_class_spelling_fix Capitalize class name 'Product' in layouts and rendering guide.
| * Capitalize class name 'Product'.Yong Bakos2018-06-011-1/+1
| | | | | | | | | | In this context, the phrase 'product instance' refers to the Product class, so capitalize it.
* | Remove 'Current.' prefix from example.Yong Bakos2018-06-011-2/+2
|/ | | | | The prior sentence is referring just to an existing user object, so the sudden magical 'Current.' prefix doesn't make sense. Remove it.
* add CHANGELOG/Docutilum2018-05-221-7/+12
|
* [ci skip] Add documentation/changelog entry.Kasper Timm Hansen2018-05-211-0/+15
|
* Fix markdown [ci skip]Rafael Mendonça França2018-05-171-1/+1
|
* Demonstrate ActiveStorage::Blob#open in the Active Storage guideGeorge Claghorn2018-05-161-42/+9
|
* Added a lot of Oxford commasAnthony Crumley2018-05-1034-115/+115
| | | | | | | [ci skip] A regular expression was used to find a lot of missing Oxford commas and add them. The regular expression was as follows. ", ([a-zA-Z0-9.\`:'\"]+ ){1,6}(or|and) "
* [ci skip] fix typo in active_support_instrumentation.md guideAssain2018-05-101-1/+1
|
* Merge pull request #32833 from ryandav/activestorage_blob_set_content_typeGeorge Claghorn2018-05-081-0/+12
|\ | | | | Add option to ActiveStorage::Blob to set extract_content_type_from_io
| * Add option to ActiveStorage::Blob to set extract_content_type_from_ioRyan Davidson2018-05-081-0/+12
| | | | | | | | | | | | | | This adds a boolean argument called identify to ActiveStorage::Blob methods #create_after_upload, #build_after_upload and #upload. It allows a user to bypass the automatic content_type inference from the io.
* | Fix named route parameter example [ci skip]yuuji.yaginuma2018-05-081-5/+5
| | | | | | | | The prefix of `new` and `edit` generated by `resources` is singular.
* | Fix output in routing.md [ci skip]Yuta Uchida2018-05-071-1/+1
|/
* restores original intention in constants guide, reworded [ci skip]Xavier Noria2018-05-061-4/+6
| | | | | | | | | | | | | | | | | | | | | | | Once all technicalities have been introduced, the purpose of this paragraph is to precisely unroll expressions like "the String class". That way, the reader is forced to clearly separate concepts that Ruby programmers often have kind of blurred: * Constants are storage, like variables. * Ruby does not have syntax for class or module names. * `String` is a regular constant that holds a value. In this case, the value happens to be a class object. * Constants are stored in class and module objects. In the case of `String`, the holder is the class object stored in the `Object` constant. Understanding that paragraph the way is written is important to accomplish this objective. References #32818.
* Active Record postgresql documentation for bit string types correctedSagar Kamble2018-05-061-1/+1
|
* Merge pull request #32818 from mechanicles/remove-sentence-confusionEileen M. Uchitelle2018-05-041-3/+3
|\ | | | | Remove confusion in the sentence [ci skip]
| * Remove confusion in the sentence [ci skip]Santosh Wadghule2018-05-041-3/+3
| |
* | Minor edits to the Active Storage guideTyler Hunt2018-05-031-5/+5
| | | | | | | | | | | | Fix spelling, grammar, and formatting. [ci skip]
* | Partly revert "Use https with weblog URI" [ci skip]Ryuta Kamizono2018-05-031-1/+1
|/ | | | weblog.jamisbuck.org is not GitHub Pages.
* Use https with weblog URIYoshiyuki Hirano2018-05-027-12/+12
|
* Merge pull request #32769 from anthonycrumley/document-active-storage-folderGeorge Claghorn2018-04-301-0/+1
|\ | | | | Document rails new <app> storage folder
| * Document rails new <app> storage folderAnthony Crumley2018-04-301-0/+1
| | | | | | | | | | [ci skip] Active Storage now adds a storage folder to newly generated rails applications.
* | Fix an oxford commaAnthony Crumley2018-04-301-1/+1
|/ | | | [ci skip]
* Remove reference to TokaidoJonathan Roes2018-04-301-5/+3
|
* Fix url_helper examples in testing guide [ci skip]Chris Houhoulis2018-04-291-4/+4
|
* We usually do not use GH#1234 style in the CHANGELOGs [ci skip]Ryuta Kamizono2018-04-291-1/+1
|
* Merge pull request #32698 from zealot128/patch-1George Claghorn2018-04-281-0/+172
|\ | | | | [ci skip] update ActiveStorage documentation
| * [ci skip] update ActiveStorage documentationStefan Wienert2018-04-281-0/+172
| | | | | | | | | | | | | | | | - added documentation on how to download files, with example of ActiveStorage::Downloading - documentation about linking files outside of controller/view - added section about DirectUpload JavaScript integration into libraries/frameworks, as well as usage in combination with Drag and Drop
* | [ci skip] Fix typo in testing.mdPradyumna Shembekar2018-04-271-1/+1
| |
* | Adding precision about which letter case to use for controller names … ↵simonjamain2018-04-271-0/+2
| | | | | | | | | | | | | | | | (#32740) * Adding precision about which letter case to use for controller names in routing Many people (including myself) encounter an error when having multiple words controller names and trying to put camelCase in their routes
* | Update 'rails_welcome.png' to reflect a more diverse population (#32735)Jamie Dihiansan2018-04-261-0/+0
| | | | | | | | | | | | * Update 'rails_welcome.png' to reflect a more diverse population * Cleanup 'rails_welcome.png'
* | Merge pull request #32702 from bogdanvlviv/fix-description-for-31685Rafael França2018-04-251-2/+2
|\ \ | | | | | | Fix title for example of removing data from `session` [ci skip]
| * | Fix title for example of removing data from `session` [ci skip]bogdanvlviv2018-04-231-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | After #31685 the description says different what we expect to see in the example. Change `assign that key to be nil` to `or delete the key/value pair` in order to highlight what is shown in the example. Fix one more example of removing data from the session in favour of using `delete` since assigning to `nil` doesn't delete key from it.
* | | Fix typo in migrations guide [ci skip]Daniel Colson2018-04-241-1/+1
| | | | | | | | | | | | Introduced in #32646
* | | Merge pull request #32646 from derekprior/dp-schema-dumper-documentationSean Griffin2018-04-241-45/+35
|\ \ \ | | | | | | | | Update schema.rb documentation [CI SKIP]
| * | | Update schema.rb documentation [CI SKIP]Derek Prior2018-04-241-45/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The documentation previously claimed that `db/schema.rb` was "the authoritative source for your database schema" while simultaneously also acknowledging that the file is generated. These two statements are incongruous and the guides accurately call out that many database constructs are unsupported by `schema.rb`. This change updates the comment at the top of `schema.rb` to remove the assertion that the file is authoritative. The documentation also previously referred vaguely to "issues" when re-running old migrations. This has been updated slightly to hint at the types of problems that one can encounter with old migrations. In sum, this change attempts to more accurately capture the pros, cons, and shortcomings of the two schema formats in the guides and in the comment at the top of `schema.rb`. [Derek Prior & Sean Griffin] Co-authored-by: Sean Griffin <sean@seantheprogrammer.com>
* | | | Merge pull request #32471 from janko-m/use-image_processing-gemGeorge Claghorn2018-04-232-7/+18
|\ \ \ \ | |_|/ / |/| | | Use ImageProcessing gem for ActiveStorage variants
| * | | Correct typosJanko Marohnić2018-04-231-2/+2
| | | |
| * | | Recommend using :resize_to_fit after allJanko Marohnić2018-04-231-2/+2
| | | |
| * | | Replace :resize_to_fit with :resize in the guideJanko Marohnić2018-04-231-1/+1
| | | |
| * | | Rename ActiveStorage.processor to .variant_processorJanko Marohnić2018-04-222-2/+2
| | | |
| * | | Use ImageProcessing gem for ActiveStorage variantsJanko Marohnić2018-04-182-6/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ImageProcessing gem is a wrapper around MiniMagick and ruby-vips, and implements an interface for common image resizing and processing. This is the canonical image processing gem recommended in [Shrine], and that's where it developed from. The initial implementation was extracted from Refile, which also implements on-the-fly transformations. Some features that ImageProcessing gem adds on top of MiniMagick: * resizing macros - #resize_to_limit - #resize_to_fit - #resize_to_fill - #resize_and_pad * automatic orientation * automatic thumbnail sharpening * avoids the complex and inefficient MiniMagick::Image class * will use "magick" instead of "convert" on ImageMagick 7 However, the biggest feature of the ImageProcessing gem is that it has an alternative implementation that uses libvips. Libvips is an alternative to ImageMagick that can process images very rapidly (we've seen up 10x faster than ImageMagick). What's great is that the ImageProcessing gem provides the same interface for both implementations. The macros are named the same, and the libvips implementation does auto orientation and thumbnail sharpening as well; only the operations/options specific to ImageMagick/libvips differ. The integration provided by this PR should work for both implementations. The plan is to introduce the ImageProcessing backend in Rails 6.0 as the default backend and deprecate the MiniMagick backend, then in Rails 6.1 remove the MiniMagick backend.
* | | | Remove key from session by using session.delete (#31685)Rafael Barbolo2018-04-231-1/+3
| |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove key from session by using session.delete You are not deleting a key from session when you assign nil to that key. * Update guides on how to destroy a user session In this commit, the user id is removed from session and controller's variables related to the user are nullified. [Rafael Mendonça França + Rafael Barbolo]
* | | Merge pull request #32689 from yhirano55/update-testing-guidesGuillermo Iguaran2018-04-221-13/+14
|\ \ \ | | | | | | | | Update results of command in Testing guides [ci skip]
| * | | Update results of command in Testing guides [ci skip]Yoshiyuki Hirano2018-04-231-13/+14
| | | | | | | | | | | | | | | | | | | | * Results of command in testing guides are different from actual ones. * Updated them.
* | | | Refactor guides javascriptsYoshiyuki Hirano2018-04-232-26/+34
| | | | | | | | | | | | | | | | | | | | * Remove `$` prefix from all variables (`$` prefix means jQuery object) * Old browsers doesn't support forEach. So use for instead of forEach.
* | | | :scissors: jQuery for Rails GuidesYoshiyuki Hirano2018-04-215-95/+88
|/ / / | | | | | | | | | | | | * Rewrite with Vanilla JS * Confirmed with Chrome, Safari, Firefox