| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Edit Security Guide's Session Guidelines & Custom Credentials [skip ci]
|
| |\ |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Edit Session Guidelines to achieve tighter prose and accuracy
* Remove mentions related to earlier Rails versions
* Add links to ActionController guide and Custom Credentials part
* Clarify Custom Credentials part
|
| | | |
|
|\ \ \
| | | |
| | | | |
Add `rails test:channels` and fix Action Cable templates
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Related to 837f602fa1b3281113dac965a8ef96de3cac8b02
Fix the testing guide.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Engines guide in the Overriding Models and Controllers section
references the Decorator pattern, which isn't appropriate, since
Decorator pattern is not about reopening existing classes, is about
adding functionality to existing object instances; something that in
Ruby is commonly implemented using Delegators.
Moreover, the suggested naming convention for overrides,
`app/decorators/**/*_decorator*.rb`, conflicts with a naming convention
commonly used for View Model / Presentation Model decorators, adopted
by popular gems such as `draper`, as well as by custom implementations.
|
| | |
| | |
| | |
| | |
| | |
| | | |
(#28078)
This PR addresses the issue described in #28025. On `dependent: :nullify` strategy only the foreign key of the relation is nullified. However on polymorphic associations the `*_type` column is not nullified leaving the record with a NULL `*_id` but the `*_type` column is present.
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
bogdanvlviv/fix-action-cable-guide-follow-up-34709
Fix "Action Cable Overview" guide [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix path to channel files.
`rails generate channel Chat` generates `app/javascript/channels/chat_channel.js`.
See also,
railties/lib/rails/generators/rails/app/templates/app/javascript/packs/application.js.tt,
actioncable/lib/rails/generators/channel/templates/javascript/index.js.tt
by default `application.js` imports "channels", where
`app/javascript/channels/index.js` loads all the channels within
this directory and all subdirectories.
Follow up #34709
Related to #33079
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In #34709 we updated the guide, but `actioncable/README.md` is still
outdated. Instead of fixing content in the file. I suggest
not duplicate the info that is already in the guide and instead remove
the info from the file and just add a message:
"You can read more about Action Cable in the
[Action Cable Overview](https://edgeguides.rubyonrails.org/action_cable_overview.html) guide."
The same approach is being used for Action Mailbox and Action Text,
see #34812 and #34878.
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
lanzhiheng/improve-doc-in-routing-2-10-adding-member-routes
improve doc in `Adding Member Routes` section of routing chapter.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
bogdanvlviv/docs_config_action_mailer_delivery_job
Add info about `config.action_mailer.delivery_job` to the guide [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Also, add mention to `new_framework_defaults_6_0.rb` that
`ActionMailer::Parameterized::DeliveryJob` is default for parameterized mail
and will be removed.
Related to #34692
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
about leak into subsequent requests.
[ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Move all npm packages to @rails scope
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
Fixes #33083
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Specify the type for the auto-generated primary key
|
| | | | |
| | | | |
| | | | | |
Given the change to using `bigint` as type for auto-generated primary keys (as per https://github.com/rails/rails/pull/26266), I propose updating the Active Record Basics guide to explicitly state the type being used so as to avoid confusion as to the type of integer used, especially as the type can vary depending on the database used.
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Enable `Lint/UselessAssignment` cop to avoid unused variable warnings
Since we've addressed the warning "assigned but unused variable"
frequently.
370537de05092aeea552146b42042833212a1acc
3040446cece8e7a6d9e29219e636e13f180a1e03
5ed618e192e9788094bd92c51255dda1c4fd0eae
76ebafe594fc23abc3764acc7a3758ca473799e5
And also, I've found the unused args in c1b14ad which raises no warnings
by the cop, it shows the value of the cop.
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
yhirano55/rails_info_properties_json""
I reverted the wrong commit. Damn it.
This reverts commit f66a977fc7ae30d2a07124ad91924c4ee638a703.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We had a discussion on the Core team and we don't want to expose this information
as a JSON endpoint and not by default.
It doesn't make sense to expose this JSON locally and this controller is only
accessible in dev, so the proposed access from a production app seems off.
This reverts commit 8eaffe7e89719ac62ff29c2e4208cfbeb1cd1c38, reversing
changes made to b6e4305c3bca4c673996d0af9db0f4cfbf50215e.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Add Action Text to guides [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Move some actiontext/README.md content to Action Text Overview guide
- I added WIP label to that guide since we definitely want to complement it.
- Add Action Text to Major Features of Rails 6.0
Similar approach was used in #34812
|
|\ \ \ \
| | | | |
| | | | | |
Add `action_text_content` hook to the guide [ci skip]
|
| |/ / /
| | | |
| | | |
| | | | |
See actiontext/lib/action_text/content.rb:132
|
|/ / /
| | |
| | |
| | | |
[ci skip]
|
| | |
| | |
| | | |
Match Action Mailbox, which sets a default queue for each of its two jobs.
|
| | |
| | |
| | |
| | | |
Since #34356 logging `locale` value is more correct
|
|\ \ \
| | | |
| | | | |
Update the "Configuring Rails Applications" guide [ci skip]
|
| | | |
| | | |
| | | |
| | | | |
Add section "Results of `load_defaults`" to the guide.
|
|\ \ \ \
| |/ / /
|/| | | |
Add missing keys to ActiveSupport#instrumentation guide [skip ci]
|
| | | |
| | | |
| | | |
| | | | |
See https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb#L625.
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | | |
[ci skip]
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
blaszczakphoto/update-docs-regarding-gzipping-assets
Rename header of the gzip paragraph
|
| | | | |
| | | | |
| | | | |
| | | | | |
aboaut what to do about serving gziped files [ci skip]
|