aboutsummaryrefslogtreecommitdiffstats
path: root/guides
Commit message (Collapse)AuthorAgeFilesLines
...
* | Change `ActionDispatch::Response#content_type` returning Content-Type header ↵yuuji.yaginuma2019-06-013-1/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as it is Since #35709, `Response#conten_type` returns only MIME type correctly. It is a documented behavior that this method only returns MIME type, so this change seems appropriate. https://github.com/rails/rails/blob/39de7fac0507070e3c5f8b33fbad6fced84d97ed/actionpack/lib/action_dispatch/http/response.rb#L245-L249 But unfortunately, some users expect this method to return all Content-Type that does not contain charset. This seems to be breaking changes. We can change this behavior with the deprecate cycle. But, in that case, a method needs that include Content-Type with additional parameters. And that method name is probably the `content_type` seems to properly. So I changed the new behavior to more appropriate `media_type` method. And `Response#content_type` changed (as the method name) to return Content-Type header as it is. Fixes #35709. [Rafael Mendonça França & Yuuji Yaginuma ]
* | Merge pull request #36077 from st0012/update-doc-for-pluckPrem Sichanugrist2019-05-291-0/+15
|\ \ | | | | | | Add a section to introduce pluck's eager loading behavior [ci skip]
| * | Add a section to introduce `pluck`'s eager loading behaviorst00122019-05-031-0/+15
| | |
* | | Merge pull request #36348 from corprew/docs-stringify-keys-stable-resultRyuta Kamizono2019-05-281-8/+4
|\ \ \ | | | | | | | | | | | | [documentation][ci skip] stringify_keys and symbolize_keys have stable results.
| * | | stringify_keys and symbolize_keys have stable results.Corprew Reed2019-05-271-8/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails 6 uses the `Hash.transform_keys` found in Ruby 2.5 and later, and that method enumerates keys based on insertion order. Calling `symbolize_keys`, `stringify_keys`, and their bang variants will result in the same hash every time -- the value for any key where a collision occurs is the last assigned in that enumeration In the docs for Hash -- https://ruby-doc.org/core-2.5.0/Hash.html > Hashes enumerate their values in the order that the corresponding keys were inserted.
* | | | changes 'Week day' to 'day of week'Corprew Reed2019-05-271-1/+1
|/ / / | | | | | | | | | | | | 'Week day' has a specific meaning in English -- see https://en.wiktionary.org/wiki/weekday for details -- that is not meant here. 'Day of week' is more appropriate. [ci skip]
* | | Mirror direct uploadsGeorge Claghorn2019-05-222-8/+24
| | |
* | | Add `action_cable_connection_test_case` hook to the "available hooks" list ↵प्रथमेश Sonpatki2019-05-221-28/+29
| | | | | | | | | | | | | | | [ci skip] (#36326) - This hook was added in 90296674b1c
* | | Merge pull request #36282 from yoones/add-skip-options-to-command-line-guideEileen M. Uchitelle2019-05-181-0/+22
|\ \ \ | | | | | | | | List available skip options in command line guide
| * | | List available skip options in command line guide [ci skip]Younes SERRAJ2019-05-151-0/+22
| | | |
* | | | Merge pull request #36263 from vishaltelangre/add-undefined-acronymEileen M. Uchitelle2019-05-181-2/+2
|\ \ \ \ | | | | | | | | | | [skip ci] Add undefined STI acronym to the heading which is referred under its section
| * | | | [skip ci] Add undefined STI acronym to the heading which is referred under ↵Vishal Telangre2019-05-121-2/+2
| | | | | | | | | | | | | | | | | | | | its section
* | | | | typo changeflocela2019-05-161-1/+1
| |/ / / |/| | | | | | | | | | | In Adding More RESTful Actions, Adding Member Routes: I believe the word 'that' should be added to the sentence, 'Within the block of member routes, each route name specifies the HTTP verb will be recognized.' This results in 'Within the block of member routes, each route name specifies the HTTP verb that will be recognized.'
* | | | edit tweaks to recent patch in configuring guide [ci skip]Xavier Noria2019-05-141-1/+2
| | | |
* | | | Merge pull request #36200 from ↵Xavier Noria2019-05-141-0/+6
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | soartec-lab/update_guide_configuring_add_autoloader Added guide for `config.autoloader` [skip ci]
| * | | | Added guide for `config.autoloader` [skip ci]soartec-lab2019-05-071-0/+6
| | | | |
* | | | | shortens a comment [ci skip]Xavier Noria2019-05-141-1/+1
| | | | | | | | | | | | | | | | | | | | To avoid word wrap in the rendered guide.
* | | | | [skip ci] The default value of ↵Vishal Telangre2019-05-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | config.active_record.collection_cache_versioning without loading Railtie is false Please check https://github.com/rails/rails/pull/36260#discussion_r283266942 for reference. [Vishal Telangre, bogdanvlviv]
* | | | | Merge pull request #36260 from ↵Eileen M. Uchitelle2019-05-131-0/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | vishaltelangre/active_record-collection_cache_versioning-config-info [skip ci] Add missing info about 'active_record.collection_cache_versioning' configuration
| * | | | | [skip ci] Add missing info about 'active_record.collection_cache_versioning' ↵Vishal Telangre2019-05-121-0/+6
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | configuration References: - https://github.com/rails/rails/commit/4f2ac80d4cdb01c4d3c1765637bed76cc91c1e35 - https://github.com/rails/rails/blob/b1c917ee2fdaa452aeb52904db0d254d85285380/railties/lib/rails/application/configuration.rb#L147-L149
* | | | | Merge pull request #36245 from vishaltelangre/patch-4Vipul A M2019-05-122-4/+5
|\ \ \ \ \ | | | | | | | | | | | | [ci skip] Clarity about embed metadata in signed and encrypted cookie
| * | | | | [ci skip] Clarity about embed metadata in signed and encrypted cookieVishal Telangre2019-05-122-4/+5
| | | | | |
* | | | | | upgrading docs: one file => one constant [ci skip]Xavier Noria2019-05-121-0/+29
| | | | | |
* | | | | | NPM -> npm [ci skip]Xavier Noria2019-05-121-2/+2
| |/ / / / |/| | | | | | | | | | | | | | According to https://www.npmjs.com/.
* | | | | Update the 6.0 load_defaults list [ci skip] (#36258)Vipul A M2019-05-111-0/+2
| | | | |
* | | | | Merge pull request #36160 from sharang-d/update-getting-startedVipul A M2019-05-111-1/+1
|\ \ \ \ \ | | | | | | | | | | | | compilation -> compression [ci skip]
| * | | | | compilation -> compression [ci skip]Sharang Dashputre2019-05-021-1/+1
| | | | | |
* | | | | | Merge pull request #36251 from vishaltelangre/patch-10Xavier Noria2019-05-111-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | [ci skip] Clarify that the minimum version of a "gem" is bumped
| * | | | | | [ci skip] Clarify that the minimum version of a "gem" is bumpedVishal Telangre2019-05-121-1/+1
| | |/ / / / | |/| | | | | | | | | | | | | | | | The previous sentence does not convey whether the minimum version of SQLite3 is bumped or the minimum version of `sqlite3` gem is bumped.
* | | | | | Merge pull request #36243 from vishaltelangre/patch-1Xavier Noria2019-05-111-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | [ci skip] Typo: Javascript -> JavaScript
| * | | | | | [ci skip] Typo: Javascript -> JavaScriptVishal Telangre2019-05-111-1/+1
| |/ / / / /
* | | | | | Merge pull request #36246 from vishaltelangre/patch-5Xavier Noria2019-05-111-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | [ci skip] Fix grammar
| * | | | | | [ci skip] Fix grammarVishal Telangre2019-05-111-1/+1
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ##### Singular `route exists` ##### Plural `routes exist`
* | | | | | Merge pull request #36252 from vishaltelangre/patch-11Xavier Noria2019-05-111-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | [ci skip] mysql -> MySQL
| * | | | | | [ci skip] mysql -> MySQLVishal Telangre2019-05-111-1/+1
| | | | | | |
* | | | | | | Merge pull request #36247 from vishaltelangre/patch-6Xavier Noria2019-05-111-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | [ci skip] ActionView -> Action View
| * | | | | | | [ci skip] ActionView -> Action ViewVishal Telangre2019-05-111-1/+1
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | As per the documentation guides, we use 'Action View' instead of `ActionView` in the general language. Reference: https://github.com/rails/rails/commit/27138386ad8dbda2eb44e622515626f352fd3b22
* | | | | | | Merge pull request #36248 from vishaltelangre/patch-7Xavier Noria2019-05-111-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | [ci skip] Mime -> MIME
| * | | | | | | [ci skip] Mime -> MIMEVishal Telangre2019-05-111-1/+1
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | The correct word is `MIME` which is an acronym which stands for `Multipurpose Internet Mail Extensions`. Reference: https://en.wikipedia.org/wiki/MIME
* | | | | | | Merge pull request #36249 from vishaltelangre/patch-8Xavier Noria2019-05-111-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | [ci skip] Expand JS to JavaScript for clarity
| * | | | | | | [ci skip] Expand JS to JavaScript for clarityVishal Telangre2019-05-111-1/+1
| |/ / / / / /
* | | | | | | Merge pull request #36250 from vishaltelangre/patch-9Xavier Noria2019-05-111-1/+1
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | [skip ci] arel -> Arel
| * | | | | | [skip ci] arel -> ArelVishal Telangre2019-05-111-1/+1
| |/ / / / / | | | | | | | | | | | | As per the documentation guides, we write `Arel` instead of `arel`.
* / / / / / [ci skip] Typo: ActiveSuppport -> ActiveSupportVishal Telangre2019-05-111-3/+3
|/ / / / /
* | | | | Merge pull request #36241 from ↵Xavier Noria2019-05-111-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | vishaltelangre/fix-confusing-sentence-in-upgrade-guide [ci skip] Fix confusing sentence in upgrade guide
| * | | | | [ci skip] Fix confusing sentence in upgrade guideVishal Telangre2019-05-111-1/+1
| | | | | |
* | | | | | Corrected the sentence in upgrade guideshekhar-patil2019-05-111-1/+1
|/ / / / /
* | | | | Merge branch 'migration-timestamp-fix'Gannon McGibbon2019-05-101-0/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Closes #28707.
| * | | | | Add class option timestamps to migration generatorMichael Duchemin2019-02-091-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | Fixes GH#28706. Now rails g migration create_users and rails g model User have the same behavior for timestamps since they implement the same migration template. The expected behavior is that this create table migration will create the table with timestamps unless you pass --no-timestamps or --skip-timestamps to the generator. The expected migration should match what you get when you use the model generator. Using the migration generator, which doesn't have a class_option for timestamps would cause them to not be added to the migration file. Now the migration behavior of the migration generator, create_table only, is aligned with the migration behavior of the model generator. Also modified relevant example of ActiveRecord Migrations Guide.
* | | | | | Merge pull request #36184 from vishaltelangre/as-monotonic-timed-subscriberEileen M. Uchitelle2019-05-101-1/+10
|\ \ \ \ \ \ | | | | | | | | | | | | | | Introduce ActiveSupport::Notifications.monotonic_subscribe