aboutsummaryrefslogtreecommitdiffstats
path: root/guides
Commit message (Collapse)AuthorAgeFilesLines
* Specify `hosts` in bug report template.yuuji.yaginuma2018-12-251-0/+1
| | | | | | | | | | | | | | | | | | | Host authentication introduced by #33145 allows only "0.0.0.0/0", "::/0" and "localhost" in the development environment. https://github.com/rails/rails/blob/4298df00ae6219b9b5b7c40f281d4fa4d66f4383/railties/lib/rails/application/configuration.rb#L33 But `rack-test` use `example.org` for default host. https://github.com/rack-test/rack-test/blob/6c07bf53adf4a4082e206561f5b9b43142fdc821/lib/rack/test.rb#L13 Therefore, if `hosts` is not specified, host authentication rejects the request. In Travis CI, this problem does not occur because `test` is specified by default in `RAILS_ENV` and `RACK_ENV`. https://docs.travis-ci.com/user/environment-variables/#default-environment-variables If user actually use it, env may not always be specified. Explicitly specify hosts in the file so that it works in any environment.
* Follow up #34754bogdanvlviv2018-12-201-20/+1
| | | | | | | - Fix a few deprecation warnings - Remove testing of `Hash#slice` - Imporve test of `Hash#slice!` - Remove mention about `Hash#slice` from the guide
* Use native `Array#append`, `Array#prepend`, `Hash#transform_keys`, and ↵Ryuta Kamizono2018-12-201-66/+0
| | | | | | | | | | `Hash#transform_keys!` Since Rails 6 requires Ruby 2.5. https://github.com/ruby/ruby/blob/ruby_2_5/NEWS Follow up #34754.
* Require Ruby 2.5 for Rails 6.Kasper Timm Hansen2018-12-193-4/+4
| | | | | | | | | | Generally followed the pattern for https://github.com/rails/rails/pull/32034 * Removes needless CI configs for 2.4 * Targets 2.5 in rubocop * Updates existing CHANGELOG entries for fewer merge conflicts * Removes Hash#slice extension as that's inlined on Ruby 2.5. * Removes the need for send on define_method in MethodCallAssertions.
* Single nest config in configuration guidesSam Bostock2018-12-181-1/+1
| | | | | | | Double nesting of configuration is not supported (without using an intermediate object), even though the docs suggest it is. [ci-skip]
* Add option to set parallel test worker count to the physical core count of ↵Bogdan2018-12-181-4/+4
| | | | | | | | | | | | | | | | | | | | | | the machine (#34735) * Add option to set parallel test worker count to the physical core count of the machine Also, use the physical core count of the machine as the default number of workers, and generate the `test_helper.rb` file with `parallelize(workers: :number_of_processors)` Closes #34734 * Ensure that we always test parallel testing Since #34734 we decided to use the physical core count of the machine as the default number of workers in the parallel testing, we need to ensure that some tests use at least 2 workers because we could run those tests on VM that has only 1 physical core. It also fixes tests failures on the CI since Travis server we are using has only one physical core. See https://travis-ci.org/rails/rails/jobs/469281088#L2352
* Extend documentation of `ActiveSupport::Notifications.subscribe` (#34721)Bogdan2018-12-171-1/+13
| | | | | | | | | | | * Extend documentation of `ActiveSupport::Notifications.subscribe` Add mention that a block with only one argument passed to the method will yield an event object. Related to #33451 * Emphasize that `SubscribeEventObjects` is a test class by adding suffix `Test`
* Merge pull request #32872 from utilum/soften_migrations_guide_generator_sectionVipul A M2018-12-151-4/+9
|\ | | | | Expand intro to generator in Migrations Guide
| * Expand intro to Migration generator in Migrations Guideutilum2018-05-111-4/+9
| | | | | | | | [ci skip]
* | Prepend module in ActiveStorage overviewSam Bostock2018-12-101-8/+14
| | | | | | | | [ci skip]
* | Fix typo in per-form CSRF token docs [ci skip]Randy Antler2018-12-071-1/+1
| |
* | Abort early if generator command fails (#34420)David Rodríguez2018-12-071-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * No need to go through ruby * Abort early if a generator command fails * Reuse `rails_command` method * Bump thor minimum dependency to 0.20.3 * Add some minimal docs * Add a changelog entry * Restore original logging
* | Improve deprecation message for enqueue returning falseRafael Mendonça França2018-12-051-0/+2
| | | | | | | | | | | | And make sure new applications in Rails 6.0 has this config enabled. Also, improve test coverage and add a CHANGELOG entry.
* | Use safe nav operator when calling RailsGuides::Generator.newYosuke Kabuto2018-12-052-3/+3
| | | | | | | | Use String for direction of RailsGuides::Generator
* | Add advanced test helpers docs to guidesSam Bostock2018-12-041-0/+50
| | | | | | | | [ci skip]
* | Add note about symbols vs stringsGannon McGibbon2018-12-041-0/+2
| |
* | Improve parallel testing guide [ci skip]bogdanvlviv2018-12-031-10/+9
| | | | | | | | | | | | | | | | - Fix formatting - Don't repeat "Active Record automatically handles creating and migrating a new database for each worker to use." - Tell that AR loads the schema to a database for each process(Related to #33479) - Clarify that `parallelize_teardown` is executed for each process
* | fix example code syntax [ci skip]Greg Molnar2018-12-011-1/+1
| |
* | Clarify no support for non PK id columnsGannon McGibbon2018-11-301-0/+2
| | | | | | | | [ci skip]
* | [ci skip] Add a Delayed Job project link.Tonči Damjanić2018-11-291-0/+1
| | | | | | Delayed Job is mentioned multiple times in the document, but it is not linked from anywhere.
* | Clarify scope body requirementsGannon McGibbon2018-11-261-1/+1
| | | | | | | | [ci skip]
* | Merge pull request #34520 from yahonda/bump_pg93Rafael França2018-11-261-1/+1
|\ \ | | | | | | Bump the minimum version of PostgreSQL to 9.3
| * | Bump the minimum version of PostgreSQL to 9.3Yasuo Honda2018-11-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://www.postgresql.org/support/versioning/ - 9.1 EOLed on September 2016. - 9.2 EOLed on September 2017. 9.3 is also not supported since Nov 8, 2018. https://www.postgresql.org/about/news/1905/ I think it may be a little bit early to drop PostgreSQL 9.3 yet. * Deprecated `supports_ranges?` since no other databases support range data type * Add `supports_materialized_views?` to abstract adapter Materialized views itself is supported by other databases, other connection adapters may support them * Remove `with_manual_interventions` It was only necessary for PostgreSQL 9.1 or earlier * Drop CI against PostgreSQL 9.2
* | | Use cache_key_with_version instead of cache_key for the example in Low-Level ↵tnantoka2018-11-261-1/+1
| | | | | | | | | | | | Caching [ci skip]
* | | Updating the Testing Guide to Reflect Emails Enqueued With ActiveJob [ci skip]Tom Rossi2018-11-251-7/+23
|/ /
* | Merge pull request #34455 from ↵Rafael França2018-11-231-1/+1
|\ \ | | | | | | | | | | | | minimalweb/progressive_jpeg_inclusion_as_variable_content_type Add progressive JPG MIME-type to default variable content types
| * | Add progressive JPG to default variable content typesMaurice Kühlborn2018-11-211-1/+1
| | |
* | | Use direction instead of rtl flag.Alberto Almagro2018-11-222-18/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | Improve readability by using `direction` as CSS does. More info: https://developer.mozilla.org/en-US/docs/Web/CSS/direction Continues: #34486 [Alberto Almagro + Ufuk Kayserilioglu]
* | | Fix typo in development_dependencies_install.md [ci skip]Alfonso Jiménez2018-11-201-1/+1
| | |
* | | Indent guides as rails help command output[ci skip]Alberto Almagro2018-11-191-25/+25
| | | | | | | | | | | | | | | | | | The output from `rails help` actually leaves an empty space when printing the command lists. This commit adapts this guide to have the same format.
* | | Merge pull request #34486 from tamarr/masterRafael Mendonça França2018-11-193-3/+772
|\ \ \ | | | | | | | | | | | | allow right to left styling of docs
| * | | allow right to left styling of docs (#3)tamarr2018-11-193-3/+771
| | | | | | | | | | | | | | | | * adding rtl css main file and logic to use
* | | | [ci skip] Update active_job_basics.mdShota Iguchi2018-11-191-1/+1
| | | | | | | | | | | | | | | | ApplicationJob should be inherits ActiveJob::Base
* | | | Change queueing to queuing in docs and comments [skip ci]jacobherrington2018-11-181-1/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | My spellchecker flagged this as an incorrect spelling, upon further research it appears to be a point of contention in English. Either way might work. After further examination queuing is much more common in the Rails codebase so making this change will serve to standardize the spelling.
* / / Replace cache_key with cache_key_with_version on caching_with_rails guides ↵tnantoka2018-11-161-3/+3
|/ / | | | | | | [ci skip]
* | fix typo on association_basics.md [ci skip]Espartaco Palma2018-11-141-1/+1
| |
* | Describe how has_many's :dependent option affects #deleteMarcel M. Cary2018-11-131-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I was puzzled about why `collection=` was destroying the removed records on an association with `dependent: :destroy`, even after consulting the documentation for that option. I had to dive into the Active Record source to understand what was going on: eventually `collection=` calls `collection.delete` on the ousted records, and it also uses the `:dependent` option to decide how to remove records. It would have helped me to have mention of this in the documentation for `:dependent`, not just under `collection.delete` (which I found much later). Briefly mention the broader impacts of `:dependent` in the Association Basics guide. [ci skip]
* | Add support for UNLOGGED Postgresql tablesJacob Evelyn2018-11-131-0/+8
| | | | | | | | | | | | | | | | | | | | | | This commit adds support for the `ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.create_unlogged_tables` setting, which turns `CREATE TABLE` SQL statements into `CREATE UNLOGGED TABLE` statements. This can improve PostgreSQL performance but at the cost of data durability, and thus it is highly recommended that you *DO NOT* enable this in a production environment.
* | Revert "Merge pull request #34421 from ↵Ryuta Kamizono2018-11-112-2/+2
| | | | | | | | | | | | | | albertoalmagro/use-assert-not-instead-of-refute" This reverts commit ab5d5c95ec51c63d58d7e75694af748f165e2228, reversing changes made to ef4f5ef69b5a50c897bbb17f6b36b729dff12e6c.
* | Prefer assert_not instead of refute [ci skip]Alberto Almagro2018-11-102-2/+2
| | | | | | | | | | | | | | | | As mentioned in the contributing to Ruby on Rails guides, we should prefer `assert_not` instead of `refute`. And the best place to start giving example are our bug report templates.. See: https://github.com/rails/rails/blame/master/guides/source/contributing_to_ruby_on_rails.md#L256
* | Merge pull request #34373 from shiroginne/masterRobin Dupret2018-11-101-3/+3
|\ \ | | | | | | | | | | | | Fix typo for Action Cable Overview doc [Eileen M. Uchitelle]
| * | Update `action_cable_overview.md`: fix typo.Evgeny Sugakov2018-11-101-3/+3
| | | | | | | | | | | | [ci skip]
* | | Merge pull request #34415 from Ana06/present_associationsGannon McGibbon2018-11-091-1/+2
|\ \ \ | | | | | | | | Clarify the validation of present associations
| * | | Clarify the validation of present associationsAna María Martínez Gómez2018-11-091-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | I think that it is not clear what means that _an association is present_. Add that it is checking that the foreign key is not empty and that the referenced object exists to clarify it.
* | | | Merge pull request #32881 from vfonic/update-development-deps-installRobin Dupret2018-11-093-270/+121
|\ \ \ \ | | | | | | | | | | | | | | | Docs: Update Development Dependencies Install
| * | | | Docs: Update Development Dependencies InstallViktor Fonic2018-11-093-270/+121
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Move all the testing related stuff to the contributing guide and redirect the reader to this guide once the installation process is finished as running tests is the logical next step. * Group documentation instructions by OS, not by gem * It eases the installation process and lessen the need to scroll through the guide * There's still a list of all additional services required for each of the gems above the instructions for each OS. * Also update a bit the instructions * Update some package names * Add `yarn` to the package list for Arch Linux and FreeBSD * Use `dnf` instead of `yum` for Fedora and CentOS * Advise the user to use `brew bundle` on macOS to lessen the maintenance burden for this OS and ease the process for the user. [ci skip]
* | | | Amend CVE note and security guide section wordingsGannon McGibbon2018-11-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Reword first sentence of dep management and CVE section of security guide. Also, reword and move gemspec notes above deps. [ci skip]
* | | | Add CVE note to security guide and gemspecsGannon McGibbon2018-11-061-0/+5
| | | | | | | | | | | | | | | | [ci skip]
* | | | Fix typoNick Coyne2018-11-051-1/+1
|/ / / | | | | | | Just a small typo fix for the recently merged #34257
* | | Make i18n locale setting docs use around_actionGannon McGibbon2018-10-311-15/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | Changes `I18n.locale` assignment in docs to use `I18n.with_locale` in `around_action` to ensure locale resetting after action processing. [ci skip] [Gannon McGibbon + Leonardo Tegon]
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-26 08:34:21 +0000