aboutsummaryrefslogtreecommitdiffstats
path: root/guides
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Clearly state purpose of test directoriesgo2null2016-08-221-2/+4
| | | | | | | | | | | | | | | * Added location for route, view and job tests to section 2.1. (They are currently only defined in sections 8 Testing Views and 11 Testing Jobs.) * Added location for route test in section 7 Testing Routes. (Currently only defined in section 8 Testing Views.)
* | | Change form of table name to plural in query exampleDanila Ermakov2016-08-221-2/+2
| | |
* | | Merge pull request #26241 from scottyantipa/query-interface-docsJon Moss2016-08-211-3/+3
|\ \ \ | | | | | | | | Upate guides to properly define return values of finder methods
| * | | Update docs for query interface to not declare that all methods return ↵Scott Antipa2016-08-211-3/+3
| | | | | | | | | | | | | | | | instance of ActiveRecord::Relation
* | | | Merge pull request #26234 from y-yagi/remove_unnessary_session_store_settingKasper Timm Hansen2016-08-211-1/+0
|\ \ \ \ | |/ / / |/| | | remove unnessary `session_store` setting
| * | | remove unnessary `session_store` settingyuuji.yaginuma2016-08-201-1/+0
| | | | | | | | | | | | | | | | | | | | Since e5a6f7ee9e951dbe0e4e9ea2c0743b4dfb135c57, by default the session store will be set to cookie store with application name as session key.
* | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-08-215-8/+8
|\ \ \ \
| * | | | When referring to Rails, be consistent in usage of capitalized form, unless ↵Vipul A M2016-08-193-4/+4
| | | | | | | | | | | | | | | | | | | | it is used in context of a command like bin/rails or the rails directory [ci skip]
| * | | | Grammar changes on getting started guide, specify where exactly the example ↵Vipul A M2016-08-191-2/+2
| | | | | | | | | | | | | | | | | | | | is that we are referring to. [ci skip]
| * | | | Fix remaining broadcasting_name example from Action Cable guide [ci skip]Prathamesh Sonpatki2016-08-121-2/+2
| | | | | | | | | | | | | | | | | | | | - Followup of https://github.com/rails/rails/pull/26125.
* | | | | Merge pull request #26227 from alexcameron89/syntax_highlighter_fixVijay Dev2016-08-201-1/+1
|\ \ \ \ \ | |_|/ / / |/| | | | Increase margin-bottom for doc's code syntax highlighter
| * | | | Increase margin-bottom for doc's code syntax highlighterAlex Kitchens2016-08-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #25744 by slightly increasing the margin in code syntax highlights. With a margin of 0, it was cutting off underscores in Linux browesers, so I slightly increased it to 0.5px.
* | | | | Merge pull request #26224 from jonatack/consistent-asset-precompile-examplesEileen M. Uchitelle2016-08-194-8/+8
|\ \ \ \ \ | |/ / / / |/| | | | Consistent examples and template for assets#precompile
| * | | | Consistent examples and template for assets#precompileJon Atack2016-08-194-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Listening to a few developers today discussing their troubles in understanding how to use the asset pipeline, it turns out that the precompile examples in the guides and assets.rb template have over time become a bit inconsistent. This PR makes the examples consistent in code style, spacing, and asset names, removes the old 'swfObject.js' example, and in a couple of places wraps lines at 80 characters including in the assets.rb template. Re-add spaces inside array parentheses.
* | | | | Merge pull request #25675 from TimPetricola/schema-no-standardized-column-widthsRafael Mendonça França2016-08-191-1/+3
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Option not to line up column attributes in schema.rb
| * \ \ \ \ Merge branch 'master' into schema-no-standardized-column-widthsTim Petricola2016-08-182-1/+3
| |\ \ \ \ \
| * | | | | | Option not to line up column types and attributes in schema.rbTim Petricola2016-08-171-1/+3
| | | | | | |
* | | | | | | [ci skip] Updates ActiveJob guide on default runner.Phil Nash2016-08-181-3/+4
| |/ / / / / |/| | | | | | | | | | | | | | | | | The immediate runner is no longer default, the async adapter is.
* | | | | | i18n documentation for required belongs_to messageIan C. Anderson2016-08-171-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When you don't explicitly provide `optional: true` to a `belongs_to` definition, rails adds a validation to ensure presence of the `belongs_to` validation. However, when the validation is added, it is added with a message key of `:required`, which was not documented in the "Translations for Active Record Models" section of the i18n guides. Here are the lines that add the `:required` message: https://github.com/rails/rails/blob/c3e3577f9d5058382504773bf0d32afa15cb131e/activerecord/lib/active_record/associations/builder/belongs_to.rb#L136-L138 This commit adds the "non-optional association" validation to the table, so rails users know how to override the message for this validation. The default message is "must exist".
* | | | | | Fix #26187Jonathan2016-08-171-0/+1
| | | | | | | | | | | | | | | | | | As "discussed" in #26187 I added the route that magically disappeared again.
* | | | | | Fix diffrent naming in getting_started.mdJonathan2016-08-171-1/+1
|/ / / / / | | | | | | | | | | | | | | | | | | | | I've noticed that once `<h1>Editing article</h1>` L1157 was the title and then later on it's `<h1>Edit article</h1>` L1358 which kind of makes more sense... [ci skip]
* | | | | Fix link in Rails 5.0 Release Note [ci skip]Yohei YASUKAWA2016-08-171-1/+1
| | | | |
* | | | | Merge pull request #26061 from ↵Rafael França2016-08-161-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | malclocke/specify_ar_message_interpolation_names_in_i18n_guide List names of error interpolation variables.
| * | | | | List names of error interpolation variables.Malcolm Locke2016-08-051-1/+1
| | | | | |
* | | | | | Merge pull request #26175 from stomar/upgrade-guide-fixRafael França2016-08-161-0/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Clarify migration to ApplicationRecord in upgrade guides [ci skip]
| * | | | | | Clarify migration to ApplicationRecord in upgrade guides [ci skip]Marcus Stollsteimer2016-08-151-0/+2
| | | | | | |
* | | | | | | Add three new rubocop rulesRafael Mendonça França2016-08-163-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* | | | | | | Clarify use of update task on 4.2 and earlier [ci skip]Marcus Stollsteimer2016-08-151-1/+1
|/ / / / / /
* | | | | | fix usage of pluralized wordchuckdishmon2016-08-141-1/+1
| | | | | |
* | | | | | Revert "Clarify and fix typos in Autoloading Disabled upgrade guide [ci skip]"Xavier Noria2016-08-151-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reason: See https://github.com/rails/rails/pull/26163#issuecomment-239703322 This reverts commit 39effc857e5c774670d6fad1a26aebcc33c51f0a.
* | | | | | Merge pull request #26163 from olivierlacan/clarify-autoloading-disabledJon Moss2016-08-141-12/+12
|\ \ \ \ \ \ | | | | | | | | | | | | | | Clarify and fix typos in autoloading disabled section
| * | | | | | Clarify and fix typos in Autoloading Disabled upgrade guide [ci skip]Olivier Lacan2016-08-141-12/+12
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Guides section about autoloading being disabled was slightly confusing (#24724) and didn't directly reference the removed feature by name (config.autoload_paths) making it much harder for someone to search the upgrade guides for a mention or serendipitously find it via a Google search when running into autoloading issues. I also fixed some confusing turns of phrase and a missing word. /cc @vipulnsward @jvanbaarsen
* / | | | | Fix the documentation for configuring `enable_fragment_cache_logging` [ci skip]Prathamesh Sonpatki2016-08-141-8/+16
|/ / / / / | | | | | | | | | | | | | | | - It is Action Controller config, not Action View.
* | | | | [ci skip] Fix documentation wrong for ActionCableEric Zhang2016-08-121-1/+1
| | | | |
* | | | | [ci skip] Fix documentation for ActionCable::Channel#broadcast_toEric Zhang2016-08-121-2/+2
| | | | |
* | | | | Merge pull request #26110 from aditya-kapoor/minor-doc-fixGuillermo Iguaran2016-08-101-2/+5
|\ \ \ \ \ | | | | | | | | | | | | Minor doc fix related to ActiveModel::SecurePassword [ci skip]
| * | | | | Minor doc fix related to ActiveModel::SecurePassword [ci skip]Aditya Kapoor2016-08-111-2/+5
| | | | | |
* | | | | | Add documentation for `http_cache_forever`. [ci skip]Santosh Wadghule2016-08-101-0/+24
| | | | | |
* | | | | | Fix broken alignments caused by auto-correct commit 411ccbdRyuta Kamizono2016-08-101-1/+2
|/ / / / / | | | | | | | | | | | | | | | Hash syntax auto-correcting breaks alignments. 411ccbdab2608c62aabdb320d52cb02d446bb39c
* | | | | Merge pull request #24476 from vipulnsward/24314-eagerloading-doc-updateVipul A M2016-08-091-2/+3
|\ \ \ \ \ | | | | | | | | | | | | Document know limitation about using `references` in conjunction with custom select clauses [ci skip]
| * | | | | Document know limitation about using `references` in conjunction with eager ↵Vipul A M2016-08-091-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | loading causing it to ignore custom select clauses. [ci skip] Fixes #24314
* | | | | | Merge pull request #26042 from bogdanvlviv/debugging_guideVipul A M2016-08-091-0/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Add link to 'Pry' in debugging guide [ci skip]
| * | | | | Add link to 'Pry' in debugging guide [ci skip]bogdanvlviv2016-08-071-0/+1
| | | | | |
* | | | | | update list of rescue_responses default [ci skip]yuuji.yaginuma2016-08-091-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | Follow up to fe859a54219740fa8b4e09a592820d2ee12ba222
* | | | | | Modify LogSubscriber for single partial's cache message.Stan Lo2016-08-081-0/+8
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement naive partial caching mechanism. Add test for LogSubscriber Use ActionView::Base#log_payload to store log_subscriber's payload, so we can pass cache result into it. Fixed tests Remove useless settings Check if #log_payload exists before calling it. Because other classes also includes CacheHelper but don't have is attribute Use @log_payload_for_partial_reder instead of #log_payload to carry ActionView's payload. Update test's hash syntax Add configuration to enable/disable fragment caching logging Remove unless test and add new test to ensure cache info won't effect next rendering's log Move :enable_fragment_cache_logging config from ActionView to ActionPack Apply new config to tests Update actionview's changelog Update configuration guide Improve actionview's changelog Refactor PartialRenderer#render and log tests Mute subscriber's log instead of disabling instrumentation. Fix typo, remove useless comment and use new hash syntax Improve actionpack's log_subscriber test Fix rebase mistake Apply new config to all caching intstrument actions
* | | | | applies remaining conventions across the projectXavier Noria2016-08-063-10/+8
| | | | |
* | | | | normalizes indentation and whitespace across the projectXavier Noria2016-08-065-179/+179
| | | | |
* | | | | remove redundant curlies from hash argumentsXavier Noria2016-08-061-4/+2
| | | | |
* | | | | modernizes hash syntax in guidesXavier Noria2016-08-065-11/+11
| | | | |
* | | | | applies new string literal convention in guidesXavier Noria2016-08-0615-160/+160
| | | | | | | | | | | | | | | | | | | | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.