| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |/ / / |
|
| | | | |
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | | |
* avoid using unnecessary commas
* fix some typos
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 00aa1afae3821dd858dec7111bcdf230b12040d7, reversing
changes made to b584cc68fc28492147ed3ed127ad8a7441ca8161.
Reason:
As far as we can tell, this should not be the case. Both localhost, 127.0.0.1
and ::1 is "supposed to work", so this is probably a bug somewhere.
Reopening #19815 instead.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Rewording in accordance with the documentation guidelines (‘Prefer
wordings that avoid "you"s and "your”s.’) and to remove in particular
“if you'd call”.
|
|\ \ \
| | | |
| | | | |
Make sure you execute rake rdoc from rails root directory [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
1. Make clear where rake rdoc is executed
2. Make clear where the generated HTML files for the guides are stored
3. Use bundler 1.3.5 or later
|
|\ \ \ \
| | | | |
| | | | | |
Clarify test_order default configuration behaviour [ci skip]
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Explain config.active_support.test_order defaults
to :random in newly-generated applications thanks
to generated config/environments/test.rb, otherwise
default is :sorted (until Rails 5.0).
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Added note about non-GET links getting converted to GET links in mailer Added note about non-GET links getting converted to GET links in mailer templates [ci skip]
|
| |/ / /
| | | |
| | | |
| | | | |
templates [ci skip]
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Rails has different naming conventions for the inverse assertion
methods. While minitest uses `refute` we use `_not`. We should have a
table listing the common assertions that you want to use in the Rails
context.
Refs #18305.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Follow-up to #19672 and 8b0aa0c1.
[ci skip]
|
|\ \ \
| |/ /
|/| | |
More docs on tagged logging [ci skip]
|
| | |
| | |
| | |
| | |
| | | |
Mention that tags can also come from a Proc that accepts the request
object or something's to_s method
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
jonatack/improve-contributing-to-ruby-on-rails-guide
Improve the Contributing to Rails Guide [skip ci]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
First commit:
This PR improves the "4.12 Commit Your Changes" section of the
Contributing to Ruby on Rails Guide:
- Fix formatting of the commit message example
- Improve readability and clarity
- Fix grammar
- Wrap lines
See the before and after images below in this PR.
-----
Second commit:
- Rewrite to remove the word "buffer" [skip ci]
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
According to the guidelines:
http://guides.rubyonrails.org/ruby_on_rails_guides_guidelines.html#headings
References #19821.
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
* includes -> include
* "on your computer" is implied
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This template gives contributors a starting point to use when reporting bugs
that does not involve Active Record or Action Pack.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] Fix docs and guide about 'Array.wrap'
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Update association_basics.md [ci skip]
|
| | | | | | |
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Improve documentation for uuid [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
Add information about usage `uuid` type with `reference`
|
|/ / / / |
|
| | | | |
|
|/ / / |
|
| | |
| | |
| | |
| | | |
* files are written to hard "disk" not "disc".
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is a squash of the following commits, from first to last:
-
Fix minor, random things I’ve come across lately that individually
did not seem worth making a PR for, so I saved them for one commit.
One common error is using “it’s” (which is an abbreviation of “it is”)
when the possessive “its” should be used for indicating possession.
-
Changes include the name of a test, so remove the `[skip ci]` (thanks @senny).
-
Line wrap the changes at 80 chars and add one more doc fix.
-
Add a missing line wrap in the Contributing to Ruby on Rails Guide.
-
Line wrap the `TIP` section in the Contributing to Ruby on Rails Guide as well.
Rendering the guide locally with `bundle exec rake guides:generate` did
not show any change in on-screen formatting after adding the line wrap.
The HTML generated is (extra line added to illustrate where the line
wrap takes place):
<div class="info"><p>Please squash your commits into a single commit
when appropriate. This
simplifies future cherry picks and also keeps the git log
clean.</p></div>
-
Squash commits.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
andersonDadario/fix_security_guide_captcha_03_21_2015
Fix security guide captcha 03 21 2015 [ci skip]
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
- https://github.com/rails/sprockets/commit/14b3b2eddac4699c64c051888e3801732b9a4418
- https://github.com/rails/sprockets/issues/26
|
|\ \ \ \
| |_|_|/
|/| | | |
Upgrade to Ruby 2.2.2
|
| | | |
| | | |
| | | |
| | | | |
and fix the grammar in the ruby_version_check.rb user message.
|
|\ \ \ \ |
|
| | | | | |
|
| | | | | |
|