| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
| |
[ci skip]
|
|\
| |
| | |
Fix cache_timestamp_format default value in guides
|
| | |
|
|/
|
|
| |
Add configuration option to turn off drawing of Active Storage routes.
|
|
|
|
|
|
|
|
|
| |
Assigning to a collection of attachments appends rather than replacing, as in 5.2. Existing 5.2 apps that rely on this behavior will no longer break when they're upgraded to 6.0.
For apps generated on 6.0 or newer, assigning replaces the existing attachments in the collection. #attach should be used to add new attachments to the collection without removing existing ones.
I expect that we'll deprecate the old behavior in 6.1.
Closes #36374.
|
|\
| |
| |
| |
| | |
abhaynikam/36332-fix-engine-documentation-to-remove-js-directory-mention
Fixed the engine documentation to not mention of assets/javascript in directory structure [ci skip]
|
| |
| |
| |
| | |
directory structure [ci skip]
|
| |
| |
| |
| |
| | |
In older Ruby, nil, Symbol, Fixnum, Rational, and Complex were not
duplicable. In Ruby 2.5, all of them are duplicable.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Most of this section was written from the time that render file: was the
default, before CVE-2016-0752.
This updates the guide to the Rails 6 `render file:` behaviour, moves it
to a more appropriate part of the file.
[ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Most of these examples no longer work. The ability to render an absolute
path was removed as part of CVE-2016-0752. In Rails 6 we changed `render
file:` to only take exact paths and always to render them as raw files.
Rendering a template with its extensions _is_ supported, but I don't
think should be recommended.
This also removes `render file:` from an example where it isn't
relevant.
[ci skip]
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
This is a first draft only, needs polishing for final.
|
|/
|
| |
http://code.whytheluckystiff.net is now just a spam site. Use http://gems.github.com as an example instead.
|
| |
|
|
|
|
|
|
| |
The phrasing of this struck we as odd, "To help our CI servers..." So I
feel it would be more useful if we explain more explicitly that ci skip
cuts down on usage by not running CI.
|
|
|
|
|
| |
in multi-db docs [ci skip]
Reads after write should be from the primary database.
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 60e19c6d6cb60159af4e2247f29d2cea375a21d6, reversing
changes made to 72e257b4c935b6829f7d4db36dea61a1682aa44e.
The method signature is different between `create_file` and `template`.
https://www.rubydoc.info/github/erikhuda/thor/master/Thor/Actions#create_file-instance_method
https://www.rubydoc.info/github/erikhuda/thor/master/Thor/Actions#template-instance_method
|
|
|
|
| |
guide [skip ci]
|
| |
|
| |
|
|
|
|
|
| |
https://github.com/vhf/free-programming-books seems to have moved to
https://github.com/EbookFoundation/free-programming-books
|
| |
|
|
|
|
| |
The robots.txt site is moved permanently to https URL.
|
| |
|
|
|
|
|
|
|
|
|
| |
I changed return value of `ActionDispatch::Response#content_type` in #36034.
But this change seems to an obstacle to upgrading. https://github.com/rails/rails/pull/36034#issuecomment-498795893
Therefore, I restored the behavior of `ActionDispatch::Response#content_type`
to 5.2 and deprecated old behavior. Also, made it possible to control the
behavior with the config.
|
|\
| |
| | |
Allow using env var to specify pidfile
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously it was only possible to specify the location of the pidfile
for the 'rails server' command with the '-P' flag. This adds support for
specifying the pidfile using a PIDFILE env var, which can still be
overridden by the '-P' flag and with the default pidfile path unchanged.
The motivation for this feature comes from using Docker to run multiple
instances of the same rails app. When developing a rails app with
Docker, it's common to bind-mount the rails root directory in the
running container, so that changes to files are shared between the
container and the host. However, this doesn't work so well with the
pidfile and it's necessary to (remember to) add a '-P' flag to the
'rails server' command line; being able to specify this flag using an
env var would make developing with Rails+Docker a bit simpler.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
definition
Tests are also only on the `Time` class
Update doc forgetting to erase when moved
Update guide `Date` class to `Time` class and defined file
Update guide correction omission
|
| |
| |
| |
| |
| |
| | |
`content_types_to_serve_as_binary` [ci skip]
Ref: bcf370d689673031073ba2ac5588afe41cc315c9, 06ab7b27ea1c1ab357085439abacdb464f6742bf.
|
| | |
|
|/
|
|
|
|
| |
* Add note about schema cache
* Add note about opening too many connections
* Improve headers in caveats section
|
|\
| |
| | |
images/getting_started: Update screenshot for missing action
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
| |
We sometimes say "✂️ newline after `private`" in a code review (e.g.
https://github.com/rails/rails/pull/18546#discussion_r23188776,
https://github.com/rails/rails/pull/34832#discussion_r244847195).
Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style
`EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059).
That cop and enforced style will reduce the our code review cost.
|
|\
| |
| | |
[ci skip] Fix rails/command.rb document
|
| | |
|
|\ \
| | |
| | | |
Fix installation on guides/source/action_text_overview.md
|
| | |
| | |
| | |
| | | |
gem 'image_proccessing' is required.
|
| | |
| | |
| | | |
We had a bug whereby we changed the namespace on a model using ActiveStorage, which resulted in broken download links. The reason this happened is because the `active_storage_attachments` table is a polymorphic join table that records the model's class name at the time of record creation, and uses this `record_type` in queries. Since the model namespace changed, the queries did not return the blob as expected. Discussed with @rafaelfranca, who suggested adding a warning about this in the docs.
|
| |/
|/|
| |
| | |
class name. [ci skip]
|