| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
[ci skip]
|
|\
| |
| | |
Add Action Mailbox to guides
|
| | |
|
| |
| |
| |
| | |
Now Action Mailbox is responsible for receiving emails.
|
| |
| |
| |
| |
| |
| |
| | |
[ci skip]
I added WIP label to that guide since we definitely
want to complement it.
|
|/
|
|
|
| |
Since e3f832a7433a291a51c5df397dc3dd654c1858cb `ActionMailer::Base.receive` is
deprecated.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Host authentication introduced by #33145 allows only "0.0.0.0/0", "::/0"
and "localhost" in the development environment.
https://github.com/rails/rails/blob/4298df00ae6219b9b5b7c40f281d4fa4d66f4383/railties/lib/rails/application/configuration.rb#L33
But `rack-test` use `example.org` for default host.
https://github.com/rack-test/rack-test/blob/6c07bf53adf4a4082e206561f5b9b43142fdc821/lib/rack/test.rb#L13
Therefore, if `hosts` is not specified, host authentication rejects
the request.
In Travis CI, this problem does not occur because `test` is specified
by default in `RAILS_ENV` and `RACK_ENV`.
https://docs.travis-ci.com/user/environment-variables/#default-environment-variables
If user actually use it, env may not always be specified. Explicitly
specify hosts in the file so that it works in any environment.
|
|
|
|
|
|
|
| |
- Fix a few deprecation warnings
- Remove testing of `Hash#slice`
- Imporve test of `Hash#slice!`
- Remove mention about `Hash#slice` from the guide
|
|
|
|
|
|
|
|
|
|
| |
`Hash#transform_keys!`
Since Rails 6 requires Ruby 2.5.
https://github.com/ruby/ruby/blob/ruby_2_5/NEWS
Follow up #34754.
|
|
|
|
|
|
|
|
|
|
| |
Generally followed the pattern for https://github.com/rails/rails/pull/32034
* Removes needless CI configs for 2.4
* Targets 2.5 in rubocop
* Updates existing CHANGELOG entries for fewer merge conflicts
* Removes Hash#slice extension as that's inlined on Ruby 2.5.
* Removes the need for send on define_method in MethodCallAssertions.
|
|
|
|
|
|
|
| |
Double nesting of configuration is not supported (without using an
intermediate object), even though the docs suggest it is.
[ci-skip]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the machine (#34735)
* Add option to set parallel test worker count to the physical core count of the machine
Also, use the physical core count of the machine as
the default number of workers, and generate the `test_helper.rb` file
with `parallelize(workers: :number_of_processors)`
Closes #34734
* Ensure that we always test parallel testing
Since #34734 we decided to use the physical core count of the machine as
the default number of workers in the parallel testing, we need to
ensure that some tests use at least 2 workers because we could
run those tests on VM that has only 1 physical core.
It also fixes tests failures on the CI since Travis server we are using
has only one physical core.
See https://travis-ci.org/rails/rails/jobs/469281088#L2352
|
|
|
|
|
|
|
|
|
|
|
| |
* Extend documentation of `ActiveSupport::Notifications.subscribe`
Add mention that a block with only one argument passed to the method
will yield an event object.
Related to #33451
* Emphasize that `SubscribeEventObjects` is a test class by adding suffix `Test`
|
|\
| |
| | |
Expand intro to generator in Migrations Guide
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| | |
[ci skip]
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* No need to go through ruby
* Abort early if a generator command fails
* Reuse `rails_command` method
* Bump thor minimum dependency to 0.20.3
* Add some minimal docs
* Add a changelog entry
* Restore original logging
|
| |
| |
| |
| |
| |
| | |
And make sure new applications in Rails 6.0 has this config enabled.
Also, improve test coverage and add a CHANGELOG entry.
|
| |
| |
| |
| | |
Use String for direction of RailsGuides::Generator
|
| |
| |
| |
| | |
[ci skip]
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
- Fix formatting
- Don't repeat "Active Record automatically handles creating and migrating a new
database for each worker to use."
- Tell that AR loads the schema to a database for each process(Related to #33479)
- Clarify that `parallelize_teardown` is executed for each process
|
| | |
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| | |
Delayed Job is mentioned multiple times in the document, but it is not linked from anywhere.
|
| |
| |
| |
| | |
[ci skip]
|
|\ \
| | |
| | | |
Bump the minimum version of PostgreSQL to 9.3
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
https://www.postgresql.org/support/versioning/
- 9.1 EOLed on September 2016.
- 9.2 EOLed on September 2017.
9.3 is also not supported since Nov 8, 2018. https://www.postgresql.org/about/news/1905/
I think it may be a little bit early to drop PostgreSQL 9.3 yet.
* Deprecated `supports_ranges?` since no other databases support range data type
* Add `supports_materialized_views?` to abstract adapter
Materialized views itself is supported by other databases, other connection adapters may support them
* Remove `with_manual_interventions`
It was only necessary for PostgreSQL 9.1 or earlier
* Drop CI against PostgreSQL 9.2
|
| | |
| | |
| | |
| | | |
Caching [ci skip]
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
minimalweb/progressive_jpeg_inclusion_as_variable_content_type
Add progressive JPG MIME-type to default variable content types
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Improve readability by using `direction` as CSS does.
More info: https://developer.mozilla.org/en-US/docs/Web/CSS/direction
Continues: #34486
[Alberto Almagro + Ufuk Kayserilioglu]
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
The output from `rails help` actually leaves an empty space when
printing the command lists. This commit adapts this guide to have the
same format.
|
|\ \ \
| | | |
| | | |
| | | | |
allow right to left styling of docs
|
| | | |
| | | |
| | | |
| | | | |
* adding rtl css main file and logic to use
|
| | | |
| | | |
| | | |
| | | | |
ApplicationJob should be inherits ActiveJob::Base
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
My spellchecker flagged this as an incorrect spelling, upon further
research it appears to be a point of contention in English. Either way
might work.
After further examination queuing is much more common in the Rails
codebase so making this change will serve to standardize the spelling.
|
|/ /
| |
| |
| | |
[ci skip]
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I was puzzled about why `collection=` was destroying the removed
records on an association with `dependent: :destroy`, even after
consulting the documentation for that option. I had to dive into the
Active Record source to understand what was going on: eventually
`collection=` calls `collection.delete` on the ousted records, and it
also uses the `:dependent` option to decide how to remove records.
It would have helped me to have mention of this in the documentation for
`:dependent`, not just under `collection.delete` (which I found much
later).
Briefly mention the broader impacts of `:dependent` in the Association
Basics guide.
[ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit adds support for the
`ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.create_unlogged_tables`
setting, which turns `CREATE TABLE` SQL statements into
`CREATE UNLOGGED TABLE` statements.
This can improve PostgreSQL performance but at the
cost of data durability, and thus it is highly recommended
that you *DO NOT* enable this in a production environment.
|
| |
| |
| |
| |
| |
| |
| | |
albertoalmagro/use-assert-not-instead-of-refute"
This reverts commit ab5d5c95ec51c63d58d7e75694af748f165e2228, reversing
changes made to ef4f5ef69b5a50c897bbb17f6b36b729dff12e6c.
|
| |
| |
| |
| |
| |
| |
| |
| | |
As mentioned in the contributing to Ruby on Rails guides,
we should prefer `assert_not` instead of `refute`. And the
best place to start giving example are our bug report templates..
See: https://github.com/rails/rails/blame/master/guides/source/contributing_to_ruby_on_rails.md#L256
|
|\ \
| | |
| | |
| | |
| | | |
Fix typo for Action Cable Overview doc
[Eileen M. Uchitelle]
|
| | |
| | |
| | |
| | | |
[ci skip]
|
|\ \ \
| | | |
| | | | |
Clarify the validation of present associations
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I think that it is not clear what means that _an association is
present_. Add that it is checking that the foreign key is not empty and
that the referenced object exists to clarify it.
|