| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
- Right now master is 5.0.0. Latest gem release is 4.2.0 for which we
are accepting bug reports. So lets use it in bug report templates.
- 5.0.0 is not installable as it's not available on Rubygems yet. So the
gem bug templates are not usable without editing the version. Using
4.2.0 will make them usable again.
|
|\
| |
| |
| |
| |
| |
| | |
Introduce explicit way of halting callback chains by throwing :abort. Deprecate current implicit behavior of halting callback chains by returning `false` in apps ported to Rails 5.0. Completely remove that behavior in brand new Rails 5.0 apps.
Conflicts:
railties/CHANGELOG.md
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This stems from [a comment](rails#17227 (comment)) by @dhh.
In summary:
* New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning.
* Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning.
For this purpose, this commit introduces a Rails configuration option:
```ruby
config.active_support.halt_callback_chains_on_return_false
```
For new Rails 5.0 apps, this option will be set to `false` by a new initializer
`config/initializers/callback_terminator.rb`:
```ruby
Rails.application.config.active_support.halt_callback_chains_on_return_false = false
```
For existing apps ported to Rails 5.0, the initializers above will not exist.
Even running `rake rails:update` will not create this initializer.
Since the default value of `halt_callback_chains_on_return_false` is set to
`true`, these apps will still accept `return true` as a way to halt callback
chains, displaying a deprecation warning.
Developers will be able to switch to the new behavior (and stop the warning)
by manually adding the line above to their `config/application.rb`.
A gist with the suggested release notes to add to Rails 5.0 after this
commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Commit 1aea470 introduced this directory but this was at a time when the
default way to store sessions was on the file system under the tmp
directory.
Let's remove references to it from the documentation as well.
[Robin Dupret & yui-knk]
|
|\ \ |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Commit 65a2977 added a `pre-wrap` style for white spaces on `.note`
paragraphs. However, this is first inconsistent as other notes like
warnings don't have this style applied. Furthermore, it seems to be
unneeded for mobile devices.
Also revert changes made in #18147 since they aren't needed anymore.
Cross-refs #18138.
[ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | | |
To highlight ERB snippets, both `erb` and `html+erb` are used as a
language passed to the code block. However, only the former will be
correctly highlighted.
|
| |/
|/| |
|
| |
| |
| |
| |
| | |
`MissingSourceFile` was just an alias to `LoadError` and was not
being raised inside the framework.
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Make possible to use blocks with short version of render partial
Conflicts:
actionview/CHANGELOG.md
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Fix spell life cycle on activejob docs [ci skip]
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
RoutingAssertions. [ci skip]
|
| | | |
| | | |
| | | |
| | | | |
after views. [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
functional testing section and implement :show, :destroy, and :update tests.
[ci skip]
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
in the Action Dispatch Integration module. [ci skip]
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
It makes more sense here, rather than after explaining all of the testing
facilities of Rails. [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
82b75eda70f8c30f7c418e7350532a3a0ed2a8c3
Also explain how Rails inherits capabilities from Minitest. Test classes should
be roughly the same based on this information, we can address them at a high
level when introducing the first test case. [ci skip]
|
| | | |
| | | |
| | | |
| | | | |
assertions are introduced. [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
existing example. [ci skip]
My reasoning is that this is probably too much information for the complete
Rails testing guide, as we're trying to cover testing all aspects of the
framework.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
use-cases.
Briefly explain difference between Functional and Request type tests. [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This config setting has been available for quite a while but was not
documented.
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | | |
The single line was long enough that it rendered on two lines,
causing the example to look like syntactically invalid code.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Arguments of Bundler.require of generator has been changed from rails4.0.4.
https://github.com/rails/rails/blob/v4.0.4/railties/lib/rails/generators/rails/app/templates/config/application.rb#L16
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|