| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
| |
Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead.
Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR.
Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead.
The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`.
Paired @sgrif & @schneems
|
| | |
|
| | |
|
| |\
| |
| | |
adding indexes on tables in migration scripts [ci skip]
|
| | |
| |
| |
| |
| |
| |
| |
| | |
missed one migration script in last commit
remove some empty lines
using the belongs_to index option to be more concise
|
| |\ \
| | |
| | | |
[ci skip]Add i18n master to the Gemfile
|
| | | | |
|
| |\ \ \
| |/ /
|/| | |
Calling require_self twice in css raises Sprockets::ArgumentError exception [ci skip]
|
| | |/
| |
| |
| | |
[ci skip]
|
| |\ \
| |/
|/| |
`create` method returns an active record object with errors instead of false when validation fails. [skip ci]
|
| | |
| |
| |
| | |
validation fails. [skip ci]
|
| | | |
|
| | |
| |
| |
| | |
[ci skip]
|
| | | |
|
| |/ |
|
| |
|
|
|
|
|
|
| |
Even if this is not exactly the same, let's add a new-line character
instead of two spaces. While it's specified in the Markdown specs that
adding spaces at the end of the line creates a break-line tag, this is
a brittle approach as people may remove them saving the file on certain
editors.
|
| |
|
|
| |
The profiling and benchmarking commands are no longer built into Rails.
|
| | |
|
| |
|
|
| |
in testing guide.
|
| |\
| |
| | |
Improve Active Model Dirty API.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
These methods may cause confusion with the `reset_changes` that
behaves differently
of them.
Also rename undo_changes to restore_changes to match this new set of
methods.
|
| |/
|
|
| |
Also updated the test case to reflect that
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Leave two blank lines between sections/packages for readibility.
* Always indent bullet points with four spaces. This allows multi-paragraph
points to align properly (see #16103), and it is the same as the format we
already use in CHANGELOGs. Doing this consistently sets an easy precedent
for future contributors to follow.
* Always put the PR/commit link on its own line in the source. If the bullet
point spans multiple paragraphs, put it on its own paragraph at the end.
[Godfrey Chan & Juanito Fatas]
|
| | |
|
| |\
| |
| |
| |
| | |
Conflicts:
activerecord/lib/active_record/base.rb
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
This reverts commit 0f6b101e09d210cea2494c5d4225760f1951ea67.
Reason: It's better to let `unscope` be documented. We can add a
separate section for `except`.
|
| | | |
|
| | |
| |
| |
| | |
The example showed is `except`, however the method "documented" is `unstop`. Fix to align the docs to the example.
|
| | |
| |
| |
| | |
Also use appropriate mailer syntax in the `find_each` block.
|
| | |
| |
| |
| | |
Put all options for overloading `find` in one section
|
| | |
| |
| |
| |
| |
| | |
Add docs on what happens when a numerical argument is provided to last.
Since `last!` behaves exactly the same way but can raise an argument we can consolidate it in the `last` section.
|
| | |
| |
| |
| |
| |
| | |
Add docs on what happens when a numerical argument is provided to take.
Since `take!` behaves exactly the same way but can raise an argument we can consolidate it in the `take` section.
|
| | |
| |
| |
| | |
Since `find_by!` behaves exactly the same way but can raise an argument we can consolidate it in the `find_by` section.
|
| | |
| |
| |
| |
| |
| | |
Add docs for `first` when provided a numerical argument.
Since `first!` behaves exactly the same way but can raise an argument we can consolidate it in the `first` section.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
Also reordered some of the items to put newer ones on top (same order as
CHANGELOGs), which makes it easier to diff while we are still working on it.
|
| | | |
|
| | |
| |
| |
| | |
ActiveSupport::TimeWithZone#as_json
|
| | | |
|
| | | |
|
| |\ \
| | |
| | | |
correct markdown usage [ci skip]
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Add callbacks documentation for upgrading to 4.1.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The previous code example for the new explicit block requirement when
setting callbacks was a little confusing. This commit makes the example
more obvious.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It is now expected in 4.1 to use an explicit block rather than implicit
when setting callbacks through ActiveSupport::Callbacks. This commit
highlights this new expectation as part of the upgrading documentation.
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As discussed in #15304, we need to automate this process but for now,
having out-of-date versions is not ideal.
Since master targets 4.2.0, let's also update references to the last 4.1
version to 4.2.0.
Finally, let's remove mentions to versions when this is not needed. The
guides cover the features of the current version anyway.
[Juanito Fatas + Robin Dupret]
|
| |\ \ \
| | | |
| | | | |
[ci skip] add guide for ActiveModel::Naming
|
| | | | | |
|
