aboutsummaryrefslogtreecommitdiffstats
path: root/guides
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #12203 from chancancode/eager_load_jsonJeremy Kemper2013-10-301-4/+2
|\ | | | | Eagerload active_support/json/encoding in active_support/core_ext/object/to_json
| * Moved all JSON core extensions into core_ext/object/jsonGodfrey Chan2013-09-131-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | TL;DR The primary driver is to remove autoload surprise. This is related to #12106. (The root cause for that ticket is that json/add defines Regexp#to_json among others, but here I'll reproduce the problem without json/add.) Before: >> require 'active_support/core_ext/to_json' => true >> //.as_json NoMethodError: undefined method `as_json' for //:Regexp from (irb):3 from /Users/godfrey/.rvm/rubies/ruby-2.0.0-p195/bin/irb:16:in `<main>' >> //.to_json => "\"(?-mix:)\"" >> //.as_json => "(?-mix:)" After: >> require 'active_support/core_ext/to_json' => true >> //.as_json => "(?-mix:)" This is because ActiveSupport::JSON is autoloaded the first time Object#to_json is called, which causes additional core extentions (previously defined in active_support/json/encoding.rb) to be loaded. When someone require 'active_support/core_ext', the expectation is that it would add certain methods to the core classes NOW. The previous behaviour causes additional methods to be loaded the first time you call `to_json`, which could cause nasty surprises and other unplesant side-effects. This change moves all core extensions in to core_ext/json. AS::JSON is still autoloaded on first #to_json call, but since it nolonger include the core extensions, it should address the aforementioned bug. *Requiring core_ext/object/to_json now causes a deprecation warnning*
* | Update pull request instructions as per the new Github UIAlex Johnson2013-10-301-7/+12
| | | | | | | | [ci skip]
* | Revert "add active model basics wip to guides/documents.yaml"Xavier Noria2013-10-291-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | Reason: WIP guides are not in the index because they are partial work pushed to the repo. Either there is someone working on them or else the work was interrupted. Guides are added to the index page when they are finished, the author considers the draft to be complete, someone reviews them, and overall they are considered to be good for users to read. This reverts commit eefc03a8069bddfe31751c4bd4fb1804e7f33c2c.
* | Merge pull request #11564 from zzak/active_model_guideYves Senn2013-10-281-0/+6
|\ \ | | | | | | [Guides] Active Model Basics [ci skip]
| * | add active model basics wip to guides/documents.yamlZachary Scott2013-07-221-0/+6
| | |
* | | Merge pull request #12578 from ↵Rafael Mendonça França2013-10-271-0/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | jeradphelps/configurable_schema_migrations_table_name Configurable name for schema_migrations table Conflicts: activerecord/CHANGELOG.md
| * | | added schema_migrations_table_name to ActiveRecord::Base in order that the ↵Jerad Phelps2013-10-271-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | name of the schema migrations table can be configured. consolidated test_schema_migrations_table_name tests Added changelog entry edited changelog removed commented lines removed reader ensure the schema migrations table is reset at end of test added entry to configuration guide guides typo and changelog order
* | | | [ci skip] second parameter of asset-url is depricatedEvgeniy2013-10-231-4/+3
| | | |
* | | | Update docs on Tilt::Template in Asset Pipeline guideDavid Verhasselt2013-10-211-3/+8
|/ / /
* | | Merge pull request #12218 from dv/add-sass-globbing-to-asset-pipeline-docsYves Senn2013-10-171-1/+5
|\ \ \ | | | | | | | | Add sass globbing to asset pipeline docs [ci skip]
| * | | Add Sass gobbling info to asset pipeline docsDavid Verhasselt2013-10-171-1/+5
| | |/ | |/| | | | | | | [ci skip]
* | | [ci skip] Fix number of methods added by association.Juanito Fatas2013-10-171-8/+8
| | | | | | | | | | | | Also clean up some trailing spaces on line 1143-1146.
* | | Merge pull request #12545 from nateberkopec/rephrase_callback_warningYves Senn2013-10-161-1/+1
|\ \ \ | | | | | | | | Rephrase ActiveRecord transaction rollback warning [ci skip]
| * | | Rephrase ActiveRecord transaction rollback warningNate Berkopec2013-10-161-1/+1
| | | | | | | | | | | | | | | | [ci skip]
* | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2013-10-151-1/+1
|\ \ \ \ | |/ / / |/| | |
| * | | Use ActiveRecord::Base#update! instead of #update_attributes!Zachary Scott2013-09-281-1/+1
| | | |
* | | | Remove size alias for length validationSıtkı Bağdat2013-10-141-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removed ```The `size` helper is an alias for `length`.``` line. If you use this "nonexist" helper, you will get an error message like this: ``` ArgumentError: Unknown validator: 'SizeValidator' ... ``` Maybe wanted to mean ```validates_size_of``` helper as an alias for ```validates_length_of``` helper.
* | | | Merge pull request #12493 from drodriguez/patch-1Rafael Mendonça França2013-10-131-2/+2
|\ \ \ \ | | | | | | | | | | Keep code consistent with previous code blocks.
| * | | | Keep code consistent with previous code blocks.Daniel Rodríguez Troitiño2013-10-101-2/+2
| | | | | | | | | | | | | | | [ci skip]
* | | | | Merge pull request #12507 from malavbhavsar/doc_patchRafael Mendonça França2013-10-122-2/+2
|\ \ \ \ \ | | | | | | | | | | | | Some fixes in docs [ci skip]
| * | | | | Some fixes in docs [ci skip]Malav Bhavsar2013-10-112-2/+2
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | Update a link to point to right section in api docs Fix a typo
* | | | | Fix a writing mistakeSıtkı Bağdat2013-10-121-1/+1
| | | | | | | | | | | | | | | A small mistake found in the line of ```The default error is "can't be empty"``` for ```:presence``` helper. ```empty``` word changed to ```blank```.
* | | | | Revert "Merge pull request #12480 from iwiznia/master"Jeremy Kemper2013-10-111-15/+0
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e5f5a838b96a362534d9bb60d02334439ed9784c, reversing changes made to d7567f3290a50952494e9213556a1f283a6cf3a0.
* | | | | flatten and flatten! methods for ActiveSupport::DurationIonatan Wiznia2013-10-111-0/+15
|/ / / /
* | | | Modifies the initialization guide to make the initializers process clearer ↵Cory Foy2013-10-091-6/+16
| | | | | | | | | | | | | | | | and remove a TODO. [ci skip]
* | | | [Validations Guide] Add full stop to the end of sentence [ci skip]Francis Go2013-10-101-1/+1
| | | |
* | | | Added ActionView in rake about [ci skip]Arun Agrawal2013-10-091-5/+6
| | | |
* | | | Minor align BR tags with HTML void - with reference to the generators code ↵AvnerCohen2013-10-092-2/+2
| | | | | | | | | | | | | | | | change - https://github.com/rails/rails/commit/f038d4cc5fe1ac21f92c7e32c61ff85a0c816f3f
* | | | Merge pull request #12283 from JuanitoFatas/rails-on-rackYves Senn2013-10-091-1/+5
|\ \ \ \ | | | | | | | | | | [ci skip] Add explanation on Rack::Sendfile middleware in rails_on_rack.md.
| * | | | [ci skip] Add explanation on Rack::Sendfile and fix serve static files setting.Juanito Fatas2013-10-041-1/+5
| | | | |
* | | | | Call `rails plugin new yaffle` in the plugins guide. [ci skip]Ulysse Carion2013-10-081-3/+9
| | | | | | | | | | | | | | | | | | | | It's confusing to not explicitly do this step.
* | | | | Fix a typo in the code of Testing guide.Geoffrey Roguelon2013-10-031-1/+1
| | | | | | | | | | | | | | | | | | | | Replace the word «Accepts» by «Accept» in the example of custom request headers.
* | | | | copy-edits the new guide with our maintenance policy [ci skip]Xavier Noria2013-10-031-14/+11
| | | | |
* | | | | Adds the Rails maintenance policy to the GuidesMatias Korhonen2013-10-033-0/+70
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | guides: configuring: fixing explanation of :after_initialize hookSebastian Gassner2013-10-011-1/+1
| | | | | | | | | | | | | | | | | | | | :after_initialize runs after config/initializers, not before
* | | | | fixes incorrect spelling of `action_on_unpermitted_parameters`Jared Beck2013-09-281-1/+1
| | | | | | | | | | | | | | | | | | | | See `actionpack/test/controller/parameters/raise_on_unpermitted_params_test.rb`
* | | | | Merge pull request #12387 from francisgo/patch-9Rafael Mendonça França2013-09-281-14/+14
|\ \ \ \ \ | |_|/ / / |/| | | | Migrations Guide: Add semicolon to sentences before code block [ci skip]
| * | | | Migrations Guide: Add semicolon to sentences before code block [ci skip]Francis Go2013-09-281-14/+14
| | | | |
* | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2013-09-287-55/+24
|\ \ \ \ \
| * | | | | Added missing active record configurations.wangjohn2013-09-251-0/+6
| | | | | |
| * | | | | use active voice and use more descriptive termsWeston Platter2013-09-221-1/+1
| | | | | |
| * | | | | Fix Show link on resourceVipul A M2013-09-171-1/+1
| | | | | |
| * | | | | incorrect urlSergio2013-09-161-1/+1
| | | | | | | | | | | | | | | | | | incorrect url
| * | | | | incorrect urls Sergio2013-09-161-2/+2
| | | | | | | | | | | | | | | | | | I've found two incorrects urls for adding ':' at the end of the url
| * | | | | surplus : in attachment_fu pluginSergio2013-09-151-1/+1
| | | | | | | | | | | | | | | | | | surplus ':' character in url
| * | | | | EncryptedCookieStore => CookieStore [ci skip]Rashmi Yadav2013-09-131-1/+1
| | | | | |
| * | | | | asset_url => asset-url in sass-rails docs [ci skip]Rashmi Yadav2013-09-131-1/+1
| | | | | |
| * | | | | Removed doc of diff method [ci skip]Rashmi Yadav2013-09-131-38/+0
| | | | | |
| * | | | | Updated guides with latest method [ci skip]Rashmi Yadav2013-09-131-2/+2
| | | | | |