aboutsummaryrefslogtreecommitdiffstats
path: root/guides
Commit message (Collapse)AuthorAgeFilesLines
* Preserve existing attachment assignment behavior for upgraded appsGeorge Claghorn2019-07-203-5/+58
| | | | | | | | | Assigning to a collection of attachments appends rather than replacing, as in 5.2. Existing 5.2 apps that rely on this behavior will no longer break when they're upgraded to 6.0. For apps generated on 6.0 or newer, assigning replaces the existing attachments in the collection. #attach should be used to add new attachments to the collection without removing existing ones. I expect that we'll deprecate the old behavior in 6.1. Closes #36374.
* Merge pull request #36635 from ↵Kasper Timm Hansen2019-07-171-1/+1
|\ | | | | | | | | abhaynikam/36332-fix-engine-documentation-to-remove-js-directory-mention Fixed the engine documentation to not mention of assets/javascript in directory structure [ci skip]
| * Fixed the engine documentation to not mention of assets/javascripts in app ↵Abhay Nikam2019-07-091-1/+1
| | | | | | | | directory structure [ci skip]
* | Remove caveat for older Ruby's `dup` behavior [ci skip]Ryuta Kamizono2019-07-161-9/+0
| | | | | | | | | | In older Ruby, nil, Symbol, Fixnum, Rational, and Complex were not duplicable. In Ruby 2.5, all of them are duplicable.
* | Delete mention of Ruby 1.9 [skip ci]soartec-lab2019-07-151-4/+0
| |
* | Update guide for render file:John Hawthorn2019-07-131-19/+17
| | | | | | | | | | | | | | | | | | | | Most of this section was written from the time that render file: was the default, before CVE-2016-0752. This updates the guide to the Rails 6 `render file:` behaviour, moves it to a more appropriate part of the file. [ci skip]
* | Remove obsolete or discouraged render examplesJohn Hawthorn2019-07-131-9/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Most of these examples no longer work. The ability to render an absolute path was removed as part of CVE-2016-0752. In Rails 6 we changed `render file:` to only take exact paths and always to render them as raw files. Rendering a template with its extensions _is_ supported, but I don't think should be recommended. This also removes `render file:` from an example where it isn't relevant. [ci skip]
* | let the upgrading guide point to the autoloading guide for STIs [skip ci]Xavier Noria2019-07-131-14/+1
| |
* | simplifies Zeitwerk compat instructions in upgrading guide [skip ci]Xavier Noria2019-07-121-35/+5
| |
* | ports edits to the upgrading guide [skip ci]Xavier Noria2019-07-121-0/+23
| |
* | minor edit [skip ci]Xavier Noria2019-07-111-1/+1
| |
* | completes first version of the new autoloading guide [skip ci]Xavier Noria2019-07-111-14/+78
| |
* | fixes link [skip ci]Xavier Noria2019-07-101-1/+1
| |
* | fixes link [skip ci]Xavier Noria2019-07-101-1/+1
| |
* | updates the guides table of contents [skip ci]Xavier Noria2019-07-091-2/+6
| |
* | renames and revises the autoloading guide for classic mode [skip ci]Xavier Noria2019-07-091-0/+1351
| |
* | autoloading guide revamped for Zeitwerk mode [skip ci]Xavier Noria2019-07-091-1254/+108
| | | | | | | | This is a first draft only, needs polishing for final.
* | update example url for add_sourceultrawebmarketing2019-07-081-2/+2
|/ | | http://code.whytheluckystiff.net is now just a spam site. Use http://gems.github.com as an example instead.
* Fix a typo by removing extra article [ci skip]jacobherrington2019-07-041-1/+1
|
* Update docs regarding skipping CI tests [ci skip]jacobherrington2019-07-031-1/+1
| | | | | | The phrasing of this struck we as odd, "To help our CI servers..." So I feel it would be more useful if we explain more explicitly that ci skip cuts down on usage by not running CI.
* Replace replica with primary in automatic connection switching after write ↵tr4b4nt2019-07-021-1/+1
| | | | | in multi-db docs [ci skip] Reads after write should be from the primary database.
* Revert "Merge pull request #36582 from f1337/master"Ryuta Kamizono2019-07-021-2/+2
| | | | | | | | | | This reverts commit 60e19c6d6cb60159af4e2247f29d2cea375a21d6, reversing changes made to 72e257b4c935b6829f7d4db36dea61a1682aa44e. The method signature is different between `create_file` and `template`. https://www.rubydoc.info/github/erikhuda/thor/master/Thor/Actions#create_file-instance_method https://www.rubydoc.info/github/erikhuda/thor/master/Thor/Actions#template-instance_method
* use 'template' instead of 'create_file' for erb templates in generators ↵Michael R Fleet2019-07-011-2/+2
| | | | guide [skip ci]
* adds two sections to the upgrading notes for autoloading [skip ci]Xavier Noria2019-06-301-0/+16
|
* Link to top of PR as well as other links [ci skip]yuuji.yaginuma2019-06-291-1/+1
|
* [ci skip] Update free-programming-books link in getting started guideMasayuki Morita2019-06-261-1/+1
| | | | | https://github.com/vhf/free-programming-books seems to have moved to https://github.com/EbookFoundation/free-programming-books
* [ci skip] Refer actionmailbox and actiontext in the guidedineshpanda2019-06-261-0/+4
|
* Replace the www.robotstxt.org URL with https one [ci skip]Tatsuya Hoshino2019-06-251-1/+1
| | | | The robots.txt site is moved permanently to https URL.
* Update link to OWASP XSS cheat sheet [ci skip]Aaron Suarez2019-06-231-1/+1
|
* Make `ActionDispatch::Response#content_type` behavior configurableyuuji.yaginuma2019-06-211-0/+5
| | | | | | | | | I changed return value of `ActionDispatch::Response#content_type` in #36034. But this change seems to an obstacle to upgrading. https://github.com/rails/rails/pull/36034#issuecomment-498795893 Therefore, I restored the behavior of `ActionDispatch::Response#content_type` to 5.2 and deprecated old behavior. Also, made it possible to control the behavior with the config.
* Merge pull request #36486 from benthorner/masterYuji Yaginuma2019-06-201-1/+1
|\ | | | | Allow using env var to specify pidfile
| * Allow using env var to specify pidfileBen Thorner2019-06-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously it was only possible to specify the location of the pidfile for the 'rails server' command with the '-P' flag. This adds support for specifying the pidfile using a PIDFILE env var, which can still be overridden by the '-P' flag and with the default pidfile path unchanged. The motivation for this feature comes from using Docker to run multiple instances of the same rails app. When developing a rails app with Docker, it's common to bind-mount the rails root directory in the running container, so that changes to files are shared between the container and the host. However, this doesn't work so well with the pidfile and it's necessary to (remember to) add a '-P' flag to the 'rails server' command line; being able to specify this flag using an env var would make developing with Rails+Docker a bit simpler.
* | Fix typo initialzer -> initializer [ci skip]Abhay Nikam2019-06-171-1/+1
| |
* | Delete `DateAndTime` method definition in rails that is compatible with ruby ↵soartec-lab2019-06-161-22/+22
| | | | | | | | | | | | | | | | | | | | | | | | definition Tests are also only on the `Time` class Update doc forgetting to erase when moved Update guide `Date` class to `Time` class and defined file Update guide correction omission
* | Update default value of `variable_content_types` and ↵yuuji.yaginuma2019-06-161-2/+2
| | | | | | | | | | | | `content_types_to_serve_as_binary` [ci skip] Ref: bcf370d689673031073ba2ac5588afe41cc315c9, 06ab7b27ea1c1ab357085439abacdb464f6742bf.
* | Delete 'ruby' in the description of the method defined in rails [skip ci]soartec-lab2019-06-161-3/+3
| |
* | Update multi-db docseileencodes2019-06-141-1/+20
|/ | | | | | * Add note about schema cache * Add note about opening too many connections * Improve headers in caveats section
* Merge pull request #36466 from wbnns/update-missing-create-action-screenshotRafael França2019-06-131-0/+0
|\ | | | | images/getting_started: Update screenshot for missing action
| * [ci skip] images/getting_started: Update screenshot for missing actionWill Binns2019-06-121-0/+0
| |
* | Enable `Layout/EmptyLinesAroundAccessModifier` copRyuta Kamizono2019-06-134-4/+0
|/ | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.
* Merge pull request #36452 from kojoma/kojoma/update_guidesKasper Timm Hansen2019-06-101-2/+2
|\ | | | | [ci skip] Fix rails/command.rb document
| * [ci skip] Fix rails/command.rb documentkojoma2019-06-101-2/+2
| |
* | Merge pull request #36117 from shioimm/fix_action_text_overviewYuji Yaginuma2019-06-091-0/+2
|\ \ | | | | | | Fix installation on guides/source/action_text_overview.md
| * | Fix installation on guides/source/action_text_overview.mdMisaki Shioi2019-06-081-0/+2
| | | | | | | | | | | | gem 'image_proccessing' is required.
* | | Include warning in docs about polymorphism in underlying tablesAlex Gomez2019-06-061-0/+2
| | | | | | | | | We had a bug whereby we changed the namespace on a model using ActiveStorage, which resulted in broken download links. The reason this happened is because the `active_storage_attachments` table is a polymorphic join table that records the model's class name at the time of record creation, and uses this `record_type` in queries. Since the model namespace changed, the queries did not return the blob as expected. Discussed with @rafaelfranca, who suggested adding a warning about this in the docs.
* | | Fixed a couple of typos, word 'deliberately' and database_resolver_context ↵Akshay Mohite2019-06-061-4/+4
| |/ |/| | | | | class name. [ci skip]
* | Fix period positionRyuta Kamizono2019-06-064-5/+5
| |
* | 6.0 release notes: fix typoPete Nicholls2019-06-051-1/+1
| | | | | | An unfinished parenthetical.
* | Specify a config name from `config` as well as other configs [ci skip]yuuji.yaginuma2019-06-051-1/+1
| |
* | Merge pull request #36376 from sharang-d/reword-content_type-changeVipul A M2019-06-051-4/+4
|\ \ | | | | | | Reword the ActionDispatch::Response#content_type change [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 13:12:36 +0000