aboutsummaryrefslogtreecommitdiffstats
path: root/guides
Commit message (Collapse)AuthorAgeFilesLines
* Make `ActionDispatch::Response#content_type` behavior configurableyuuji.yaginuma2019-06-211-0/+5
| | | | | | | | | I changed return value of `ActionDispatch::Response#content_type` in #36034. But this change seems to an obstacle to upgrading. https://github.com/rails/rails/pull/36034#issuecomment-498795893 Therefore, I restored the behavior of `ActionDispatch::Response#content_type` to 5.2 and deprecated old behavior. Also, made it possible to control the behavior with the config.
* Merge pull request #36486 from benthorner/masterYuji Yaginuma2019-06-201-1/+1
|\ | | | | Allow using env var to specify pidfile
| * Allow using env var to specify pidfileBen Thorner2019-06-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously it was only possible to specify the location of the pidfile for the 'rails server' command with the '-P' flag. This adds support for specifying the pidfile using a PIDFILE env var, which can still be overridden by the '-P' flag and with the default pidfile path unchanged. The motivation for this feature comes from using Docker to run multiple instances of the same rails app. When developing a rails app with Docker, it's common to bind-mount the rails root directory in the running container, so that changes to files are shared between the container and the host. However, this doesn't work so well with the pidfile and it's necessary to (remember to) add a '-P' flag to the 'rails server' command line; being able to specify this flag using an env var would make developing with Rails+Docker a bit simpler.
* | Fix typo initialzer -> initializer [ci skip]Abhay Nikam2019-06-171-1/+1
| |
* | Delete `DateAndTime` method definition in rails that is compatible with ruby ↵soartec-lab2019-06-161-22/+22
| | | | | | | | | | | | | | | | | | | | | | | | definition Tests are also only on the `Time` class Update doc forgetting to erase when moved Update guide `Date` class to `Time` class and defined file Update guide correction omission
* | Update default value of `variable_content_types` and ↵yuuji.yaginuma2019-06-161-2/+2
| | | | | | | | | | | | `content_types_to_serve_as_binary` [ci skip] Ref: bcf370d689673031073ba2ac5588afe41cc315c9, 06ab7b27ea1c1ab357085439abacdb464f6742bf.
* | Delete 'ruby' in the description of the method defined in rails [skip ci]soartec-lab2019-06-161-3/+3
| |
* | Update multi-db docseileencodes2019-06-141-1/+20
|/ | | | | | * Add note about schema cache * Add note about opening too many connections * Improve headers in caveats section
* Merge pull request #36466 from wbnns/update-missing-create-action-screenshotRafael França2019-06-131-0/+0
|\ | | | | images/getting_started: Update screenshot for missing action
| * [ci skip] images/getting_started: Update screenshot for missing actionWill Binns2019-06-121-0/+0
| |
* | Enable `Layout/EmptyLinesAroundAccessModifier` copRyuta Kamizono2019-06-134-4/+0
|/ | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.
* Merge pull request #36452 from kojoma/kojoma/update_guidesKasper Timm Hansen2019-06-101-2/+2
|\ | | | | [ci skip] Fix rails/command.rb document
| * [ci skip] Fix rails/command.rb documentkojoma2019-06-101-2/+2
| |
* | Merge pull request #36117 from shioimm/fix_action_text_overviewYuji Yaginuma2019-06-091-0/+2
|\ \ | | | | | | Fix installation on guides/source/action_text_overview.md
| * | Fix installation on guides/source/action_text_overview.mdMisaki Shioi2019-06-081-0/+2
| | | | | | | | | | | | gem 'image_proccessing' is required.
* | | Include warning in docs about polymorphism in underlying tablesAlex Gomez2019-06-061-0/+2
| | | | | | | | | We had a bug whereby we changed the namespace on a model using ActiveStorage, which resulted in broken download links. The reason this happened is because the `active_storage_attachments` table is a polymorphic join table that records the model's class name at the time of record creation, and uses this `record_type` in queries. Since the model namespace changed, the queries did not return the blob as expected. Discussed with @rafaelfranca, who suggested adding a warning about this in the docs.
* | | Fixed a couple of typos, word 'deliberately' and database_resolver_context ↵Akshay Mohite2019-06-061-4/+4
| |/ |/| | | | | class name. [ci skip]
* | Fix period positionRyuta Kamizono2019-06-064-5/+5
| |
* | 6.0 release notes: fix typoPete Nicholls2019-06-051-1/+1
| | | | | | An unfinished parenthetical.
* | Specify a config name from `config` as well as other configs [ci skip]yuuji.yaginuma2019-06-051-1/+1
| |
* | Merge pull request #36376 from sharang-d/reword-content_type-changeVipul A M2019-06-051-4/+4
|\ \ | | | | | | Reword the ActionDispatch::Response#content_type change [ci skip]
| * | Reword the ActionDispatch::Response#content_type change [ci skip]Sharang Dashputre2019-06-021-4/+4
| | |
* | | Fix typo in multi database guide depentent -> dependent [ci skip]Abhay Nikam2019-06-041-2/+2
| | | | | | | | | | | | Fixed the redundant addition of to [ci skip]
* | | Document multiple databases in Railseileencodes2019-06-042-0/+274
|/ / | | | | | | | | This file documents how to use multiple databases, what features are supported, what features are coming soon, and caveats.
* | Change `ActionDispatch::Response#content_type` returning Content-Type header ↵yuuji.yaginuma2019-06-013-1/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as it is Since #35709, `Response#conten_type` returns only MIME type correctly. It is a documented behavior that this method only returns MIME type, so this change seems appropriate. https://github.com/rails/rails/blob/39de7fac0507070e3c5f8b33fbad6fced84d97ed/actionpack/lib/action_dispatch/http/response.rb#L245-L249 But unfortunately, some users expect this method to return all Content-Type that does not contain charset. This seems to be breaking changes. We can change this behavior with the deprecate cycle. But, in that case, a method needs that include Content-Type with additional parameters. And that method name is probably the `content_type` seems to properly. So I changed the new behavior to more appropriate `media_type` method. And `Response#content_type` changed (as the method name) to return Content-Type header as it is. Fixes #35709. [Rafael Mendonça França & Yuuji Yaginuma ]
* | Merge pull request #36077 from st0012/update-doc-for-pluckPrem Sichanugrist2019-05-291-0/+15
|\ \ | | | | | | Add a section to introduce pluck's eager loading behavior [ci skip]
| * | Add a section to introduce `pluck`'s eager loading behaviorst00122019-05-031-0/+15
| | |
* | | Merge pull request #36348 from corprew/docs-stringify-keys-stable-resultRyuta Kamizono2019-05-281-8/+4
|\ \ \ | | | | | | | | | | | | [documentation][ci skip] stringify_keys and symbolize_keys have stable results.
| * | | stringify_keys and symbolize_keys have stable results.Corprew Reed2019-05-271-8/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails 6 uses the `Hash.transform_keys` found in Ruby 2.5 and later, and that method enumerates keys based on insertion order. Calling `symbolize_keys`, `stringify_keys`, and their bang variants will result in the same hash every time -- the value for any key where a collision occurs is the last assigned in that enumeration In the docs for Hash -- https://ruby-doc.org/core-2.5.0/Hash.html > Hashes enumerate their values in the order that the corresponding keys were inserted.
* | | | changes 'Week day' to 'day of week'Corprew Reed2019-05-271-1/+1
|/ / / | | | | | | | | | | | | 'Week day' has a specific meaning in English -- see https://en.wiktionary.org/wiki/weekday for details -- that is not meant here. 'Day of week' is more appropriate. [ci skip]
* | | Mirror direct uploadsGeorge Claghorn2019-05-222-8/+24
| | |
* | | Add `action_cable_connection_test_case` hook to the "available hooks" list ↵प्रथमेश Sonpatki2019-05-221-28/+29
| | | | | | | | | | | | | | | [ci skip] (#36326) - This hook was added in 90296674b1c
* | | Merge pull request #36282 from yoones/add-skip-options-to-command-line-guideEileen M. Uchitelle2019-05-181-0/+22
|\ \ \ | | | | | | | | List available skip options in command line guide
| * | | List available skip options in command line guide [ci skip]Younes SERRAJ2019-05-151-0/+22
| | | |
* | | | Merge pull request #36263 from vishaltelangre/add-undefined-acronymEileen M. Uchitelle2019-05-181-2/+2
|\ \ \ \ | | | | | | | | | | [skip ci] Add undefined STI acronym to the heading which is referred under its section
| * | | | [skip ci] Add undefined STI acronym to the heading which is referred under ↵Vishal Telangre2019-05-121-2/+2
| | | | | | | | | | | | | | | | | | | | its section
* | | | | typo changeflocela2019-05-161-1/+1
| |/ / / |/| | | | | | | | | | | In Adding More RESTful Actions, Adding Member Routes: I believe the word 'that' should be added to the sentence, 'Within the block of member routes, each route name specifies the HTTP verb will be recognized.' This results in 'Within the block of member routes, each route name specifies the HTTP verb that will be recognized.'
* | | | edit tweaks to recent patch in configuring guide [ci skip]Xavier Noria2019-05-141-1/+2
| | | |
* | | | Merge pull request #36200 from ↵Xavier Noria2019-05-141-0/+6
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | soartec-lab/update_guide_configuring_add_autoloader Added guide for `config.autoloader` [skip ci]
| * | | | Added guide for `config.autoloader` [skip ci]soartec-lab2019-05-071-0/+6
| | | | |
* | | | | shortens a comment [ci skip]Xavier Noria2019-05-141-1/+1
| | | | | | | | | | | | | | | | | | | | To avoid word wrap in the rendered guide.
* | | | | [skip ci] The default value of ↵Vishal Telangre2019-05-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | config.active_record.collection_cache_versioning without loading Railtie is false Please check https://github.com/rails/rails/pull/36260#discussion_r283266942 for reference. [Vishal Telangre, bogdanvlviv]
* | | | | Merge pull request #36260 from ↵Eileen M. Uchitelle2019-05-131-0/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | vishaltelangre/active_record-collection_cache_versioning-config-info [skip ci] Add missing info about 'active_record.collection_cache_versioning' configuration
| * | | | | [skip ci] Add missing info about 'active_record.collection_cache_versioning' ↵Vishal Telangre2019-05-121-0/+6
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | configuration References: - https://github.com/rails/rails/commit/4f2ac80d4cdb01c4d3c1765637bed76cc91c1e35 - https://github.com/rails/rails/blob/b1c917ee2fdaa452aeb52904db0d254d85285380/railties/lib/rails/application/configuration.rb#L147-L149
* | | | | Merge pull request #36245 from vishaltelangre/patch-4Vipul A M2019-05-122-4/+5
|\ \ \ \ \ | | | | | | | | | | | | [ci skip] Clarity about embed metadata in signed and encrypted cookie
| * | | | | [ci skip] Clarity about embed metadata in signed and encrypted cookieVishal Telangre2019-05-122-4/+5
| | | | | |
* | | | | | upgrading docs: one file => one constant [ci skip]Xavier Noria2019-05-121-0/+29
| | | | | |
* | | | | | NPM -> npm [ci skip]Xavier Noria2019-05-121-2/+2
| |/ / / / |/| | | | | | | | | | | | | | According to https://www.npmjs.com/.
* | | | | Update the 6.0 load_defaults list [ci skip] (#36258)Vipul A M2019-05-111-0/+2
| | | | |
* | | | | Merge pull request #36160 from sharang-d/update-getting-startedVipul A M2019-05-111-1/+1
|\ \ \ \ \ | | | | | | | | | | | | compilation -> compression [ci skip]