aboutsummaryrefslogtreecommitdiffstats
path: root/guides
Commit message (Collapse)AuthorAgeFilesLines
* Deprecate `*_path` methods in mailers@schneems and @sgrif2014-07-301-0/+16
| | | | | | | | | | | Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead. Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR. Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead. The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`. Paired @sgrif & @schneems
* :nail_care: from #16329 [ci skip]Zachary Scott2014-07-291-1/+1
|
* Get request should not write to database note added. [skip ci]Deepender Singla2014-07-291-0/+2
|
* Merge pull request #16258 from mattwarrenrnp/masterYves Senn2014-07-251-11/+20
|\ | | | | adding indexes on tables in migration scripts [ci skip]
| * adding indexes on tables in migration scriptsMatt Warren2014-07-241-11/+20
| | | | | | | | | | | | | | | | missed one migration script in last commit remove some empty lines using the belongs_to index option to be more concise
* | Merge pull request #16276 from y-yagi/bug_report_templatesMatthew Draper2014-07-242-0/+2
|\ \ | | | | | | [ci skip]Add i18n master to the Gemfile
| * | [ci skip]Add i18n master to the Gemfileyuuji.yaginuma2014-07-242-0/+2
| | |
* | | Merge pull request #16260 from akshay-vishnoi/doc-changeMatthew Draper2014-07-241-2/+1
|\ \ \ | |/ / |/| | Calling require_self twice in css raises Sprockets::ArgumentError exception [ci skip]
| * | Calling require_self twice in css raises Sprockets::ArgumentError exception ↵Akshay Vishnoi2014-07-241-2/+1
| |/ | | | | | | [ci skip]
* | Merge pull request #16237 from tonytonyjan/patchArthur Nogueira Neves2014-07-231-4/+5
|\ \ | |/ |/| `create` method returns an active record object with errors instead of false when validation fails. [skip ci]
| * `create` return an active record object with erros instead of false when ↵Tony Jian2014-07-231-4/+5
| | | | | | | | validation fails. [skip ci]
* | Fixes #16255 [ci skip]Akshay Vishnoi2014-07-221-1/+1
| |
* | docs, add example for running a single test against core adapters.Yves Senn2014-07-221-0/+6
| | | | | | | | [ci skip]
* | Generator guide grammatical error fixed [ci skip]Siddharth Bhagwan2014-07-211-1/+1
| |
* | [ci skip] Fix code in Routing Guideyuuji.yaginuma2014-07-211-1/+1
|/
* Follow-up to #16097 [ci skip]Robin Dupret2014-07-181-3/+6
| | | | | | | | Even if this is not exactly the same, let's add a new-line character instead of two spaces. While it's specified in the Markdown specs that adding spaces at the end of the line creates a break-line tag, this is a brittle approach as people may remove them saving the file on certain editors.
* Remove "profile and benchmark" line from command line guideDave Jachimiak2014-07-171-1/+0
| | | | The profiling and benchmarking commands are no longer built into Rails.
* link minitest assertions documentation.Jonas Baumann2014-07-161-2/+7
|
* document assert[_not]_empty, assert[_not]_includes, assert[_not]_predicate ↵Jonas Baumann2014-07-161-0/+6
| | | | in testing guide.
* Merge pull request #16180 from rafaelfranca/rm-dirtyRafael Mendonça França2014-07-151-2/+2
|\ | | | | Improve Active Model Dirty API.
| * Deprecate `reset_#{attribute}` in favor of `restore_#{attribute}`.Rafael Mendonça França2014-07-151-2/+2
| | | | | | | | | | | | | | | | | | These methods may cause confusion with the `reset_changes` that behaves differently of them. Also rename undo_changes to restore_changes to match this new set of methods.
* | Document the change in `nil` handling for serialized attributesGodfrey Chan2014-07-151-0/+5
|/ | | | Also updated the test case to reflect that
* Format pass on 4.2 release notes [ci skip]Godfrey Chan2014-07-131-157/+163
| | | | | | | | | | | | | | * Leave two blank lines between sections/packages for readibility. * Always indent bullet points with four spaces. This allows multi-paragraph points to align properly (see #16103), and it is the same as the format we already use in CHANGELOGs. Doing this consistently sets an easy precedent for future contributors to follow. * Always put the PR/commit link on its own line in the source. If the bullet point spans multiple paragraphs, put it on its own paragraph at the end. [Godfrey Chan & Juanito Fatas]
* [Bug report templates] Added rack master to the GemfileAbdelkader Boudih2014-07-122-0/+2
|
* Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-07-121-113/+93
|\ | | | | | | | | Conflicts: activerecord/lib/active_record/base.rb
| * fix mismatched example call [ci skip]Vijay Dev2014-07-121-2/+2
| |
| * Revert "[ci skip] Fix doc for except"Vijay Dev2014-07-121-4/+5
| | | | | | | | | | | | | | This reverts commit 0f6b101e09d210cea2494c5d4225760f1951ea67. Reason: It's better to let `unscope` be documented. We can add a separate section for `except`.
| * [ci skip] remove invalid code from docsschneems2014-06-281-2/+0
| |
| * [ci skip] Fix doc for exceptschneems2014-06-281-5/+4
| | | | | | | | The example showed is `except`, however the method "documented" is `unstop`. Fix to align the docs to the example.
| * [ci skip] Doc ability to chain in `find_each`schneems2014-06-281-1/+9
| | | | | | | | Also use appropriate mailer syntax in the `find_each` block.
| * [ci skip] Consolidate docs for `find`schneems2014-06-281-25/+19
| | | | | | | | Put all options for overloading `find` in one section
| * [ci skip] Consolidate docs for `last`schneems2014-06-281-16/+21
| | | | | | | | | | | | Add docs on what happens when a numerical argument is provided to last. Since `last!` behaves exactly the same way but can raise an argument we can consolidate it in the `last` section.
| * [ci skip] Consolidate docs for `take`schneems2014-06-281-35/+20
| | | | | | | | | | | | Add docs on what happens when a numerical argument is provided to take. Since `take!` behaves exactly the same way but can raise an argument we can consolidate it in the `take` section.
| * [ci skip] Consolidate docs for `find_by`schneems2014-06-281-19/+14
| | | | | | | | Since `find_by!` behaves exactly the same way but can raise an argument we can consolidate it in the `find_by` section.
| * [ci skip] Consolidate docs for `first`schneems2014-06-281-35/+21
| | | | | | | | | | | | Add docs for `first` when provided a numerical argument. Since `first!` behaves exactly the same way but can raise an argument we can consolidate it in the `first` section.
| * [ci skip] Add return values to examplesschneems2014-06-281-1/+10
| |
* | [Guides] Sentence break for clarity [ci-skip]Max Goldstein2014-07-111-2/+2
| |
* | Synced 4.2 release notes with the latest commits.Godfrey Chan2014-07-111-27/+80
| | | | | | | | | | Also reordered some of the items to put newer ones on top (same order as CHANGELOGs), which makes it easier to diff while we are still working on it.
* | [ci skip] Fixed link to strong params in Getting Started section 5.6.JayK312014-07-091-2/+1
| |
* | [ci skip] Document millisecond precision change in ↵Eugene Gilburg2014-07-091-2/+12
| | | | | | | | ActiveSupport::TimeWithZone#as_json
* | [ci skip] Fix 4.2 release notes list items. [Matthew Draper & Juanito Fatas]Juanito Fatas2014-07-091-34/+41
| |
* | [ci skip] Fix 4.2 release notes rendered display.Juanito Fatas2014-07-091-31/+29
| |
* | Merge pull request #16097 from nishantmodak/correct_mdZachary Scott2014-07-0811-32/+28
|\ \ | | | | | | correct markdown usage [ci skip]
| * | correct markdown usage [ci skip]Nishant Modak2014-07-0911-32/+28
| | |
* | | Merge pull request #16086 from nickpellant/masterEileen M. Uchitelle2014-07-071-0/+14
|\ \ \ | | | | | | | | Add callbacks documentation for upgrading to 4.1.
| * | | [ci skip] Improve callback code example for 4.1 upgrade docs.Nick Pellant2014-07-071-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | The previous code example for the new explicit block requirement when setting callbacks was a little confusing. This commit makes the example more obvious.
| * | | Add callbacks documentation for upgrading to 4.1.Nick Pellant2014-07-071-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | It is now expected in 4.1 to use an explicit block rather than implicit when setting callbacks through ActiveSupport::Callbacks. This commit highlights this new expectation as part of the upgrading documentation.
* | | | Update Rails versions [ci skip]Robin Dupret2014-07-075-19/+19
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As discussed in #15304, we need to automate this process but for now, having out-of-date versions is not ideal. Since master targets 4.2.0, let's also update references to the last 4.1 version to 4.2.0. Finally, let's remove mentions to versions when this is not needed. The guides cover the features of the current version anyway. [Juanito Fatas + Robin Dupret]
* | | Merge pull request #15958 from aditya-kapoor/active-model-naming-guideRobin Dupret2014-07-061-0/+23
|\ \ \ | | | | | | | | [ci skip] add guide for ActiveModel::Naming
| * | | [ci skip] add guide for ActiveModel::NamingAditya Kapoor2014-07-051-0/+23
| | | |