aboutsummaryrefslogtreecommitdiffstats
path: root/guides
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | Add reasoning for `I18n.with_locale` and explanation that the problem isDusan Orlovic2019-01-101-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | about leak into subsequent requests. [ci skip]
* | | | | | | | Merge pull request #34905 from javan/move-npm-packages-to-rails-scopeJavan Makhmali2019-01-102-4/+4
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Move all npm packages to @rails scope
| * | | | | | | | Move all npm packages to @rails scopeJavan Makhmali2019-01-102-4/+4
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | Fixes #33083
* / / / / / / / Add Postmark to the ingress lists [ci skip]George Claghorn2019-01-101-2/+2
|/ / / / / / /
* | | | | | | Merge pull request #34909 from davidalee/patch-2Prem Sichanugrist2019-01-101-3/+3
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Specify the type for the auto-generated primary key
| * | | | | | | Specify the type for the auto-generated primary keyDavid A. Lee2019-01-091-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | Given the change to using `bigint` as type for auto-generated primary keys (as per https://github.com/rails/rails/pull/26266), I propose updating the Active Record Basics guide to explicitly state the type being used so as to avoid confusion as to the type of integer used, especially as the type can vary depending on the database used.
* | | | | | | | Added Postmark ingress supportTomek Maszkowski2019-01-091-0/+36
|/ / / / / / /
* | | | | | | Enable `Lint/UselessAssignment` cop to avoid unused variable warnings (#34904)Ryuta Kamizono2019-01-091-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Enable `Lint/UselessAssignment` cop to avoid unused variable warnings Since we've addressed the warning "assigned but unused variable" frequently. 370537de05092aeea552146b42042833212a1acc 3040446cece8e7a6d9e29219e636e13f180a1e03 5ed618e192e9788094bd92c51255dda1c4fd0eae 76ebafe594fc23abc3764acc7a3758ca473799e5 And also, I've found the unused args in c1b14ad which raises no warnings by the cop, it shows the value of the cop.
* | | | | | | Add OG tags to layout.html.erbtoshimaru2019-01-093-4/+18
|/ / / / / /
* | | | | | Revert "Revert "Merge pull request #34387 from ↵Kasper Timm Hansen2019-01-081-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | yhirano55/rails_info_properties_json"" I reverted the wrong commit. Damn it. This reverts commit f66a977fc7ae30d2a07124ad91924c4ee638a703.
* | | | | | Revert "Merge pull request #34387 from yhirano55/rails_info_properties_json"Kasper Timm Hansen2019-01-081-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We had a discussion on the Core team and we don't want to expose this information as a JSON endpoint and not by default. It doesn't make sense to expose this JSON locally and this controller is only accessible in dev, so the proposed access from a production app seems off. This reverts commit 8eaffe7e89719ac62ff29c2e4208cfbeb1cd1c38, reversing changes made to b6e4305c3bca4c673996d0af9db0f4cfbf50215e.
* | | | | | Add load hook for ActionText::RichTextGeorge Claghorn2019-01-071-0/+1
| | | | | |
* | | | | | Merge pull request #34878 from bogdanvlviv/action_text-guides-docsGeorge Claghorn2019-01-053-0/+120
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add Action Text to guides [ci skip]
| * | | | | | Add Action Text to guides [ci skip]bogdanvlviv2019-01-053-0/+120
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Move some actiontext/README.md content to Action Text Overview guide - I added WIP label to that guide since we definitely want to complement it. - Add Action Text to Major Features of Rails 6.0 Similar approach was used in #34812
* | | | | | | Merge pull request #34877 from bogdanvlviv/document-action_text_content-hookGeorge Claghorn2019-01-051-0/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Add `action_text_content` hook to the guide [ci skip]
| * | | | | | | Add `action_text_content` hook to the guide [ci skip]bogdanvlviv2019-01-051-0/+1
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | See actiontext/lib/action_text/content.rb:132
* / / / / / / Use ES6 and Webpacker in ActionCable guide.Gannon McGibbon2019-01-041-112/+160
|/ / / / / / | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | Send Active Storage jobs to dedicated queues by defaultGeorge Claghorn2019-01-041-0/+2
| | | | | | | | | | | | | | | | | | Match Action Mailbox, which sets a default queue for each of its two jobs.
* | | | | | Fix example of I18n setting in the guide [ci skip]bogdanvlviv2019-01-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Since #34356 logging `locale` value is more correct
* | | | | | Merge pull request #34855 from bogdanvlviv/update-configuring-guideRafael França2019-01-031-2/+32
|\ \ \ \ \ \ | | | | | | | | | | | | | | Update the "Configuring Rails Applications" guide [ci skip]
| * | | | | | Update the "Configuring Rails Applications" guide [ci skip]bogdanvlviv2019-01-041-2/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add section "Results of `load_defaults`" to the guide.
* | | | | | | Merge pull request #34706 from ChrisBr/instrumentation-guideGannon McGibbon2019-01-031-8/+14
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Add missing keys to ActiveSupport#instrumentation guide [skip ci]
| * | | | | | Add missing keys to ActiveSupport#instrumentation guide [skip ci]Christian Bruckmayer2019-01-021-8/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb#L625.
* | | | | | | Permit sending Active Storage purge and analysis jobs to separate queuesGeorge Claghorn2019-01-011-2/+9
| | | | | | |
* | | | | | | Document Action Mailbox configuration options [ci skip]George Claghorn2019-01-011-0/+23
| | | | | | |
* | | | | | | :scissors:Ryuta Kamizono2019-01-021-1/+1
| | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | Add load hook for ActionMailbox::TestCaseGeorge Claghorn2018-12-311-0/+1
| | | | | | |
* | | | | | | Update the load hooks reference table [ci skip]George Claghorn2018-12-311-0/+3
| | | | | | |
* | | | | | | Merge pull request #34624 from ↵Gannon McGibbon2018-12-311-1/+3
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | blaszczakphoto/update-docs-regarding-gzipping-assets Rename header of the gzip paragraph
| * | | | | | | Rename header of the gzip paragraph to more accurate and add short info ↵Mariusz Błaszczak2018-12-211-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | aboaut what to do about serving gziped files [ci skip]
* | | | | | | | Mention tiff support in ActiveStorage guidesGannon McGibbon2018-12-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | Merge pull request #34812 from bogdanvlviv/action_mailbox-guides-docsGeorge Claghorn2018-12-294-47/+323
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Add Action Mailbox to guides
| * | | | | | | | Add Action Mailbox to Major Features of Rails 6.0 [ci skip]bogdanvlviv2018-12-301-0/+9
| | | | | | | | |
| * | | | | | | | Fix Action Mailer Basics [ci skip]bogdanvlviv2018-12-302-47/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now Action Mailbox is responsible for receiving emails.
| * | | | | | | | Move some `actionmailbox/README.md` content to Action Mailbox Basics guide ↵bogdanvlviv2018-12-302-0/+307
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] I added WIP label to that guide since we definitely want to complement it.
* | | | | | | | | Remove mention about `receive.action_mailer` from the AS instrumentation guidebogdanvlviv2018-12-281-26/+0
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since e3f832a7433a291a51c5df397dc3dd654c1858cb `ActionMailer::Base.receive` is deprecated.
* | | | | | | | Specify `hosts` in bug report template.yuuji.yaginuma2018-12-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Host authentication introduced by #33145 allows only "0.0.0.0/0", "::/0" and "localhost" in the development environment. https://github.com/rails/rails/blob/4298df00ae6219b9b5b7c40f281d4fa4d66f4383/railties/lib/rails/application/configuration.rb#L33 But `rack-test` use `example.org` for default host. https://github.com/rack-test/rack-test/blob/6c07bf53adf4a4082e206561f5b9b43142fdc821/lib/rack/test.rb#L13 Therefore, if `hosts` is not specified, host authentication rejects the request. In Travis CI, this problem does not occur because `test` is specified by default in `RAILS_ENV` and `RACK_ENV`. https://docs.travis-ci.com/user/environment-variables/#default-environment-variables If user actually use it, env may not always be specified. Explicitly specify hosts in the file so that it works in any environment.
* | | | | | | | Follow up #34754bogdanvlviv2018-12-201-20/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Fix a few deprecation warnings - Remove testing of `Hash#slice` - Imporve test of `Hash#slice!` - Remove mention about `Hash#slice` from the guide
* | | | | | | | Use native `Array#append`, `Array#prepend`, `Hash#transform_keys`, and ↵Ryuta Kamizono2018-12-201-66/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `Hash#transform_keys!` Since Rails 6 requires Ruby 2.5. https://github.com/ruby/ruby/blob/ruby_2_5/NEWS Follow up #34754.
* | | | | | | | Require Ruby 2.5 for Rails 6.Kasper Timm Hansen2018-12-193-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Generally followed the pattern for https://github.com/rails/rails/pull/32034 * Removes needless CI configs for 2.4 * Targets 2.5 in rubocop * Updates existing CHANGELOG entries for fewer merge conflicts * Removes Hash#slice extension as that's inlined on Ruby 2.5. * Removes the need for send on define_method in MethodCallAssertions.
* | | | | | | | Single nest config in configuration guidesSam Bostock2018-12-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Double nesting of configuration is not supported (without using an intermediate object), even though the docs suggest it is. [ci-skip]
* | | | | | | | Add option to set parallel test worker count to the physical core count of ↵Bogdan2018-12-181-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the machine (#34735) * Add option to set parallel test worker count to the physical core count of the machine Also, use the physical core count of the machine as the default number of workers, and generate the `test_helper.rb` file with `parallelize(workers: :number_of_processors)` Closes #34734 * Ensure that we always test parallel testing Since #34734 we decided to use the physical core count of the machine as the default number of workers in the parallel testing, we need to ensure that some tests use at least 2 workers because we could run those tests on VM that has only 1 physical core. It also fixes tests failures on the CI since Travis server we are using has only one physical core. See https://travis-ci.org/rails/rails/jobs/469281088#L2352
* | | | | | | | Extend documentation of `ActiveSupport::Notifications.subscribe` (#34721)Bogdan2018-12-171-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Extend documentation of `ActiveSupport::Notifications.subscribe` Add mention that a block with only one argument passed to the method will yield an event object. Related to #33451 * Emphasize that `SubscribeEventObjects` is a test class by adding suffix `Test`
* | | | | | | | Merge pull request #32872 from utilum/soften_migrations_guide_generator_sectionVipul A M2018-12-151-4/+9
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Expand intro to generator in Migrations Guide
| * | | | | | | | Expand intro to Migration generator in Migrations Guideutilum2018-05-111-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | | Prepend module in ActiveStorage overviewSam Bostock2018-12-101-8/+14
| |_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | Fix typo in per-form CSRF token docs [ci skip]Randy Antler2018-12-071-1/+1
| | | | | | | |
* | | | | | | | Abort early if generator command fails (#34420)David Rodríguez2018-12-071-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * No need to go through ruby * Abort early if a generator command fails * Reuse `rails_command` method * Bump thor minimum dependency to 0.20.3 * Add some minimal docs * Add a changelog entry * Restore original logging
* | | | | | | | Improve deprecation message for enqueue returning falseRafael Mendonça França2018-12-051-0/+2
| |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | And make sure new applications in Rails 6.0 has this config enabled. Also, improve test coverage and add a CHANGELOG entry.
* | | | | | | Use safe nav operator when calling RailsGuides::Generator.newYosuke Kabuto2018-12-052-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Use String for direction of RailsGuides::Generator