| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
I changed return value of `ActionDispatch::Response#content_type` in #36034.
But this change seems to an obstacle to upgrading. https://github.com/rails/rails/pull/36034#issuecomment-498795893
Therefore, I restored the behavior of `ActionDispatch::Response#content_type`
to 5.2 and deprecated old behavior. Also, made it possible to control the
behavior with the config.
|
|\
| |
| | |
Allow using env var to specify pidfile
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously it was only possible to specify the location of the pidfile
for the 'rails server' command with the '-P' flag. This adds support for
specifying the pidfile using a PIDFILE env var, which can still be
overridden by the '-P' flag and with the default pidfile path unchanged.
The motivation for this feature comes from using Docker to run multiple
instances of the same rails app. When developing a rails app with
Docker, it's common to bind-mount the rails root directory in the
running container, so that changes to files are shared between the
container and the host. However, this doesn't work so well with the
pidfile and it's necessary to (remember to) add a '-P' flag to the
'rails server' command line; being able to specify this flag using an
env var would make developing with Rails+Docker a bit simpler.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
definition
Tests are also only on the `Time` class
Update doc forgetting to erase when moved
Update guide `Date` class to `Time` class and defined file
Update guide correction omission
|
| |
| |
| |
| |
| |
| | |
`content_types_to_serve_as_binary` [ci skip]
Ref: bcf370d689673031073ba2ac5588afe41cc315c9, 06ab7b27ea1c1ab357085439abacdb464f6742bf.
|
| | |
|
|/
|
|
|
|
| |
* Add note about schema cache
* Add note about opening too many connections
* Improve headers in caveats section
|
|\
| |
| | |
images/getting_started: Update screenshot for missing action
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
| |
We sometimes say "✂️ newline after `private`" in a code review (e.g.
https://github.com/rails/rails/pull/18546#discussion_r23188776,
https://github.com/rails/rails/pull/34832#discussion_r244847195).
Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style
`EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059).
That cop and enforced style will reduce the our code review cost.
|
|\
| |
| | |
[ci skip] Fix rails/command.rb document
|
| | |
|
|\ \
| | |
| | | |
Fix installation on guides/source/action_text_overview.md
|
| | |
| | |
| | |
| | | |
gem 'image_proccessing' is required.
|
| | |
| | |
| | | |
We had a bug whereby we changed the namespace on a model using ActiveStorage, which resulted in broken download links. The reason this happened is because the `active_storage_attachments` table is a polymorphic join table that records the model's class name at the time of record creation, and uses this `record_type` in queries. Since the model namespace changed, the queries did not return the blob as expected. Discussed with @rafaelfranca, who suggested adding a warning about this in the docs.
|
| |/
|/|
| |
| | |
class name. [ci skip]
|
| | |
|
| |
| |
| | |
An unfinished parenthetical.
|
| | |
|
|\ \
| | |
| | | |
Reword the ActionDispatch::Response#content_type change [ci skip]
|
| | | |
|
| | |
| | |
| | |
| | | |
Fixed the redundant addition of to [ci skip]
|
|/ /
| |
| |
| |
| | |
This file documents how to use multiple databases, what features are
supported, what features are coming soon, and caveats.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
as it is
Since #35709, `Response#conten_type` returns only MIME type correctly.
It is a documented behavior that this method only returns MIME type, so
this change seems appropriate.
https://github.com/rails/rails/blob/39de7fac0507070e3c5f8b33fbad6fced84d97ed/actionpack/lib/action_dispatch/http/response.rb#L245-L249
But unfortunately, some users expect this method to return all
Content-Type that does not contain charset. This seems to be breaking
changes.
We can change this behavior with the deprecate cycle.
But, in that case, a method needs that include Content-Type with
additional parameters. And that method name is probably the
`content_type` seems to properly.
So I changed the new behavior to more appropriate `media_type` method.
And `Response#content_type` changed (as the method name) to return Content-Type
header as it is.
Fixes #35709.
[Rafael Mendonça França & Yuuji Yaginuma ]
|
|\ \
| | |
| | | |
Add a section to introduce pluck's eager loading behavior [ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
[documentation][ci skip] stringify_keys and symbolize_keys have stable results.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Rails 6 uses the `Hash.transform_keys` found in Ruby 2.5 and later, and that method enumerates keys based on insertion order. Calling `symbolize_keys`, `stringify_keys`, and their bang variants will result in the same hash every time -- the value for any key where a collision occurs is the last assigned in that enumeration
In the docs for Hash -- https://ruby-doc.org/core-2.5.0/Hash.html
> Hashes enumerate their values in the order that the corresponding keys were inserted.
|
|/ / /
| | |
| | |
| | |
| | | |
'Week day' has a specific meaning in English -- see https://en.wiktionary.org/wiki/weekday for details -- that is not meant here. 'Day of week' is more appropriate.
[ci skip]
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
[ci skip] (#36326)
- This hook was added in 90296674b1c
|
|\ \ \
| | | |
| | | | |
List available skip options in command line guide
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
[skip ci] Add undefined STI acronym to the heading which is referred under its section
|
| | | | |
| | | | |
| | | | |
| | | | | |
its section
|
| |/ / /
|/| | |
| | | |
| | | | |
In Adding More RESTful Actions, Adding Member Routes:
I believe the word 'that' should be added to the sentence, 'Within the block of member routes, each route name specifies the HTTP verb will be recognized.' This results in 'Within the block of member routes, each route name specifies the HTTP verb that will be recognized.'
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
soartec-lab/update_guide_configuring_add_autoloader
Added guide for `config.autoloader` [skip ci]
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
To avoid word wrap in the rendered guide.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
config.active_record.collection_cache_versioning without loading Railtie is false
Please check https://github.com/rails/rails/pull/36260#discussion_r283266942 for reference.
[Vishal Telangre, bogdanvlviv]
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
vishaltelangre/active_record-collection_cache_versioning-config-info
[skip ci] Add missing info about 'active_record.collection_cache_versioning' configuration
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
configuration
References:
- https://github.com/rails/rails/commit/4f2ac80d4cdb01c4d3c1765637bed76cc91c1e35
- https://github.com/rails/rails/blob/b1c917ee2fdaa452aeb52904db0d254d85285380/railties/lib/rails/application/configuration.rb#L147-L149
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[ci skip] Clarity about embed metadata in signed and encrypted cookie
|
| | | | | | |
|
| | | | | | |
|
| |/ / / /
|/| | | |
| | | | |
| | | | | |
According to https://www.npmjs.com/.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
compilation -> compression [ci skip]
|