| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
|
|
|
|
|
| |
- Remove Duplicated explanation.
- Fix some typo.
- Attach PR, commit link that missed one.
|
|\
| |
| | |
Update docs with Action Cable Redis dependency
|
| |
| |
| |
| |
| |
| |
| | |
Action Cable's test `test/subscription_adapter/redis_test.rb` fail if
Redis is not installed and running.
Following the guides `development_dependen there's no mention to this.
|
| |
| |
| |
| |
| | |
Now the schema dumper by default doesn't align the types and arguments
in the ruby format anymore.
|
| |
| |
| |
| |
| | |
Fixes #26247.
[ci skip]
|
|\ \
| |/
|/| |
Specified directories for routes, views and jobs tests
|
| |
| |
| |
| |
| | |
* Added location for route, view and job tests to section 2.1. (They are currently only defined in sections 8 Testing Views and 11 Testing Jobs.)
* Added location for route test in section 7 Testing Routes. (Currently only defined in section 8 Testing Views.)
|
| | |
|
| |
| |
| |
| | |
instance of ActiveRecord::Relation
|
|\ \ |
|
| | |
| | |
| | |
| | | |
it is used in context of a command like bin/rails or the rails directory [ci skip]
|
| | |
| | |
| | |
| | | |
is that we are referring to. [ci skip]
|
| | |
| | |
| | |
| | | |
- Followup of https://github.com/rails/rails/pull/26125.
|
|\ \ \
| | | |
| | | | |
Consistent examples and template for assets#precompile
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Listening to a few developers today discussing their troubles in understanding how to use the asset pipeline, it turns out that the precompile examples in the guides and assets.rb template have over time become a bit inconsistent.
This PR makes the examples consistent in code style, spacing, and asset names, removes the old 'swfObject.js' example, and in a couple of places wraps lines at 80 characters including in the assets.rb template.
Re-add spaces inside array parentheses.
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Option not to line up column attributes in schema.rb
|
| |\ \ \ \ |
|
| | | | | | |
|
| |/ / / /
|/| | | |
| | | | |
| | | | | |
The immediate runner is no longer default, the async adapter is.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When you don't explicitly provide `optional: true` to a `belongs_to`
definition, rails adds a validation to ensure presence of the
`belongs_to` validation.
However, when the validation is added, it is added with a message key of
`:required`, which was not documented in the "Translations for Active
Record Models" section of the i18n guides.
Here are the lines that add the `:required` message:
https://github.com/rails/rails/blob/c3e3577f9d5058382504773bf0d32afa15cb131e/activerecord/lib/active_record/associations/builder/belongs_to.rb#L136-L138
This commit adds the "non-optional association" validation to the table,
so rails users know how to override the message for this validation. The
default message is "must exist".
|
| | | | |
| | | | |
| | | | | |
As "discussed" in #26187 I added the route that magically disappeared again.
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
I've noticed that once `<h1>Editing article</h1>` L1157 was the title and then later on it's `<h1>Edit article</h1>` L1358 which kind of makes more sense...
[ci skip]
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
malclocke/specify_ar_message_interpolation_names_in_i18n_guide
List names of error interpolation variables.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Clarify migration to ApplicationRecord in upgrade guides [ci skip]
|
| | | | | | |
|
|/ / / / / |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Reason: See https://github.com/rails/rails/pull/26163#issuecomment-239703322
This reverts commit 39effc857e5c774670d6fad1a26aebcc33c51f0a.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Clarify and fix typos in autoloading disabled section
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The Guides section about autoloading being disabled was slightly confusing
(#24724) and didn't directly reference the removed feature by name
(config.autoload_paths) making it much harder for someone to search the upgrade
guides for a mention or serendipitously find it via a Google search when running
into autoloading issues.
I also fixed some confusing turns of phrase and a missing word.
/cc @vipulnsward @jvanbaarsen
|
|/ / / /
| | | |
| | | |
| | | | |
- It is Action Controller config, not Action View.
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Minor doc fix related to ActiveModel::SecurePassword [ci skip]
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Document know limitation about using `references` in conjunction with custom select clauses [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
loading causing it to ignore custom select clauses.
[ci skip]
Fixes #24314
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Add link to 'Pry' in debugging guide [ci skip]
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Follow up to fe859a54219740fa8b4e09a592820d2ee12ba222
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Implement naive partial caching mechanism.
Add test for LogSubscriber
Use ActionView::Base#log_payload to store log_subscriber's payload, so we can pass cache result into it.
Fixed tests
Remove useless settings
Check if #log_payload exists before calling it. Because other classes also includes CacheHelper but don't have is attribute
Use @log_payload_for_partial_reder instead of #log_payload to carry ActionView's payload.
Update test's hash syntax
Add configuration to enable/disable fragment caching logging
Remove unless test and add new test to ensure cache info won't effect next rendering's log
Move :enable_fragment_cache_logging config from ActionView to ActionPack
Apply new config to tests
Update actionview's changelog
Update configuration guide
Improve actionview's changelog
Refactor PartialRenderer#render and log tests
Mute subscriber's log instead of disabling instrumentation.
Fix typo, remove useless comment and use new hash syntax
Improve actionpack's log_subscriber test
Fix rebase mistake
Apply new config to all caching intstrument actions
|
|\ \ \ \
| | | | |
| | | | | |
Correct usage for acceptance validator in guide
|
| | | | | |
|
| | | | | |
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Due to the limited support for inotify (Microsoft/BashOnWindows#216) in
WSL the best thing to do at moment is add a note about skipping spring
and listen when generating your application in the Getting Started guide.
[skip ci]
Fixes #26054.
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | | |
Some Rails core members agreed to continue to maintain 4.2 until 5.1 is
released.
[ci skip]
|