| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current Basic Test Case example has the following assertion
```
assert_equal read_fixture('invite').join, email.body.to_s
```
email.body.to_s returns an empty string if both HTML and text templates
exist for a given mailer. This commit adds a note to section 11.2.2
explaining this and also suggests using email.text_part.body.to_s
and email.html_part.body.to_s as alternatives.
|
| |
|
|
|
|
|
|
|
| |
Since using a `ActiveSupport::Deprecation::DeprecatedConstantProxy`
would prevent people from inheriting this class and extending it
from the `ActiveSupport::HashWithIndifferentAccess` one would break
the ancestors chain, that's the best option we have here.
|
| |
|
|
|
|
| |
As the specified command is `rails g system_test articles`, the generated class name
is `ArticlesTest`, not `UsersTest`
|
| |
|
| |
|
|
|
|
|
| |
There were some grammar issues and incorrect information in the system
tests documentation.
|
|
|
|
|
|
| |
This renames the system test helper file to be application system test
case to match what the rest of Rails does. In the future we should
consider changing the test_helper to match.
|
|
|
|
|
|
|
|
|
|
| |
* Move system tests back into Action Pack
* Rename `ActionSystemTest` to `ActionDispatch::SystemTestCase`
* Remove private base module and only make file for public
`SystemTestCase` class, name private module `SystemTesting`
* Rename `ActionSystemTestCase` to `ApplicationSystemTestCase`
* Update corresponding documentation and guides
* Delete old `ActionSystemTest` files
|
|
|
|
|
| |
Update the documentation after rewriting a majority of the functionality
for system testing.
|
|
|
|
|
| |
This adds the required guides for how to write and use system tests in
your application.
|
| |
|
|\
| |
| | |
Remove deprecate passing string to `:if` and `:unless` conditional options [ci skip]
|
| |
| |
| |
| |
| |
| | |
[ci skip]
Follow up to #27608
|
| |
| |
| |
| |
| |
| |
| | |
Change Rails engine guide to references a maintained project
Thredded instead of the abandoned project Forem. I chose
Thredded as Forem's closing note (below) suggests the choice.
https://github.com/rubysherpas/forem/blob/rails4/README.md
|
|/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit is not precisely atomic, but the changes have evolved, summary:
* The ENV-based interface has been moved upwards, the generator has now a conventional
initializer.
* RAILS_VERSION is now assumed to be a Git tag. A blank RAILS_VERSION means edge guides.
* In consequence, the EDGE env variable is gone.
* The "local" version is also gone, the current SHA1 is computed for edge guides.
* Assumes guides are generated from a repo checkout (time ago users could
generate them from gems.)
* The WARNINGS flag is gone in consequence, you cannot disable warnings.
* The `api_link` Markdown helper is fixed.
* Docs about usage have one single place: rake guides:help.
* Links in guides have been revised.
|
|
|
|
| |
Switch extension 👉 format as it's more apt here.
|
|\
| |
| | |
Get TODO done in `render_test`
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Add note about breakage in file uploads in controller tests to upgrading guide
|
| |/
| |
| |
| |
| |
| |
| |
| | |
guide
ref #26404
[ci skip]
|
| | |
|
| | |
|
| | |
|
|\ \
| |/
|/| |
Improve linking inside guides
|
| |
| |
| |
| |
| |
| |
| | |
To make sure that the user won't look at a feature that doesn't
already exist if they are looking at a previous version of the guides,
let's automatically inject the Rails version the guides have been
generated against.
|
| |
| |
| |
| |
| |
| |
| | |
The guide contains a typo in the "local_assigns" section, where
rendering a model named 'Article' via `render @articles` is shown to
render a partial called `_articles.html.erb`, when in fact the necessary
partial name is `_article.html.erb`
|
|/
|
|
|
|
| |
Update i18n.md
Addressed Feedback
|
|
|
|
|
| |
`judgment` is the preferred form as Rails usually follows en-us spelling
not en-gb.
|
| |
|
| |
|
|
|
|
| |
This will help people figure out what credentials and tables are required to
run ActiveRecord specs.
|
|
|
|
| |
[ci skip]
|
| |
|
| |
|
|
|
|
|
|
| |
Since `Thor::HELP_MAPPINGS` contains `-D`, so `bin/rails -D` show
rails's help. But, in Rails 5.0.1, `bin/rails -D` show the description
of rake task. I think that it is better to have the same behavior.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The exact inspect output of a BigDecimal is out of scope for what we're trying
to communicate about `dup` and `duplicable?` here.
Adding two examples distracts is disctracting, so keep the docs from before
since our minimal version is Ruby 2.2.2.
[ Koichi ITO, Jon Moss, Kasper Timm Hansen ]
This reverts commit 2163874dedaf83e67599c2930c2686caa165fbad, reversing
changes made to 46fdbc5290335ed38fa9fe2b6b0ef8abe4eccb1b.
|
|
|
|
| |
cf. https://github.com/ruby/bigdecimal/pull/42
|
|
|
|
|
| |
The Numeric extensions like 1.day, 1.month, etc. shouldn't know
how the internals of ActiveSupport::Duration works.
|
|\
| |
| | |
Fix inconsistent parsing of Durations with both months and years
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
durations from code
ActiveSupport::Duration.parse('P3Y') == 3.years # It should be true
Duration parsing made independent from any moment of time:
Fixed length in seconds is assigned to each duration part during parsing.
Changed duration of months and years in seconds to more accurate and logical:
1. The value of 365.2425 days in Gregorian year is more accurate
as it accounts for every 400th non-leap year.
2. Month's length is bound to year's duration, which makes
sensible comparisons like `12.months == 1.year` to be `true`
and nonsensical ones like `30.days == 1.month` to be `false`.
Calculations on times and dates with durations shouldn't be affected as
duration's numeric value isn't used in calculations, only parts are used.
Methods on `Numeric` like `2.days` now use these predefined durations
to avoid duplicating of duration constants through the codebase and
eliminate creation of intermediate durations.
|
|/
|
|
| |
https://github.com/rails/rails/commit/f02a35b86efea24f1e2ab684bc8081ced5eb3b1a [ci skip]
|
|\
| |
| | |
Update increment! documentation [ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The `increment!` and `decrement!` methods were recently reimplemented to
make them safe to call from multiple connections concurrently. This
changed their behaviour in a few ways.
Previously they used `update_attribute`, which calls the attribute
setter method, runs callbacks, and touches the record. Now they behave
more like `update_column`, writing the update to the database directly
and bypassing all of those steps.
|