| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Fix title for example of removing data from `session` [ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
After #31685 the description says different what
we expect to see in the example. Change `assign that key to be nil` to
`or delete the key/value pair` in order to highlight what is shown in the example.
Fix one more example of removing data from the session in favour of using
`delete` since assigning to `nil` doesn't delete key from it.
|
| |
| |
| |
| | |
Introduced in #32646
|
|\ \
| | |
| | | |
Update schema.rb documentation [CI SKIP]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The documentation previously claimed that `db/schema.rb` was "the
authoritative source for your database schema" while simultaneously
also acknowledging that the file is generated. These two statements are
incongruous and the guides accurately call out that many database
constructs are unsupported by `schema.rb`. This change updates the
comment at the top of `schema.rb` to remove the assertion that the file
is authoritative.
The documentation also previously referred vaguely to "issues" when
re-running old migrations. This has been updated slightly to hint at the
types of problems that one can encounter with old migrations.
In sum, this change attempts to more accurately capture the pros, cons,
and shortcomings of the two schema formats in the guides and in the
comment at the top of `schema.rb`.
[Derek Prior & Sean Griffin]
Co-authored-by: Sean Griffin <sean@seantheprogrammer.com>
|
|\ \ \
| |_|/
|/| | |
Use ImageProcessing gem for ActiveStorage variants
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
ImageProcessing gem is a wrapper around MiniMagick and ruby-vips, and
implements an interface for common image resizing and processing. This
is the canonical image processing gem recommended in [Shrine], and
that's where it developed from. The initial implementation was extracted
from Refile, which also implements on-the-fly transformations.
Some features that ImageProcessing gem adds on top of MiniMagick:
* resizing macros
- #resize_to_limit
- #resize_to_fit
- #resize_to_fill
- #resize_and_pad
* automatic orientation
* automatic thumbnail sharpening
* avoids the complex and inefficient MiniMagick::Image class
* will use "magick" instead of "convert" on ImageMagick 7
However, the biggest feature of the ImageProcessing gem is that it has
an alternative implementation that uses libvips. Libvips is an
alternative to ImageMagick that can process images very rapidly (we've
seen up 10x faster than ImageMagick).
What's great is that the ImageProcessing gem provides the same interface
for both implementations. The macros are named the same, and the libvips
implementation does auto orientation and thumbnail sharpening as well;
only the operations/options specific to ImageMagick/libvips differ. The
integration provided by this PR should work for both implementations.
The plan is to introduce the ImageProcessing backend in Rails 6.0 as the
default backend and deprecate the MiniMagick backend, then in Rails 6.1
remove the MiniMagick backend.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Remove key from session by using session.delete
You are not deleting a key from session when you assign nil to that key.
* Update guides on how to destroy a user session
In this commit, the user id is removed from session and controller's variables related to the user are nullified.
[Rafael Mendonça França + Rafael Barbolo]
|
|\ \ \
| | | |
| | | | |
Update results of command in Testing guides [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | | |
* Results of command in testing guides are different from actual ones.
* Updated them.
|
|/ / /
| | |
| | |
| | |
| | | |
* Rewrite with Vanilla JS
* Confirmed with Chrome, Safari, Firefox
|
|\ \ \
| | | |
| | | | |
[ci skip] belongs_to in self join association needs optional: true, if it's over 5.0 ver of rails
|
| |/ /
| | |
| | |
| | | |
over 5.0 ver of rails
|
|\ \ \
| | | |
| | | | |
guides/testing: Pluralize controller and helper class names.
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
The Rails convention for controllers and helpers is plural, except where
intentionally singular. Pluralize the controller and helper class names,
to match convention.
|
|\ \ \
| |_|/
|/| | |
Rails-ujs: Info about stoppable events
|
| |/ |
|
| | |
|
|\ \
| | |
| | | |
Add the `nonce: true` option for `javascript_include_tag` helper.
|
| | | |
|
|/ /
| |
| |
| | |
Calling this an MD5 implies that it is generated consistently based on some input.
However, this value is [completely random](https://github.com/rails/sprockets/blob/fbe6e450b6f25cf3ea494fcab0e34001d0b5a0b9/lib/sprockets/manifest_utils.rb#L11-L24).
|
|\ \
| | |
| | | |
Inclusive Language in Documentation Examples
|
| | | |
|
| |/ |
|
|\ \
| | |
| | | |
Add the reference to Rails Guides 5.2 from the Edge Guides
|
| |/
| |
| |
| | |
[ci skip]
|
|/ |
|
|
|
| |
Updated underground market prices according to the 2017 Symantec ISTR (was previously citing the 2008 report)
|
|
|
|
| |
The old link https://samy.pl/popular/tech.html is 404 not found.
|
|
|
|
|
|
| |
See https://github.com/rails/rails-docs-server/pull/8 for reason.
[ci skip]
|
|
|
|
| |
[ci skip]
|
|
|
|
|
|
|
|
|
|
|
| |
We don't want people to jump from the last release in the previous
series (4.2) straing to the first release in the current series that is
support (5.1), so we should be supporting the entire series for severe
security issues.
This will not be a problem because usually we only have 3 releases in a
series and backporting patches inside the same series is not harder than
backporting to a previous series.
|
|
|
|
| |
It is the last major release series.
|
| |
|
|
|
|
| |
* In 5.2 release note, added [securing rails app guide](http://edgeguides.rubyonrails.org/security.html#custom-credentials) link to [credentials section](http://edgeguides.rubyonrails.org/5_2_release_notes.html#credentials).
|
| |
|
|
|
|
| |
* refs #32420
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ActionView::Template instances compile their source to methods on the
ActionView::CompiledTemplates module. To prevent leaks in development
mode, where templates can frequently change, a finalizer is added that
undefines these methods[1] when the templates are garbage-collected.
This is undesirable in the test environment, however, as templates don't
change during the life of the test. Moreover, the cost of undefining a
method is proportional to the number of descendants a class or module
has, since the method cache must be cleared for all descendant classes.
As ActionView::CompiledTemplates is mixed into every
ActionView::TestCase (or in RSpec suites, every view spec example
group), it can end up with a very large number of descendants, and
undefining its methods can become very expensive.
In large test suites, this results in a long delay at the end of the
test suite as all template finalizers are run, only for the process to
then exit.
To avoid this unnecessary cost, this change adds a config option,
`action_view.finalize_compiled_template_methods`, defaulting to true,
and sets it to false in the test environment only.
[1] https://github.com/rails/rails/blob/09b2348f7fc8d4e7191e70e06608c5909067e2aa/actionview/lib/action_view/template.rb#L118-L126
|
|\
| |
| | |
Remove needless images in guides
|
| | |
|
|\ \
| |/
|/| |
[ci skip] Use Oxford comma style in guide
|
| | |
|
|/
|
|
|
|
|
| |
The text is a continuation of the sentence before the listing so
doesn't need to begin with a capital letter.
This reverts commit 77a7acafba11fccac8b4cf30a9ce62d43a9ac186.
|
|\
| |
| |
| |
| | |
yhirano55/capitalize_sentence_of_first_char_in_as_guide
[ci skip] Capitalize sentence of first char in AS guide
|
| | |
|
|\ \
| | |
| | | |
Add earlier releases v3.0, v3.1 in guides
|