Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | Merge pull request #32313 from lulalala/model_error_as_object | Rafael França | 2019-04-24 | 1 | -6/+6 | |
|\ \ \ | |_|/ |/| | | Model error as object | |||||
| * | | Raise deprecation for calling `[:f] = 'b'` or `[:f] << 'b'` | lulalala | 2019-03-31 | 1 | -6/+6 | |
| | | | | | | | | | | | | Revert some tests to ensure back compatibility | |||||
* | | | Merge pull request #36066 from st0012/update-controller-cache-doc | Rafael França | 2019-04-23 | 1 | -2/+2 | |
|\ \ \ | | | | | | | | | Update document about perform_caching's default value [ci skip] | |||||
| * | | | Update document about perform_caching's default value | st0012 | 2019-04-24 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clarify that both `config.action_controller.perform_caching` and `config.action_mailer.perform_caching`'s default are `true`. This default is set in `AbstractController::Caching`. One can verify this by commenting out all ``` @controller.perform_caching = true ``` in `actionpack/test/controller/caching_test.rb` and run the tests. They should still pass. | |||||
* | | | | Make docs on form_with_generates_ids config option match the value | David Shaffer | 2019-04-23 | 1 | -1/+1 | |
|/ / / | | | | | | | | | | [skip ci] | |||||
* | | | Merge pull request #36063 from ↵ | Rafael França | 2019-04-23 | 1 | -8/+0 | |
|\ \ \ | | | | | | | | | | | | | | | | | albertoalmagro/finish-documentation-for-after-save-commit Remove reminiscences from previous documentation | |||||
| * | | | Remove reminiscences from previous documentation [ci skip] | Alberto Almagro | 2019-04-23 | 1 | -8/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In #35861 documentation for `after_save_commit` was added, but also old documentation was adapted. I think adapting the old documentation is not necessary because there are already examples for `after_commit` on `:destroy` above. On top of that the action invoked by the callback on `:destroy` (`:log_user_saved_to_db`) talks about saving when the object is destroyed, which can be misleading. As I believe the documentation added by #35861 is already enough this patch removes the modified part, which made sense before adding docs for `after_save_commit` but is already covered by other parts of this guide. | |||||
* | | | | Merge pull request #36060 from st0012/fix-35602-doc | Rafael França | 2019-04-23 | 1 | -0/+9 | |
|\ \ \ \ | | | | | | | | | | | Add ActionController::Caching into api app's document [ci skip] | |||||
| * | | | | Add ActionController::Caching into api app's document | st0012 | 2019-04-23 | 1 | -0/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails doesn't support view caching in api controllers by default but the document didn't clearerly declare this nor the manual config needed after including the module manually. So we'll see people get confused like #35602. | |||||
* | | | | | Add PR link for Active Storage updating release note entry [ci skip] | Abhay Nikam | 2019-04-23 | 1 | -0/+1 | |
| |/ / / |/| | | | ||||||
* | | | | [ci skip] Active Storage: updating associations replaces | Kasper Timm Hansen | 2019-04-22 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Rails updating an Active Storage relation will now replace the entire association instead of merely adding to it. https://github.com/rails/rails/issues/35817#issuecomment-485512520 Fixes #35817 cc @georgeclaghorn | |||||
* | | | | Fix typo by changing 'for' to 'from' | Saheed Oladele | 2019-04-21 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Add release notes for changes in the guides for Rails 6 [ci skip] (#36046) | प्रथमेश Sonpatki | 2019-04-20 | 1 | -0/+9 | |
| | | | | ||||||
* | | | | Merge pull request #35738 from gmcgibbon/aj_assert_drop_usec_docs | Gannon McGibbon | 2019-04-20 | 1 | -0/+19 | |
|\ \ \ \ | |/ / / |/| | | | ActiveJob time argument assertion documentation | |||||
| * | | | Add section on asserting time args for jobs | Gannon McGibbon | 2019-03-25 | 1 | -0/+19 | |
| | | | | ||||||
* | | | | Mention more ActiveStorage hooks in Active Support Instrumentation guide [ci ↵ | Younes SERRAJ | 2019-04-17 | 1 | -0/+25 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | skip] Hooks added: - `service_download_chunk.active_storage` - `service_update_metadata.active_storage` - `preview.active_storage` | |||||
* | | | | Prefer to indent and no blank line after private/protected [ci skip] | Ryuta Kamizono | 2019-04-17 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | [ci skip] More asset guide touch ups | Kasper Timm Hansen | 2019-04-17 | 1 | -4/+5 | |
| | | | | ||||||
* | | | | Merge pull request #35994 from ↵ | Kasper Timm Hansen | 2019-04-17 | 1 | -14/+6 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | soartec-lab/update_guide_asset_pipeline_change_default Guide updated in line with changes in rails commands [skip ci] | |||||
| * | | | | Guide updated in line with changes in rails commands [skip ci] | soartec-lab | 2019-04-16 | 1 | -14/+6 | |
| | | | | | ||||||
* | | | | | Update the generate command sample codes [skip ci] | soartec-lab | 2019-04-17 | 1 | -6/+5 | |
|/ / / / | ||||||
* | | | | Merge pull request #35927 from arbox/master | Rafael França | 2019-04-15 | 1 | -0/+5 | |
|\ \ \ \ | | | | | | | | | | | Add section on PostgreSQL to the guides index [ci skip] | |||||
| * | | | | Mark the section on PostgreSQL to be work in progress [ci skip] | Andrei Beliankou | 2019-04-12 | 1 | -0/+1 | |
| | | | | | ||||||
| * | | | | Add section on PostgreSQL to the guides index [ci skip] | Andrei Beliankou | 2019-04-10 | 1 | -0/+4 | |
| | | | | | ||||||
* | | | | | Merge pull request #35906 from yoones/notes-tags-registration | Rafael França | 2019-04-15 | 1 | -0/+16 | |
|\ \ \ \ \ | | | | | | | | | | | | | Notes tags registration | |||||
| * | | | | | Adds `register_tags` | Younes SERRAJ | 2019-04-12 | 1 | -0/+16 | |
| |/ / / / | ||||||
* | | | | | Remove the Amazon SES ingress | George Claghorn | 2019-04-14 | 1 | -25/+3 | |
| | | | | | | | | | | | | | | | It's unusable and not ready to ship in Rails 6.0. We'll rewrite it for 6.1. | |||||
* | | | | | Merge pull request #35908 from soartec-lab/update_guide_engine_app_dir | Rafael França | 2019-04-11 | 1 | -3/+25 | |
|\ \ \ \ \ | | | | | | | | | | | | | Add all descriptions in app directory [skip ci] | |||||
| * | | | | | Add all descriptions in app directory [skip ci] | soartec-lab | 2019-04-09 | 1 | -3/+25 | |
| |/ / / / | ||||||
* | | | | | Merge pull request #35938 from soartec-lab/update_guide_engine_sample_code | Rafael França | 2019-04-11 | 1 | -14/+17 | |
|\ \ \ \ \ | | | | | | | | | | | | | Use modele to generate generated defaults [skip ci] | |||||
| * | | | | | Use modele to generate generated defaults [skip ci] | soartec-lab | 2019-04-11 | 1 | -14/+17 | |
| | | | | | | ||||||
* | | | | | | Merge pull request #35945 from soartec-lab/update_guide_engine_sample_code_block | Rafael França | 2019-04-11 | 1 | -1/+3 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Code is enclosed by code block [skip ci] | |||||
| * | | | | | | Code is enclosed by code block [skip ci] | soartec-lab | 2019-04-12 | 1 | -1/+3 | |
| |/ / / / / | ||||||
* / / / / / | Updated the description of `add_development_dependency` [skip ci] | soartec-lab | 2019-04-12 | 1 | -1/+1 | |
|/ / / / / | ||||||
* | | | | | Remove outdated debugging plugins | Clivia | 2019-04-11 | 1 | -7/+0 | |
| | | | | | | | | | | | | | | | | | | | | Footnote and Query review are outdated, unmaintained, and Query review is for rails 3. | |||||
* | | | | | Update the result of generate command [skip ci] | soartec-lab | 2019-04-11 | 1 | -14/+6 | |
|/ / / / | ||||||
* | | | | s/Travis/Buildkite/ | Matthew Draper | 2019-04-09 | 1 | -3/+3 | |
| | | | | ||||||
* | | | | Merge pull request #35888 from ↵ | Eileen M. Uchitelle | 2019-04-08 | 1 | -8/+8 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | lxxxvi/documentation_change_foreign_keys_to_bigint_in_association_basics change `t.integer` to `t.bigint` where applicable | |||||
| * | | | | change `t.integer` to `t.bigint` where applicable | lxxxvi | 2019-04-07 | 1 | -8/+8 | |
| | | | | | ||||||
* | | | | | Update configuration of `app` directory and use oxford comma [skip ci] | soartec-lab | 2019-04-09 | 1 | -2/+2 | |
| | | | | | ||||||
* | | | | | [ci skip] Add 6.0 Release Notes for Active Record | Alex Kitchens | 2019-04-08 | 1 | -0/+227 | |
|/ / / / | ||||||
* | | | | The default value without loading railtie is false [ci skip] (#35881) | प्रथमेश Sonpatki | 2019-04-05 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | See https://github.com/rails/rails/pull/35873#issuecomment-480333333 for reference [Prathamesh Sonpatki, bogdanvlviv] | |||||
* | | | | Merge pull request #35873 from prathamesh-sonpatki/enqueuing-fixes | Eileen M. Uchitelle | 2019-04-05 | 1 | -1/+1 | |
|\ \ \ \ | | | | | | | | | | | Fix the deprecation warning about `config.active_job.return_false_on_aborted_enqueue` | |||||
| * | | | | Fix the deprecation warning about ↵ | Prathamesh Sonpatki | 2019-04-05 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `config.active_job.return_false_on_aborted_enqueue` - It will return false in Rails 6.1 not 6.0. Also fixed the default value which is true for new applications. | |||||
* | | | | | Add Active Job release notes [ci skip] (#35872) | प्रथमेश Sonpatki | 2019-04-05 | 1 | -0/+46 | |
| | | | | | ||||||
* | | | | | fix typo in the guides (use Rails instead of rails) | Edward Rudd | 2019-04-04 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Add documentation for 'after_save_commit' [ci skip] | Sharang Dashputre | 2019-04-05 | 1 | -2/+25 | |
|/ / / / | ||||||
* | | | | add documentation about variants | Edward Rudd | 2019-04-03 | 1 | -0/+39 | |
| | | | | ||||||
* | | | | [skip ci] Add examples for has_{one,many} :through :source and :source_type ↵ | Tim Wade | 2019-04-03 | 1 | -0/+29 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#35612) * Add example for has_many :through source/source_type * Add example for has_one :through source/source_type | |||||
* | | | | Use official database name [ci skip] | Ryuta Kamizono | 2019-04-03 | 2 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * s/Postgres/PostgreSQL/ * s/MYSQL/MySQL/, s/Mysql/MySQL/ * s/Sqlite/SQLite/ Replaced all newly added them after 6089b31. |