aboutsummaryrefslogtreecommitdiffstats
path: root/guides/source
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | i18n documentation for required belongs_to messageIan C. Anderson2016-08-171-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When you don't explicitly provide `optional: true` to a `belongs_to` definition, rails adds a validation to ensure presence of the `belongs_to` validation. However, when the validation is added, it is added with a message key of `:required`, which was not documented in the "Translations for Active Record Models" section of the i18n guides. Here are the lines that add the `:required` message: https://github.com/rails/rails/blob/c3e3577f9d5058382504773bf0d32afa15cb131e/activerecord/lib/active_record/associations/builder/belongs_to.rb#L136-L138 This commit adds the "non-optional association" validation to the table, so rails users know how to override the message for this validation. The default message is "must exist".
* | | | | Fix #26187Jonathan2016-08-171-0/+1
| | | | | | | | | | | | | | | As "discussed" in #26187 I added the route that magically disappeared again.
* | | | | Fix diffrent naming in getting_started.mdJonathan2016-08-171-1/+1
|/ / / / | | | | | | | | | | | | | | | | I've noticed that once `<h1>Editing article</h1>` L1157 was the title and then later on it's `<h1>Edit article</h1>` L1358 which kind of makes more sense... [ci skip]
* | | | Fix link in Rails 5.0 Release Note [ci skip]Yohei YASUKAWA2016-08-171-1/+1
| | | |
* | | | Merge pull request #26061 from ↵Rafael França2016-08-161-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | malclocke/specify_ar_message_interpolation_names_in_i18n_guide List names of error interpolation variables.
| * | | | List names of error interpolation variables.Malcolm Locke2016-08-051-1/+1
| | | | |
* | | | | Merge pull request #26175 from stomar/upgrade-guide-fixRafael França2016-08-161-0/+2
|\ \ \ \ \ | | | | | | | | | | | | Clarify migration to ApplicationRecord in upgrade guides [ci skip]
| * | | | | Clarify migration to ApplicationRecord in upgrade guides [ci skip]Marcus Stollsteimer2016-08-151-0/+2
| | | | | |
* | | | | | Clarify use of update task on 4.2 and earlier [ci skip]Marcus Stollsteimer2016-08-151-1/+1
|/ / / / /
* | | | | fix usage of pluralized wordchuckdishmon2016-08-141-1/+1
| | | | |
* | | | | Revert "Clarify and fix typos in Autoloading Disabled upgrade guide [ci skip]"Xavier Noria2016-08-151-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reason: See https://github.com/rails/rails/pull/26163#issuecomment-239703322 This reverts commit 39effc857e5c774670d6fad1a26aebcc33c51f0a.
* | | | | Merge pull request #26163 from olivierlacan/clarify-autoloading-disabledJon Moss2016-08-141-12/+12
|\ \ \ \ \ | | | | | | | | | | | | Clarify and fix typos in autoloading disabled section
| * | | | | Clarify and fix typos in Autoloading Disabled upgrade guide [ci skip]Olivier Lacan2016-08-141-12/+12
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Guides section about autoloading being disabled was slightly confusing (#24724) and didn't directly reference the removed feature by name (config.autoload_paths) making it much harder for someone to search the upgrade guides for a mention or serendipitously find it via a Google search when running into autoloading issues. I also fixed some confusing turns of phrase and a missing word. /cc @vipulnsward @jvanbaarsen
* / | | | Fix the documentation for configuring `enable_fragment_cache_logging` [ci skip]Prathamesh Sonpatki2016-08-141-8/+16
|/ / / / | | | | | | | | | | | | - It is Action Controller config, not Action View.
* | | | [ci skip] Fix documentation wrong for ActionCableEric Zhang2016-08-121-1/+1
| | | |
* | | | [ci skip] Fix documentation for ActionCable::Channel#broadcast_toEric Zhang2016-08-121-2/+2
| | | |
* | | | Merge pull request #26110 from aditya-kapoor/minor-doc-fixGuillermo Iguaran2016-08-101-2/+5
|\ \ \ \ | | | | | | | | | | Minor doc fix related to ActiveModel::SecurePassword [ci skip]
| * | | | Minor doc fix related to ActiveModel::SecurePassword [ci skip]Aditya Kapoor2016-08-111-2/+5
| | | | |
* | | | | Add documentation for `http_cache_forever`. [ci skip]Santosh Wadghule2016-08-101-0/+24
|/ / / /
* | | | Merge pull request #24476 from vipulnsward/24314-eagerloading-doc-updateVipul A M2016-08-091-2/+3
|\ \ \ \ | | | | | | | | | | Document know limitation about using `references` in conjunction with custom select clauses [ci skip]
| * | | | Document know limitation about using `references` in conjunction with eager ↵Vipul A M2016-08-091-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | loading causing it to ignore custom select clauses. [ci skip] Fixes #24314
* | | | | Merge pull request #26042 from bogdanvlviv/debugging_guideVipul A M2016-08-091-0/+1
|\ \ \ \ \ | |/ / / / |/| | | | Add link to 'Pry' in debugging guide [ci skip]
| * | | | Add link to 'Pry' in debugging guide [ci skip]bogdanvlviv2016-08-071-0/+1
| | | | |
* | | | | update list of rescue_responses default [ci skip]yuuji.yaginuma2016-08-091-0/+2
| | | | | | | | | | | | | | | | | | | | Follow up to fe859a54219740fa8b4e09a592820d2ee12ba222
* | | | | Modify LogSubscriber for single partial's cache message.Stan Lo2016-08-081-0/+8
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement naive partial caching mechanism. Add test for LogSubscriber Use ActionView::Base#log_payload to store log_subscriber's payload, so we can pass cache result into it. Fixed tests Remove useless settings Check if #log_payload exists before calling it. Because other classes also includes CacheHelper but don't have is attribute Use @log_payload_for_partial_reder instead of #log_payload to carry ActionView's payload. Update test's hash syntax Add configuration to enable/disable fragment caching logging Remove unless test and add new test to ensure cache info won't effect next rendering's log Move :enable_fragment_cache_logging config from ActionView to ActionPack Apply new config to tests Update actionview's changelog Update configuration guide Improve actionview's changelog Refactor PartialRenderer#render and log tests Mute subscriber's log instead of disabling instrumentation. Fix typo, remove useless comment and use new hash syntax Improve actionpack's log_subscriber test Fix rebase mistake Apply new config to all caching intstrument actions
* | | | Merge pull request #26023 from tekin/correct-acceptance-guidelinesEileen M. Uchitelle2016-08-061-1/+1
|\ \ \ \ | | | | | | | | | | Correct usage for acceptance validator in guide
| * | | | Correct usage for acceptance validator in guideTekin Suleyman2016-08-021-1/+1
| | | | |
* | | | | [ci skip] Fix broken URL in guidesclaudiob2016-08-052-2/+2
| | | | |
* | | | | Add note about limitations of Windows Subsystem for LinuxAndrew White2016-08-051-0/+4
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Due to the limited support for inotify (Microsoft/BashOnWindows#216) in WSL the best thing to do at moment is add a note about skipping spring and listen when generating your application in the Getting Started guide. [skip ci] Fixes #26054.
* | | | Add 4.2.Z back to the maintenance listRafael Mendonça França2016-08-021-1/+1
| |/ / |/| | | | | | | | | | | | | | | | | Some Rails core members agreed to continue to maintain 4.2 until 5.1 is released. [ci skip]
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-08-023-3/+11
|\ \ \ | |/ / |/| |
| * | Removed reference to callback_terminator.rb in docsIain Beeston2016-07-211-1/+1
| | | | | | | | | | | | That file has been removed and replaced with new_framework_defaults.rb
| * | The `to_query` method on Array objects uses `key[] as the prefix, not ↵Prathamesh Sonpatki2016-07-101-1/+1
| | | | | | | | | | | | `_key_[]` [ci skip]
| * | Add `config.assets.quiet` to configuration guide [ci skip]Prathamesh Sonpatki2016-07-101-0/+2
| | |
| * | Add note about `config.annotations.register_directories` option in the ↵Prathamesh Sonpatki2016-07-101-1/+7
| | | | | | | | | | | | | | | | | | guides [ci skip] - Followup of #25692.
* | | remove old links from debugging guide [ci skip]yuuji.yaginuma2016-08-011-7/+0
| | |
* | | Merge pull request #25948 from chetna1726/docsRafael França2016-07-281-0/+1
|\ \ \ | | | | | | | | [ci skip] Add documentation for error using select with order
| * | | [ci skip] Add documentation for error using select with orderChetna Sharma2016-07-251-0/+1
| | | |
* | | | Updated getting_started guide to reflect the change in error message for ↵Bonghyun Kim2016-07-281-19/+14
|/ / / | | | | | | | | | | | | | | | ActionController::UnknownFromat in ArticlesController#new Restored texts about XML and JS template handlers. [ci skip]
* | | Merge pull request #25928 from mechanicles/info-for-cache-fetch-blockप्रथमेश Sonpatki2016-07-241-1/+1
|\ \ \ | | | | | | | | Add proper description for `Rails.cache.fetch` [ci skip]
| * | | Proper description for `Rails.cache.fetch` [ci skip]Santosh Wadghule2016-07-241-1/+1
| | | |
* | | | Merge pull request #25908 from mechanicles/derives-fromKasper Timm Hansen2016-07-231-4/+4
|\ \ \ \ | | | | | | | | | | Explain meaning of the code very well and Remove confusion. [ci skip]
| * | | | Explain meaning of the code very well and Remove confusion. [ci skip]Santosh Wadghule2016-07-231-4/+4
| |/ / / | | | | | | | | | | | | | | | | | | | | Code like `render(topics) => render("topics/topic")` adds confusion for the readers. On first impression, that code feels like hash kind of data, but it's not. So make it more clear and meaningful.
* / / / define Range#match? if Ruby < 2.4Xavier Noria2016-07-221-0/+18
|/ / / | | | | | | | | | | | | | | | See the rationale in the documentation included in this patch. We are going to gradually introduce this predicate in the code base.
* | | Merge pull request #25438 from prathamesh-sonpatki/rm-session-store-initializerRafael Mendonça França2016-07-202-3/+3
|\ \ \ | | | | | | | | | | | | Setup default session store internally, no longer through an initializer
| * | | Setup default session store internally, no longer through an application ↵Prathamesh Sonpatki2016-07-172-3/+3
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | initializer - By default the session store will be set to cookie store with application name as session key. - Older apps are not affected as they will have the session store initializer generated by Rails in older versions, and Rails will not overwrite the session store if it is already set or disabled. - But new apps will not have the initializer, instead the session store will be set to cookie store by default. - Based on comment by DHH here - https://github.com/rails/rails/issues/25181#issuecomment-222312764.
* | | Merge pull request #25780 from Ropeney/patch-1Matthew Draper2016-07-191-1/+1
|\ \ \ | | | | | | | | Update ActionCable Rebroadcasting a Message documentation
| * | | Update ActionCable Rebroadcasting a Message documentationJoseph Mullins2016-07-121-1/+1
| |/ / | | | | | | | | | Replace broadcast_to with ActionCable.server.broadcast to be inline with its partner, #stream_from
* | | Fix documentation of `error_on_ignored_order` optionPrathamesh Sonpatki2016-07-181-4/+4
| | | | | | | | | | | | - Followup of https://github.com/rails/rails/commit/451437c6f57e66cc7586ec966e530493927098c7
* | | Update references generation docs to exclude indexJosh Justice2016-07-161-2/+2
| | | | | | | | | | | | | | | | | | In #23179 the migration generator was changed to no longer output `index: true` for `references` migrations. This updates the migrations guide to remove `index: true` from relevant examples. [ci skip]