| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
These methods may cause confusion with the `reset_changes` that
behaves differently
of them.
Also rename undo_changes to restore_changes to match this new set of
methods.
|
|/ /
| |
| |
| | |
Also updated the test case to reflect that
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Leave two blank lines between sections/packages for readibility.
* Always indent bullet points with four spaces. This allows multi-paragraph
points to align properly (see #16103), and it is the same as the format we
already use in CHANGELOGs. Doing this consistently sets an easy precedent
for future contributors to follow.
* Always put the PR/commit link on its own line in the source. If the bullet
point spans multiple paragraphs, put it on its own paragraph at the end.
[Godfrey Chan & Juanito Fatas]
|
|\
| |
| |
| |
| | |
Conflicts:
activerecord/lib/active_record/base.rb
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 0f6b101e09d210cea2494c5d4225760f1951ea67.
Reason: It's better to let `unscope` be documented. We can add a
separate section for `except`.
|
| | |
|
| |
| |
| |
| | |
The example showed is `except`, however the method "documented" is `unstop`. Fix to align the docs to the example.
|
| |
| |
| |
| | |
Also use appropriate mailer syntax in the `find_each` block.
|
| |
| |
| |
| | |
Put all options for overloading `find` in one section
|
| |
| |
| |
| |
| |
| | |
Add docs on what happens when a numerical argument is provided to last.
Since `last!` behaves exactly the same way but can raise an argument we can consolidate it in the `last` section.
|
| |
| |
| |
| |
| |
| | |
Add docs on what happens when a numerical argument is provided to take.
Since `take!` behaves exactly the same way but can raise an argument we can consolidate it in the `take` section.
|
| |
| |
| |
| | |
Since `find_by!` behaves exactly the same way but can raise an argument we can consolidate it in the `find_by` section.
|
| |
| |
| |
| |
| |
| | |
Add docs for `first` when provided a numerical argument.
Since `first!` behaves exactly the same way but can raise an argument we can consolidate it in the `first` section.
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
Also reordered some of the items to put newer ones on top (same order as
CHANGELOGs), which makes it easier to diff while we are still working on it.
|
| | |
|
| |
| |
| |
| | |
ActiveSupport::TimeWithZone#as_json
|
| | |
|
| | |
|
|\ \
| | |
| | | |
correct markdown usage [ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | | |
Add callbacks documentation for upgrading to 4.1.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The previous code example for the new explicit block requirement when
setting callbacks was a little confusing. This commit makes the example
more obvious.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It is now expected in 4.1 to use an explicit block rather than implicit
when setting callbacks through ActiveSupport::Callbacks. This commit
highlights this new expectation as part of the upgrading documentation.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As discussed in #15304, we need to automate this process but for now,
having out-of-date versions is not ideal.
Since master targets 4.2.0, let's also update references to the last 4.1
version to 4.2.0.
Finally, let's remove mentions to versions when this is not needed. The
guides cover the features of the current version anyway.
[Juanito Fatas + Robin Dupret]
|
|\ \ \
| | | |
| | | | |
[ci skip] add guide for ActiveModel::Naming
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] link directly to ActionMailer Previews documentation
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
This way when we do next release notes, this would be easier to copy and change.
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Removed mentions of non-existent methods, also added a mention for
`Date.current`, which is analagous to `Time.current`. Closes #16061.
|
| | | | | |
|
| | | | | |
|
|/ / / / |
|
| | | | |
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This should prevent some anxiety readers may experience when the doc goes into something different than what it just explained. Also clarifies a statement about priority in engines and application environments
[ci skip] fixes double `the`
[ci skip] more clarifications
[ci skip] changes from tics to quotes
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
lengarvey/add_configuration_option_for_mail_preview
Add configuration to enable mail previews
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Adds `config.action_mailer.preview_enabled`
This allows mail previewing to be enabled easily in non-development
environments such as staging. The default is set to true for development
so no changes should be required to existing Rails applications.
The mail preview path can still be configured using the existing
`config.action_mailer.preview_path` configuration option.
Adding this avoids devs from having to do stuff like:
https://gist.github.com/lengarvey/fa2c9bd6cdbeba96526a
Update actionmailer/CHANGELOG with new configuration.
Update configuring guide with new configuratation.
Add `config.action_mailer.preview_path` to configuring guide.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently there is no implicit conversion for Mail::Body to string
therefore .to_s must be applied. This is exampled in 10.2.2.
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Add punctuation and fix capitalization in Getting Started guide
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix more small grammar mistakes in the [Getting Started guide](http://edgeguides.rubyonrails.org/getting_started.html#security), in sections 9 and 10.
Specifically, within sections 9.1 “Basic Authentication”, 9.2 “Other Security Considerations”, and 10 “What's Next?”.
“Rails Guides” is generally capitalized on the site, including on the linked page and in the title of the site, so I capitalized it.
“The” is not part of the name of the Ruby on Rails Security Guide – “The” is not in the title on that page.
And I added a missing period and a missing colon at the ends of two sentences.
|
|\ \ \
| |/ /
|/| | |
[ci skip] Fix router option reference in 4.2 release notes.
|
| | | |
|