| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
'ActiveSupport::Notifications::Fanout::Subscribers::MonotonicTimed' and 'ActiveSupport::Notifications::monotonic_subscribe'
Also, change the signature of ‘ActiveSupport::Notifications::Fanout#subscribe’ to accept optional ‘monotonic’ boolean argument. Then initialize either a ‘Timed’ or ‘MonotonicTimed’ subscriber based on the value of ‘monotonic’ parameter.
Introduce ‘ActiveSupport::Notifications::monotonic_subscribe’ method
Also, provision ‘ActiveSupport::Notifications::subscribed’ to optionally accept ‘monotonic’ boolean argument.
Update documentation for ActiveSupport::Notifications
Add tests
Update guides documentation under the 'Active Support Instrumentation' chapter
Incorporate feedback: use optional keyword argument to specify optional 'monotonic' option to 'subscribed' method
Fix a typo
|
|/ / / / / |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
In #36047 we moved `take_failed_screenshot` from an `after_teardown`
hook to a `before_teardown` hook. However, I didn't realize the Testing
rails guide was explicitly mentioning that it happened inside
`after_teardown`. So this updates the docs to be consistent with that
change.
[ci skip]
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Update directory name in example commands [ci skip]
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
[ci skip]
|
| |_|/ /
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In the Action Text guides, `app/assets/stylesheets/actiontext.css`
is specified as the file used to style the Action Text editor and
content but the actual file generated from `rails action_text:install`
is `app/assets/stylesheets/actiontext.scss`.
This change simply corrects the file extension shown in the guide.
|
| | | |
| | | |
| | | |
| | | | |
Co-Authored-By: प्रथमेश Sonpatki <csonpatki@gmail.com>
|
| | | |
| | | |
| | | | |
Co-Authored-By: prathamesh-sonpatki <csonpatki@gmail.com>
|
| |/ /
|/| | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Add Release Notes for Active Storage
|
| | | |
| | | |
| | | |
| | | | |
Co-authored-by: Abhay Nikam <nikam.abhay1@gmail.com>
|
|\ \ \ \
| | | | |
| | | | | |
Active Model release notes [ci skip]
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
Updates to getting started per Rails 6.0 changes [ci skip]
|
| |/ / / |
|
|/ / /
| | |
| | |
| | | |
This gem has not been updated since April 2014 and 2 of the 4 methods it introduces have been broken since Rails 4
|
| | | |
|
|\ \ \
| | | |
| | | | |
[ci skip] Add 6.0 Release Notes for Action View
|
| | | |
| | | |
| | | |
| | | | |
I've added release notes based off of the CHANGELOG for Action View.
|
|/ / /
| | |
| | | |
The example functional test lists the 'create' route as article_url rather than articles_url
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The model generator code sample used in the command line guides
was displaying an outdated output for the generator's usage.
This change updates the sample to mirror what's currently output
when running `$rails generate model`.
|
| | |
| | |
| | |
| | |
| | |
| | | |
I've gone through the CHANGELOG for Action Pack, pulled out anything
that was backported, rephrased some of the descriptions and found their
PR's/commits as links.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| |_|/
|/| | |
Model error as object
|
| | |
| | |
| | |
| | | |
Revert some tests to ensure back compatibility
|
|\ \ \
| | | |
| | | | |
Update document about perform_caching's default value [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Clarify that both `config.action_controller.perform_caching` and
`config.action_mailer.perform_caching`'s default are `true`. This
default is set in `AbstractController::Caching`.
One can verify this by commenting out all
```
@controller.perform_caching = true
```
in `actionpack/test/controller/caching_test.rb` and run the tests. They
should still pass.
|
|/ / /
| | |
| | |
| | | |
[skip ci]
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
albertoalmagro/finish-documentation-for-after-save-commit
Remove reminiscences from previous documentation
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In #35861 documentation for `after_save_commit` was added, but also old
documentation was adapted. I think adapting the old documentation is not
necessary because there are already examples for `after_commit` on
`:destroy` above. On top of that the action invoked by the callback on
`:destroy` (`:log_user_saved_to_db`) talks about saving when the object
is destroyed, which can be misleading.
As I believe the documentation added by #35861 is already enough this
patch removes the modified part, which made sense before adding docs for
`after_save_commit` but is already covered by other parts of this guide.
|
|\ \ \ \
| | | | |
| | | | | |
Add ActionController::Caching into api app's document [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Rails doesn't support view caching in api controllers by default but the
document didn't clearerly declare this nor the manual config needed
after including the module manually. So we'll see people get confused
like #35602.
|
| |/ / /
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In Rails updating an Active Storage relation will now replace the entire
association instead of merely adding to it.
https://github.com/rails/rails/issues/35817#issuecomment-485512520
Fixes #35817
cc @georgeclaghorn
|
| | | | |
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
ActiveJob time argument assertion documentation
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
skip]
Hooks added:
- `service_download_chunk.active_storage`
- `service_update_metadata.active_storage`
- `preview.active_storage`
|