aboutsummaryrefslogtreecommitdiffstats
path: root/guides/source
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-10-042-2/+2
|\ \ \ \ \ \ \ \ \
| * | | | | | | | | [ci skip] Add `:` before code blocks.yui-knk2015-09-251-1/+1
| | | | | | | | | |
| * | | | | | | | | Add a missing period to layouts_and_rendering.md [ci skip]Juanito Fatas2015-09-241-1/+1
| | | | | | | | | |
* | | | | | | | | | Revert "removing Rack::Runtime from the default stack."Aaron Patterson2015-10-033-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 37423e4ff883ad5584bab983aceb4b2b759a1fd8. Jeremy is right that we shouldn't remove this. The fact is that many engines are depending on this middleware to be in the default stack. This ties our hands and forces us to keep the middleware in the stack so that engines will work. To be extremely clear, I think this is another smell of "the rack stack" that we have in place. When manipulating middleware, we should have meaningful names for places in the req / res lifecycle **not** have engines depend on a particular constant be in a particular place in the stack. This is a weakness of the API that we have to figure out a way to address before removing the constant. As far as timing attacks are concerned, we can reduce the granularity such that it isn't useful information for hackers, but is still useful for developers.
* | | | | | | | | | Fixed deprecated string to specify the middleware [ci skip]amitkumarsuroliya2015-10-031-1/+1
| |/ / / / / / / / |/| | | | | | | |
* | | | | | | | | Merge pull request #21851 from y-yagi/use_class_to_specify_middlewareKasper Timm Hansen2015-10-031-5/+5
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | use class to specify the middleware [ci skip]
| * | | | | | | | | use class to specify the middleware [ci skip]yuuji.yaginuma2015-10-031-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | using string for middleware class names is deprecated in 83b767cef90abfc4c2ee9f4b451b0215501fae9a
* | | | | | | | | | removing Rack::Runtime from the default stack.Aaron Patterson2015-10-023-3/+1
|/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The runtime header is a potential target for timing attacks since it returns the amount of time spent on the server (eliminating network speed). Total time is also not accurate for streaming responses. The middleware can be added back via: ```ruby config.middleware.ues ::Rack::Runtime ```
* | | | | | | | | Refactor AS::Callbacks halt config and fix the documentationRoque Pinel2015-10-012-12/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move from `AS::Callbacks::CallbackChain.halt_and_display_warning_on_return_false` to `AS::Callbacks.halt_and_display_warning_on_return_false` base on [this discussion](https://github.com/rails/rails/pull/21218#discussion_r39354580) Fix the documentation broken by 0a120a818d413c64ff9867125f0b03788fc306f8
* | | | | | | | | Fix documentation for has_many dependant options.Niall Burkley2015-09-291-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * A `has_many` dependant association accepts `[:destroy, :delete_all, :nullify, :restrict_with_error, :restrict_with_exception]` as options. Currently the documentation references `delete` instead of `delete_all` * Adds documentation for other options
* | | | | | | | | Make fuzzy sentence more clearDavid Verhasselt2015-09-281-1/+1
| |_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | Merge pull request #21738 from cllns/remove-to_s-from-exampleEileen M. Uchitelle2015-09-251-19/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | [Engines Guide] Remove to_s example, since it's outside the scope
| * | | | | | | | Remove to_s exampleSean Collins2015-09-241-19/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's outside the scope of the Engines guide [skip ci]
* | | | | | | | | Merge pull request #21740 from cllns/add-jbuilder-notesYves Senn2015-09-241-0/+33
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] [Action View Overview Guide] Add note about Jbuilder
| * | | | | | | | | Add note about JbuilderSean Collins2015-09-231-0/+33
| |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | [skip ci]
* / / / / / / / / Change the paths for both Gemfile lines to be 'engines/blorgh'Sean Collins2015-09-231-2/+2
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | They're now consistent. Also changes the quotes to be single, so we only have one type of quote per line [skip ci]
* | | | | | | | Remove leading slash from pathSean Collins2015-09-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The leading slash denotes an absolute path, rather than a relative one (which is more popular) [ci skip]
* | | | | | | | Update i18n.md [ci skip]Thiago Augusto2015-09-221-2/+2
| | | | | | | |
* | | | | | | | Update routing.mdThiago Augusto2015-09-221-2/+2
| | | | | | | |
* | | | | | | | fix `to_time` output in ActiveSupport guide. Since ↵amitkumarsuroliya2015-09-201-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/commit/48583f8bf74d1cefefea3cd6591bd546a9eaff6c , to_time returns times formatted as YYYY-MM-DD HH:MM:SS UTC [ci skip] `to_time` method returns in `YYYY-MM-DD HH:MM:SS UTC` format after this commit https://github.com/rails/rails/commit/48583f8bf74d1cefefea3cd6591bd546a9eaff6c .
* | | | | | | | correcting word smpt -> smtp in ActionMailer guide [ci skip]amitkumarsuroliya2015-09-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | `smpt.gmail.com` should be `smtp.gmail.com`
* | | | | | | | remove association reload option from guide [ci skip]yuuji.yaginuma2015-09-201-12/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The option was deprecated in 6eae366d0d2e5d5211eeaf955f56bd1dc6836758
* | | | | | | | Replace `#=>` with `# =>` [ci skip]amitkumarsuroliya2015-09-192-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | @rafaelfranca suggested in https://github.com/rails/rails/commit/f7c7bcd9c2a8b0e8c2840295d001d2d4dfd4cfae that code examples should display the result after `# =>` and not after `#=>`.
* | | | | | | | Fixed unclosed tags in kindle guide source [ci skip]Ronak Jangir2015-09-192-6/+6
| | | | | | | |
* | | | | | | | mostly remove the ParamsParser middlewareAaron Patterson2015-09-184-11/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This can still be added to the middleware stack, but is really not necessary. I'll follow up with a commit that deprecates the constant
* | | | | | | | let the guides home point to the new release series endpoints [ci skip]Xavier Noria2015-09-181-5/+5
|/ / / / / / /
* | | | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-09-181-5/+5
|\ \ \ \ \ \ \
| * | | | | | | Add missing and remove unnecessary periods in testing.md [ci skip]Juanito Fatas2015-09-051-5/+5
| | | | | | | |
* | | | | | | | Change AbstractRequest to ActionDispatch::RequestBradley D2015-09-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | AbstractRequest has been deprecated, updating to refer to ActionDispatch::Request instead. [ci skip]
* | | | | | | | Clarify CSRF <script> purpose and protection. Note how to deal with your own ↵Jeremy Daer2015-09-162-6/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | <script> tags. Ref #21618 [ci skip]
* | | | | | | | Merge pull request #21644 from AvnerCohen/i18n_backendClaudio B.2015-09-161-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Update documentation to remove 'desirable' suggestion for what is not a clear cut approach
| * | | | | | | | Update documentation to remove 'desirable' suggestion for what is not a ↵Avner Cohen2015-09-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | clear cut approach
* | | | | | | | | Merge pull request #21618 from designgrill/masterEileen M. Uchitelle2015-09-162-5/+3
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | Improved explanation of the <script> tag CSRF behavior
| * | | | | | | | Improved explanation of the <script> tag CSRF behaviorAnshul Agrawal2015-09-142-5/+3
| | | | | | | | |
* | | | | | | | | Merge pull request #20897 from lukechesser/guide-fix-for-acceptance-validationArthur Nogueira Neves2015-09-141-3/+7
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | Update Validation guide for acceptance method
| * | | | | | | | Update validation guide for acceptance methodLuke Chesser2015-07-161-3/+7
| | | | | | | | |
* | | | | | | | | Merge pull request #21568 from amitsuroliya/mysql_version_updateRafael Mendonça França2015-09-131-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Updated MySQL documentation link to MySQL latest version 5.7 everywhe…
| * | | | | | | | | Updated MySQL documentation link to MySQL latest version 5.7 everywhere [ci ↵amitkumarsuroliya2015-09-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | skip] Bumps from `5.6` to `5.7`
* | | | | | | | | | Remove RHTML reference in Action Controller docs [ci skip]Lachlan Campbell2015-09-101-1/+1
| |_|_|_|_|_|_|_|/ |/| | | | | | | |
* | | | | | | | | add description of passing a block to `add_source` [ci skip]yuuji.yaginuma2015-09-101-1/+9
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | block support added in 8cc01e0b2bfa75a613720c535d34e451f5de769c
* | | | | | | | Merge pull request #21333 from imtayadeway/ar-querying-docsEileen M. Uchitelle2015-09-091-17/+16
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Improve the AR querying docs
| * | | | | | | | [ci skip] Update MySQL docs reference to latestTim Wade2015-09-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps to 5.7
| * | | | | | | | [ci skip] Improve readability in AR querying guideTim Wade2015-09-091-16/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * rewords a few awkwardly worded sentences * adds some punctuation * adds a few missing words
* | | | | | | | | Merge pull request #21512 from X0nic/guides-clarify-timeout-errorYves Senn2015-09-081-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | [Rails Guides] clarify `ActiveRecord::ConnectionTimeoutError`
| * | | | | | | | | [Rails Guides] clarify `ActiveRecord::ConnectionTimeoutError`Nathan Lee2015-09-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original: * ActiveRecord::ConnectionTimeoutError - could not obtain a database connection within 5 seconds. The max pool size is currently 5; consider increasing it: Modified version: * ActiveRecord::ConnectionTimeoutError - could not obtain a database connection within 5.000 seconds (waited 5.000 seconds) [ci skip]
* | | | | | | | | | Replace AR with ActiveRecord to make it more readable [ci skip]arvind2015-09-081-1/+1
| | | | | | | | | |
* | | | | | | | | | Merge pull request #21534 from Vratislav/clarify-custom-config-guideRafael Mendonça França2015-09-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Rails Guides] Clarify custom code configuration [ci skip]
* | | | | | | | | | Removed Extra ‘the’ [ci skip]Ronak Jangir2015-09-061-1/+1
|/ / / / / / / / /
* | | | | | | | | fix module name typo in API app guide [ci skip]yuuji.yaginuma2015-09-041-1/+1
| | | | | | | | |
* | | | | | | | | add a description of the return value that was missing [ci skip]yuuji.yaginuma2015-09-031-1/+1
| | | | | | | | |