| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|\
| |
| | |
Make it same title in index and page [ci skip]
|
| | |
|
| | |
|
|/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The initial commit (efaa6e4f79d457c2cdd08cbc56d63bc972a6993c) that changed this
behavior was intended to be a minor change, but ended up becoming a
large-ish breaking change within Active Record.
This is because instead of only JSON encoding `Hash`es or `Array`s in `#serialize`,
we now encode all values passed in. This is an issue if you're passing in a `String`,
that has already been transformed from a `Hash` to a `String`, since your data
is now being double encoded.
Unfortunately, the change was included in one of the v5.0.0 beta
releases, and it is too late to revert without huge ripple effects.
Thus, all we can do is update the documentation (via this commit), and
add some test coverage (coming soon in a PR) for the new behavior.
Please note that in the documentation I talk about deserialization, not
about serialization, where the actual change occurred. This is because
you won't notice any changes in serialized data until you try and
deserialize it. Also to make the change itself (confusing until you
read through everything multiple times) easier to understand.
Related #27788, #25594, #26101, #24234, #28292, #28285, #28285, and
probably others.
[ci skip]
|
|
|
|
|
|
| |
`it` and `has` are for singular, not plural
[ci skip]
|
|
|
|
| |
`ActionView::Helpers::RecordTagHelper`
|
|
|
|
| |
slice as this has actually been implemented by Parameters
|
|
|
|
| |
The `secrets` method is in `Application` class, not `Configuration` class.
|
|
|
|
| |
[ci skip]
|
| |
|
|
|
|
|
| |
This is a small breaking change that we chose to make in 5.1 since the
fix can be done with a search and replace tool.
|
| |
|
|
|
|
|
|
|
| |
Since using a `ActiveSupport::Deprecation::DeprecatedConstantProxy`
would prevent people from inheriting this class and extending it
from the `ActiveSupport::HashWithIndifferentAccess` one would break
the ancestors chain, that's the best option we have here.
|
|\
| |
| | |
Add note about breakage in file uploads in controller tests to upgrading guide
|
| |
| |
| |
| |
| |
| |
| |
| | |
guide
ref #26404
[ci skip]
|
|/ |
|
|
|
|
|
|
|
|
|
| |
jeremywadsack/doc_cache_importability""
This reverts commit 6961afefd2f163f30b9ae3aacb74b290287f9a80.
We were not able to keep backward compatibility in this case so it is
better to ask people to upgrade with cold cache.
|
| |
|
|\
| |
| | |
Consistent examples and template for assets#precompile
|
| |
| |
| |
| |
| |
| |
| |
| | |
Listening to a few developers today discussing their troubles in understanding how to use the asset pipeline, it turns out that the precompile examples in the guides and assets.rb template have over time become a bit inconsistent.
This PR makes the examples consistent in code style, spacing, and asset names, removes the old 'swfObject.js' example, and in a couple of places wraps lines at 80 characters including in the assets.rb template.
Re-add spaces inside array parentheses.
|
|\ \
| | |
| | | |
Clarify migration to ApplicationRecord in upgrade guides [ci skip]
|
| | | |
|
|/ / |
|
| |
| |
| |
| |
| |
| | |
Reason: See https://github.com/rails/rails/pull/26163#issuecomment-239703322
This reverts commit 39effc857e5c774670d6fad1a26aebcc33c51f0a.
|
|/
|
|
|
|
|
|
|
|
|
|
| |
The Guides section about autoloading being disabled was slightly confusing
(#24724) and didn't directly reference the removed feature by name
(config.autoload_paths) making it much harder for someone to search the upgrade
guides for a mention or serendipitously find it via a Google search when running
into autoloading issues.
I also fixed some confusing turns of phrase and a missing word.
/cc @vipulnsward @jvanbaarsen
|
|
|
| |
Fix a small typo on doc: "caches_pages" -> "caches_page".
|
| |
|
|
|
|
|
| |
See issue #25581:
https://github.com/rails/rails/issues/25581
|
|
|
|
|
|
| |
From the style guide:
When writing headings, capitalize all words except for prepositions,
conjunctions, internal articles, and forms of the verb "to be":
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
guide [ci skip]
- Also to_time_preserves_timezone config should be false for older apps getting upgraded to Rails 5 [ci skip]
|
|
|
|
|
| |
Mentions missing config options and fixes headers for section talking
about new framework defaults.
|
| |
|
|\
| |
| | |
Pass over Upgrading guide
|
| | |
|
|/
|
|
|
| |
It's useful to have a link to the release notes in the upgrade guide for
a clearer view of what changed in Rails.
|
|
|
|
|
| |
Adds missing upgrade items to the upgrade guides for Rails 5. Fixes some
typos and whitespace as well.
|
|
|
|
|
|
|
|
| |
Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005
* Forward compat with new unified Integer class in Ruby 2.4+.
* Backward compat with separate Fixnum/Bignum in Ruby 2.2 & 2.3.
* Drops needless Fixnum distinction in docs, preferring Integer.
|
|\
| |
| |
| |
| | |
Conflicts:
guides/source/configuring.md
|
| |
| |
| |
| |
| |
| | |
- Change from "The Task" to "The Update Task" as referred elsewhere
[ci skip]
|
| | |
|
|/
|
|
| |
[ci skip]
|
| |
|
| |
|