| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005
* Forward compat with new unified Integer class in Ruby 2.4+.
* Backward compat with separate Fixnum/Bignum in Ruby 2.2 & 2.3.
* Drops needless Fixnum distinction in docs, preferring Integer.
|
|\
| |
| |
| |
| | |
Conflicts:
guides/source/configuring.md
|
| |
| |
| |
| |
| |
| | |
- Change from "The Task" to "The Update Task" as referred elsewhere
[ci skip]
|
| | |
|
|/
|
|
| |
[ci skip]
|
| |
|
| |
|
|
|
|
| |
`rails:update` was deprecated in 6fb31638c8b61731103d4963272755b217a2df87
|
|
|
|
|
|
|
|
|
|
|
|
| |
This guides were pointing to this command `rails app:update`, which I
tried to run, but it didnt worked. I think the right command is `rails
rails:update` instead. Also thats the name of the rake task.
Also I removed the `Rake` word from the title, as we run it using
`rails` bin now.
cc @kaspth
[skip ci]
|
|
|
|
| |
(e.g. `rails:update` and `rails:template` tasks is renamed to `app:update` and `app:template`.)
|
| |
|
| |
|
|
|
|
| |
[ci skip]
|
|
|
|
|
|
|
|
| |
The iterative process one has to follow is not currently documented, and
people could be unfamiliar with the Rails versioning scheme, causing
them to skip versions or upgrade to patch releases.
[ci skip]
|
| |
|
| |
|
|
|
|
|
| |
xref #22701.
xref #20612.
|
| |
|
| |
|
|
|
|
| |
[ci skip]
|
|
|
|
|
| |
The previous title was misleading.
[ci skip]
|
|
|
|
|
|
|
|
| |
Should use `public_file_server.enabled` instead.
Clarified that static files will be served from the public directory, where it made sense.
Also removed occurrence of the deprecated `static_cache_control`.
|
| |
|
|
|
|
|
|
|
|
|
| |
Move from `AS::Callbacks::CallbackChain.halt_and_display_warning_on_return_false`
to `AS::Callbacks.halt_and_display_warning_on_return_false` base on
[this
discussion](https://github.com/rails/rails/pull/21218#discussion_r39354580)
Fix the documentation broken by 0a120a818d413c64ff9867125f0b03788fc306f8
|
|
|
|
|
|
|
|
| |
<script> tags.
Ref #21618
[ci skip]
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
supported only
|
|\ |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The has_and_belongs_to_many default join_table behavior changed
between Rails 3.2 and Rails 4.0 and should be noted in the
appropriate section of the upgrade guide.
commit:
https://github.com/rails/rails/commit/46492949b8c09f99db78b9f7a02d039e7bc6a702
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is a squash of the following commits, from first to last:
-
Fix minor, random things I’ve come across lately that individually
did not seem worth making a PR for, so I saved them for one commit.
One common error is using “it’s” (which is an abbreviation of “it is”)
when the possessive “its” should be used for indicating possession.
-
Changes include the name of a test, so remove the `[skip ci]` (thanks @senny).
-
Line wrap the changes at 80 chars and add one more doc fix.
-
Add a missing line wrap in the Contributing to Ruby on Rails Guide.
-
Line wrap the `TIP` section in the Contributing to Ruby on Rails Guide as well.
Rendering the guide locally with `bundle exec rake guides:generate` did
not show any change in on-screen formatting after adding the line wrap.
The HTML generated is (extra line added to illustrate where the line
wrap takes place):
<div class="info"><p>Please squash your commits into a single commit
when appropriate. This
simplifies future cherry picks and also keeps the git log
clean.</p></div>
-
Squash commits.
|
|\ \
| |/
|/| |
Upgrade to Ruby 2.2.2
|
| |
| |
| |
| | |
and fix the grammar in the ruby_version_check.rb user message.
|
|/ |
|
|
|
|
|
|
|
|
| |
* Jobs generated now inherent from ApplicationJob
* ApplicationJob inherents from ActiveJob::Base
* Added entry to changelog
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
|
|
|
|
| |
Since there was a bug in 2.2.0, the minimum ruby requirement is 2.2.1. See https://github.com/rails/rails/commit/8ed0b89b
[skip ci]
|
|\
| |
| |
| |
| |
| |
| |
| | |
andreynering/add-foreign-key-subsection-in-upgrading-guide
Adding subsection on 'Upgrading' guide about foreign key support
[ci skip]
|
|/ |
|
|
|
|
|
|
| |
[ci skip]
ref https://bugs.ruby-lang.org/issues/8846
|
|
|
|
| |
- Changed `IN` to `ON` in all note sentences in guides.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This stems from [a comment](rails#17227 (comment)) by @dhh.
In summary:
* New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning.
* Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning.
For this purpose, this commit introduces a Rails configuration option:
```ruby
config.active_support.halt_callback_chains_on_return_false
```
For new Rails 5.0 apps, this option will be set to `false` by a new initializer
`config/initializers/callback_terminator.rb`:
```ruby
Rails.application.config.active_support.halt_callback_chains_on_return_false = false
```
For existing apps ported to Rails 5.0, the initializers above will not exist.
Even running `rake rails:update` will not create this initializer.
Since the default value of `halt_callback_chains_on_return_false` is set to
`true`, these apps will still accept `return true` as a way to halt callback
chains, displaying a deprecation warning.
Developers will be able to switch to the new behavior (and stop the warning)
by manually adding the line above to their `config/application.rb`.
A gist with the suggested release notes to add to Rails 5.0 after this
commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
|
| |
|
|
|
|
|
|
| |
Arguments of Bundler.require of generator has been changed from rails4.0.4.
https://github.com/rails/rails/blob/v4.0.4/railties/lib/rails/generators/rails/app/templates/config/application.rb#L16
|
|
|
|
| |
References #18148.
|
| |
|
| |
|