| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a squash of the following commits, from first to last:
-
Fix minor, random things I’ve come across lately that individually
did not seem worth making a PR for, so I saved them for one commit.
One common error is using “it’s” (which is an abbreviation of “it is”)
when the possessive “its” should be used for indicating possession.
-
Changes include the name of a test, so remove the `[skip ci]` (thanks @senny).
-
Line wrap the changes at 80 chars and add one more doc fix.
-
Add a missing line wrap in the Contributing to Ruby on Rails Guide.
-
Line wrap the `TIP` section in the Contributing to Ruby on Rails Guide as well.
Rendering the guide locally with `bundle exec rake guides:generate` did
not show any change in on-screen formatting after adding the line wrap.
The HTML generated is (extra line added to illustrate where the line
wrap takes place):
<div class="info"><p>Please squash your commits into a single commit
when appropriate. This
simplifies future cherry picks and also keeps the git log
clean.</p></div>
-
Squash commits.
|
|\
| |
| | |
Upgrade to Ruby 2.2.2
|
| |
| |
| |
| | |
and fix the grammar in the ruby_version_check.rb user message.
|
|/ |
|
|
|
|
|
|
|
|
| |
* Jobs generated now inherent from ApplicationJob
* ApplicationJob inherents from ActiveJob::Base
* Added entry to changelog
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
|
|
|
|
| |
Since there was a bug in 2.2.0, the minimum ruby requirement is 2.2.1. See https://github.com/rails/rails/commit/8ed0b89b
[skip ci]
|
|\
| |
| |
| |
| |
| |
| |
| | |
andreynering/add-foreign-key-subsection-in-upgrading-guide
Adding subsection on 'Upgrading' guide about foreign key support
[ci skip]
|
|/ |
|
|
|
|
|
|
| |
[ci skip]
ref https://bugs.ruby-lang.org/issues/8846
|
|
|
|
| |
- Changed `IN` to `ON` in all note sentences in guides.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This stems from [a comment](rails#17227 (comment)) by @dhh.
In summary:
* New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning.
* Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning.
For this purpose, this commit introduces a Rails configuration option:
```ruby
config.active_support.halt_callback_chains_on_return_false
```
For new Rails 5.0 apps, this option will be set to `false` by a new initializer
`config/initializers/callback_terminator.rb`:
```ruby
Rails.application.config.active_support.halt_callback_chains_on_return_false = false
```
For existing apps ported to Rails 5.0, the initializers above will not exist.
Even running `rake rails:update` will not create this initializer.
Since the default value of `halt_callback_chains_on_return_false` is set to
`true`, these apps will still accept `return true` as a way to halt callback
chains, displaying a deprecation warning.
Developers will be able to switch to the new behavior (and stop the warning)
by manually adding the line above to their `config/application.rb`.
A gist with the suggested release notes to add to Rails 5.0 after this
commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
|
| |
|
|
|
|
|
|
| |
Arguments of Bundler.require of generator has been changed from rails4.0.4.
https://github.com/rails/rails/blob/v4.0.4/railties/lib/rails/generators/rails/app/templates/config/application.rb#L16
|
|
|
|
| |
References #18148.
|
| |
|
| |
|
|
|
|
| |
[ci skip]
|
|
|
|
|
|
| |
Closes #17965, #17968
[Godfrey Chan, Miklós Fazekas]
|
|
|
|
|
|
|
|
| |
This reverts commit b0e7278ddbe483475d7b2e161e65ae18df91b9f8, reversing
changes made to 785d04e3109f69d0b9b9f4732179592f0ef04e52.
This is not true. It is a bug and we will fix in the latest 4.0.x
release.
|
|\
| |
| | |
[ci skip] update rails version to 3.2.21
|
| | |
|
|/
|
|
| |
between 3.2 and 4.0
|
|
|
|
|
| |
This one replaces the notable web-console mentions in guide and the
default Gemfile.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
| |
Update to consistently use American English [ci skip]
|
|
|
|
| |
- Everywhere else we using HTML Sanitizer except this place.
|
|\
| |
| | |
Masked authenticity token section, finder options details, misc typos [ci skip]
|
| |
| |
| |
| | |
[ci skip]
|
|/
|
|
| |
section 2.8 "Rails DOM Testing"
|
|
|
| |
[ci skip]
|
| |
|
|
|
|
|
| |
- [ci skip]
- behvaior -> behavior
|
|
|
|
| |
Also add to upgrading guide a notice about the deprecated sanitizers
|
| |
|
| |
|
|\
| |
| |
| | |
Default to sorting user's test cases for now
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Goals:
1. Default to :random for newly generated applications
2. Default to :sorted for existing applications with a warning
3. Only show the warning once
4. Only show the warning if the app actually uses AS::TestCase
Fixes #16769
|
| | |
|
| |
| |
| | |
minor fix for #16846
|
|\ \
| | |
| | |
| | |
| | | |
prathamesh-sonpatki/document-error-handling-in-transactions-callbacks
Update upgrading guide about error handling in transactional callbacks [ci skip]
|
| |/
| |
| |
| |
| | |
- Part of 16576
- [ci skip]
|
|/ |
|
| |
|
|
|
|
| |
Related: https://github.com/rails/rails/pull/16607
|
| |
|
| |
|