| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
[ci skip]
|
| |
|
|
|
|
|
|
|
| |
Change Rails engine guide to references a maintained project
Thredded instead of the abandoned project Forem. I chose
Thredded as Forem's closing note (below) suggests the choice.
https://github.com/rubysherpas/forem/blob/rails4/README.md
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Listening to a few developers today discussing their troubles in understanding how to use the asset pipeline, it turns out that the precompile examples in the guides and assets.rb template have over time become a bit inconsistent.
This PR makes the examples consistent in code style, spacing, and asset names, removes the old 'swfObject.js' example, and in a couple of places wraps lines at 80 characters including in the assets.rb template.
Re-add spaces inside array parentheses.
|
| |
|
|
|
| |
it reads a bit awkwardly without it.
|
|
|
|
|
|
|
|
| |
The `before_save` callback used with `set_author` results in the
validation error "Author must exist," due to the change in `belongs_to`
behavior introduced by #18937.
Use `before_validation` instead.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Using url helper method of engine in example code,
include `Engine.routes.url_helpers` is required to use helper method of engine.
|
|
|
| |
I go through the `http://edgeguides.rubyonrails.org/` and found `rake` commands in various files that are in RAILS 5.0 implement by `bin/rails` command. I try to change all that can be directly use `bin/rails …`
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's pretty common for folks to monkey patch `ActiveRecord::Base` to
work around an issue or introduce extra functionality. Instead of
shoving even more stuff in `ActiveRecord::Base`, `ApplicationRecord` can
hold all those custom work the apps may need.
Now, we don't wanna encourage all of the application models to inherit
from `ActiveRecord::Base`, but we can encourage all the models that do,
to inherit from `ApplicationRecord`.
Newly generated applications have `app/models/application_record.rb`
present by default. The model generators are smart enough to recognize
that newly generated models have to inherit from `ApplicationRecord`,
but only if it's present.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In Rails 5.1 `ActionController::TestCase` will be moved out of Rails
into it's own gem.
Please use `ActionDispatch::IntegrationTest` going foward.
Because this will be moved to a gem I used `# :stopdoc:` instead of
deleting the documentation. This will remove it from the Rails
documentation but still leave the method documented for when we move it
to a gem.
Guides have been updated to use the routing structure used in Integration
and all test examples have been updated to inherit from
`ActionDispatch::IntegrationTest` instead of `ActionController::TestCase.
Fixes #22496
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
[Engines Guide] Remove to_s example, since it's outside the scope
|
| |
| |
| |
| |
| |
| | |
It's outside the scope of the Engines guide
[skip ci]
|
|/
|
|
|
|
|
|
| |
They're now consistent.
Also changes the quotes to be single, so we only have one type of quote per line
[skip ci]
|
|
|
|
|
|
|
| |
The leading slash denotes an absolute path,
rather than a relative one (which is more popular)
[ci skip]
|
|
|
|
| |
This reverts commit 67e467b9a5c113177aff925f07136e9b7f2a1eda.
|
| |
|
| |
|
| |
|
|\ |
|
| | |
|
| | |
|
| | |
|
|/
|
|
| |
Closes #19492 and fixes #19453
|
|
|
|
|
|
|
| |
The Engines guide used an inline namespace, `Blorgh::ApplicationController`, which caused problems for users using an
explicit module namespace because the `ApplicationController` inherited from wasn't fully qualified.
The controller qualification was fixed in 661479324d573d419d8e15a1ea257e01856084af.
This ditches the inline namespace and makes the example more consistent with others in the guide.
|
| |
|
|
|
|
| |
- Changed `IN` to `ON` in all note sentences in guides.
|
|
|
|
| |
References #18148.
|
| |
|
|
|
|
| |
Reference #17453
|
|
|
|
| |
`bin/rails` would not exist outside of a rails project
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This should prevent some anxiety readers may experience when the doc goes into something different than what it just explained. Also clarifies a statement about priority in engines and application environments
[ci skip] fixes double `the`
[ci skip] more clarifications
[ci skip] changes from tics to quotes
|
| |
|
|\
| |
| | |
Moved explanation of `--mountable` option up
|
| |
| |
| | |
The example code uses `--mountable`. In previous version this was followed by an explanation of the `--full` option, which doesn't make sense. Later on in the text this is better explained. I moved this explanation up without repeating too much.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Cleaning up the list items that detail what an engines `--full` option
generates. Joining a multiline multi list item into a multiline single
list item.
[ci skip]
|
| | |
|
| | |
|