| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Engines guide in the Overriding Models and Controllers section
references the Decorator pattern, which isn't appropriate, since
Decorator pattern is not about reopening existing classes, is about
adding functionality to existing object instances; something that in
Ruby is commonly implemented using Delegators.
Moreover, the suggested naming convention for overrides,
`app/decorators/**/*_decorator*.rb`, conflicts with a naming convention
commonly used for View Model / Presentation Model decorators, adopted
by popular gems such as `draper`, as well as by custom implementations.
|
| | |
|
| |
|
|
| |
See actiontext/lib/action_text/content.rb:132
|
| | |
|
| | |
|
| |\
| |
| |
| |
| | |
albertoalmagro/albertoalmagro/prefer-rails-command-over-bin-rails
Prefer rails command over bin/rails
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
As discussed in #33203 rails command already looks for, and runs,
bin/rails if it is present.
We were mixing recommendations within guides and USAGE guidelines,
in some files we recommended using rails, in others bin/rails and
in some cases we even had both options mixed together.
|
| | |
| |
| |
| |
| | |
http links will be redirected to the https version, but still better to
just directly link to the https version.
|
| |/
|
|
|
|
| |
Be more specific when pointing out where the commands relating
to the engine should be run
[ci skip]
|
| |
|
|
| |
This fixes the location from where the command to copy migrations from the engine to the application should be run
[ci skip]
|
| |
|
|
|
|
|
| |
[ci skip] A regular expression was used to find a lot of missing Oxford
commas and add them. The regular expression was as follows.
", ([a-zA-Z0-9.\`:'\"]+ ){1,6}(or|and) "
|
| |
|
|
|
|
|
| |
Before Rails 4.0, `config.cache_classes` determined whether application
code was eager loaded. The `config.eager_load` option was introduced to
allow the two behaviours to be configured independently, but this
documentation was never updated to reflect that change.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
This is useful to extend `SystemTestCase`.
Also, since other test classes already have load hooks, should also be
in `SystemTestCase`.
Ref: 0510208dd1ff23baa619884c0abcae4d141fae53
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
* According to the official website, it seems that "RefineryCMS" is "Refinery CMS".
* See at: http://www.refinerycms.com/
|
| | |
|
| | |
|
| |
|
|
| |
[ci skip]
|
| | |
|
| |
|
|
|
|
|
| |
Change Rails engine guide to references a maintained project
Thredded instead of the abandoned project Forem. I chose
Thredded as Forem's closing note (below) suggests the choice.
https://github.com/rubysherpas/forem/blob/rails4/README.md
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
Listening to a few developers today discussing their troubles in understanding how to use the asset pipeline, it turns out that the precompile examples in the guides and assets.rb template have over time become a bit inconsistent.
This PR makes the examples consistent in code style, spacing, and asset names, removes the old 'swfObject.js' example, and in a couple of places wraps lines at 80 characters including in the assets.rb template.
Re-add spaces inside array parentheses.
|
| | |
|
| |
|
| |
it reads a bit awkwardly without it.
|
| |
|
|
|
|
|
|
| |
The `before_save` callback used with `set_author` results in the
validation error "Author must exist," due to the change in `belongs_to`
behavior introduced by #18937.
Use `before_validation` instead.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Using url helper method of engine in example code,
include `Engine.routes.url_helpers` is required to use helper method of engine.
|
| |
|
| |
I go through the `http://edgeguides.rubyonrails.org/` and found `rake` commands in various files that are in RAILS 5.0 implement by `bin/rails` command. I try to change all that can be directly use `bin/rails …`
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's pretty common for folks to monkey patch `ActiveRecord::Base` to
work around an issue or introduce extra functionality. Instead of
shoving even more stuff in `ActiveRecord::Base`, `ApplicationRecord` can
hold all those custom work the apps may need.
Now, we don't wanna encourage all of the application models to inherit
from `ActiveRecord::Base`, but we can encourage all the models that do,
to inherit from `ApplicationRecord`.
Newly generated applications have `app/models/application_record.rb`
present by default. The model generators are smart enough to recognize
that newly generated models have to inherit from `ApplicationRecord`,
but only if it's present.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In Rails 5.1 `ActionController::TestCase` will be moved out of Rails
into it's own gem.
Please use `ActionDispatch::IntegrationTest` going foward.
Because this will be moved to a gem I used `# :stopdoc:` instead of
deleting the documentation. This will remove it from the Rails
documentation but still leave the method documented for when we move it
to a gem.
Guides have been updated to use the routing structure used in Integration
and all test examples have been updated to inherit from
`ActionDispatch::IntegrationTest` instead of `ActionController::TestCase.
Fixes #22496
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |\
| |
| | |
[Engines Guide] Remove to_s example, since it's outside the scope
|
| | |
| |
| |
| |
| |
| | |
It's outside the scope of the Engines guide
[skip ci]
|
| |/
|
|
|
|
|
|
| |
They're now consistent.
Also changes the quotes to be single, so we only have one type of quote per line
[skip ci]
|
| |
|
|
|
|
|
| |
The leading slash denotes an absolute path,
rather than a relative one (which is more popular)
[ci skip]
|
| |
|
|
| |
This reverts commit 67e467b9a5c113177aff925f07136e9b7f2a1eda.
|
| | |
|
