| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
The Numeric extensions like 1.day, 1.month, etc. shouldn't know
how the internals of ActiveSupport::Duration works.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
durations from code
ActiveSupport::Duration.parse('P3Y') == 3.years # It should be true
Duration parsing made independent from any moment of time:
Fixed length in seconds is assigned to each duration part during parsing.
Changed duration of months and years in seconds to more accurate and logical:
1. The value of 365.2425 days in Gregorian year is more accurate
as it accounts for every 400th non-leap year.
2. Month's length is bound to year's duration, which makes
sensible comparisons like `12.months == 1.year` to be `true`
and nonsensical ones like `30.days == 1.month` to be `false`.
Calculations on times and dates with durations shouldn't be affected as
duration's numeric value isn't used in calculations, only parts are used.
Methods on `Numeric` like `2.days` now use these predefined durations
to avoid duplicating of duration constants through the codebase and
eliminate creation of intermediate durations.
|
| |
|
| |
|
|
|
|
| |
[ci skip]
|
|
|
|
|
|
|
|
| |
* Several formatting fixes.
* Updated command outputs to latest version.
* Minor rewordings.
[ci skip]
|
| |
|
|
|
|
| |
refer 2dc3e81aea8dbc, 56ca2061df83a3
|
|
|
|
|
|
| |
Changed location for specifying logger.
[Prajakta, thiagoaugusto]
|
|
|
| |
Rails 5.0 default server puma web server. following commit - https://github.com/rails/rails/commit/ae48ea69
|
|
|
|
|
|
|
| |
This is a pass over the documentation which fills the missing gaps of
`ApplicationRecord`.
[ci skip]
|
|
|
|
|
|
|
|
| |
Update the valgrind debugging documentation to remove the notes about being
linux only as 3.11.0[1] introduces preliminary support for Mac OSX 10.11 (El
Capitan).
[1]: http://valgrind.org/docs/manual/dist.news.html
|
| |
|
|\
| |
| | |
Small fixes [ci skip]
|
| |
| |
| |
| |
| |
| | |
* fix command list for thread
* add omitted end of code
* fix description for `continue` and `finish` command
|
|/
|
|
|
|
|
|
|
|
|
|
| |
- Fixes:
"we want go deep" -> "we won't go deep"
"to next next line" -> "to the next line"
- Minor improvements in clarity and grammar.
Cheers :)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[skip ci].
- Update to the current output when running `byebug help`.
- Remove the alias `exit` because it does not work and seems to have
been removed from Byebug, as confirmed by the source code here:
https://github.com/deivid-rodriguez/byebug/blob/master/lib/byebug/comman
ds/quit.rb
- Added the useful `q!` instead to avoid the "Really quit? (y/n)"
prompt.
|
|
|
|
|
|
|
| |
Actions are processed through `dispatch`, so they should have the
request set on them before any user land code can be executed. Lets
stop setting _env on the controller, and give access to it through the
`env` method.
|
|
|
|
|
|
|
|
| |
- Found that checking instance_variables elements using string object
gives us 'false' value.
`instance_variables.include? "@articles" # => false`
- Used only 'instance_variables' instead of using '.include?' on it. So
that it will return recent instance variables list.
|
|
|
|
|
|
|
|
|
|
| |
spelling fix [ci skip]
example to be consistent [ci skip]
grammatical fix
typo fixes [ci skip]
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a squash of the following commits, from first to last:
-
Fix minor, random things I’ve come across lately that individually
did not seem worth making a PR for, so I saved them for one commit.
One common error is using “it’s” (which is an abbreviation of “it is”)
when the possessive “its” should be used for indicating possession.
-
Changes include the name of a test, so remove the `[skip ci]` (thanks @senny).
-
Line wrap the changes at 80 chars and add one more doc fix.
-
Add a missing line wrap in the Contributing to Ruby on Rails Guide.
-
Line wrap the `TIP` section in the Contributing to Ruby on Rails Guide as well.
Rendering the guide locally with `bundle exec rake guides:generate` did
not show any change in on-screen formatting after adding the line wrap.
The HTML generated is (extra line added to illustrate where the line
wrap takes place):
<div class="info"><p>Please squash your commits into a single commit
when appropriate. This
simplifies future cherry picks and also keeps the git log
clean.</p></div>
-
Squash commits.
|
| |
|
|\
| |
| | |
Nit pick the byebug settings guide for default values [ci skip]
|
| |
| |
| |
| |
| | |
In #19097 we had a discussion where we decided to change `byebug`
settings sections default part to actually say `defaults`.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the upcoming 2.1 [web-console release], I have tweaked the existing
documentation a bit. I tried to focus on the spawning console use case,
because I think a lot of people overlook that.
Tried to explain it as best as I can, however, my English and prose
aren't my best skills :) If you guys can chime in and help me improve
the wording, I would be extremely grateful.
There has been some configuration default changes. For example, the
whitelisted IPs always include IPv4 and IPv6 localhosts now and this
wasn't the case in 2.0. I think a lot of people got bitten by it, that's
why I changed it. I'm a bit confused on how to document this. Should I
just document the latest version, I don't think I can expect all the
people reading the guide to be on it.
[web-console release]: https://github.com/rails/web-console/pull/110
|
| |
|
|\
| |
| | |
Add web console in debugging rails applications guide [ci skip]
|
| |
| |
| |
| |
| |
| | |
document web console in debugging guide [ci skip]
document web console in debugging guide [ci skip]
|
| | |
|
|/
|
|
| |
improve sentence flow with grammar change
|
|
|
|
| |
- Changed `IN` to `ON` in all note sentences in guides.
|
| |
|
|
|
|
| |
References #18148.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As discussed in #15304, we need to automate this process but for now,
having out-of-date versions is not ideal.
Since master targets 4.2.0, let's also update references to the last 4.1
version to 4.2.0.
Finally, let's remove mentions to versions when this is not needed. The
guides cover the features of the current version anyway.
[Juanito Fatas + Robin Dupret]
|
| |
|
| |
|
| |
|
|
|
|
| |
This is a follow up to 545afc15.
|
|
|
|
| |
Tested on a brand new app to exactly match current byebug's behaviour.
|
| |
|
| |
|
| |
|
|
|
| |
[ci skip]
|
|\ |
|
| | |
|