aboutsummaryrefslogtreecommitdiffstats
path: root/guides/source/contributing_to_ruby_on_rails.md
Commit message (Collapse)AuthorAgeFilesLines
* Fix judgement spelling [ci skip]Carlos Gavino2017-01-281-1/+1
| | | | | `judgment` is the preferred form as Rails usually follows en-us spelling not en-gb.
* Mention ActiveRecord's config.example.ymlOlivier Lacan2017-01-191-4/+6
| | | | This will help people figure out what credentials and tables are required to run ActiveRecord specs.
* [ci skip] Fix typo in Guides: ContributingAlex Kitchens2016-10-171-1/+1
|
* Introduce a benchmark template [ci skip]Godfrey Chan2016-10-151-27/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This replaces boilerplate in the “benchmark your code” section of the contributors’ guide with an executable template. I also amended the text to encourage best practices and codified it in the template. For now this is only good for relatively self-contained changes that can be inlined into a simple script. In the future, this can be expanded to cover how to measure the difference between two commits. The output looks like this: ``` ==================================== Empty ===================================== Warming up -------------------------------------- blank? 225.963k i/100ms fast_blank? 238.147k i/100ms Calculating ------------------------------------- blank? 8.825M (± 6.4%) i/s - 44.063M in 5.014824s fast_blank? 9.311M (± 6.3%) i/s - 46.439M in 5.009153s Comparison: fast_blank?: 9310694.8 i/s blank?: 8824801.7 i/s - same-ish: difference falls within error ================================= Single Space ================================= Warming up -------------------------------------- blank? 56.581k i/100ms fast_blank? 232.774k i/100ms Calculating ------------------------------------- blank? 813.985k (±16.7%) i/s - 4.017M in 5.076576s fast_blank? 9.547M (± 5.2%) i/s - 47.719M in 5.013204s Comparison: fast_blank?: 9547414.0 i/s blank?: 813985.0 i/s - 11.73x slower ================================== Two Spaces ================================== Warming up -------------------------------------- blank? 58.265k i/100ms fast_blank? 244.056k i/100ms Calculating ------------------------------------- blank? 823.343k (±16.2%) i/s - 4.020M in 5.014213s fast_blank? 9.484M (± 4.9%) i/s - 47.347M in 5.005339s Comparison: fast_blank?: 9484021.6 i/s blank?: 823343.1 i/s - 11.52x slower =============================== Mixed Whitspaces =============================== Warming up -------------------------------------- blank? 53.919k i/100ms fast_blank? 237.103k i/100ms Calculating ------------------------------------- blank? 763.435k (±16.8%) i/s - 3.720M in 5.018029s fast_blank? 9.672M (± 5.8%) i/s - 48.369M in 5.019356s Comparison: fast_blank?: 9672467.2 i/s blank?: 763435.4 i/s - 12.67x slower =============================== Very Long String =============================== Warming up -------------------------------------- blank? 34.037k i/100ms fast_blank? 240.366k i/100ms Calculating ------------------------------------- blank? 409.731k (± 8.9%) i/s - 2.042M in 5.028235s fast_blank? 9.794M (± 4.3%) i/s - 49.035M in 5.016328s Comparison: fast_blank?: 9794225.2 i/s blank?: 409731.4 i/s - 23.90x slower ```
* bug report template for migrations (#26488)Girish Sonawane2016-09-151-0/+1
| | | * added bug report template for migrations
* add Active Job bug report templates to guide [ci skip]yuuji.yaginuma2016-09-031-0/+1
| | | | Follow up to #26362
* [ci skip] Update branch version in Contributing GuideAlex Kitchens2016-08-291-1/+1
| | | | | Since only Rails 4 and above are currently supported, this updates a 3-2-stable example to be consistent with the support standard.
* Merge pull request #25278 from mechanicles/fix-linkJon Moss2016-06-041-1/+1
|\ | | | | [ci skip] Fix link rubyonrails.org/core => http://rubyonrails.org/community
| * [ci skip] Fix link rubyonrails.org/core => http://rubyonrails.org/community.Santosh Wadghule2016-06-041-1/+1
| |
* | Grammar fixes for Contributing guideJon Moss2016-06-021-7/+7
|/ | | | | | | | | Not sure why #25239, but it had good changes, so I'm manually pulling in the changes. [Jon Moss, Rajat Bansal] [ci skip]
* Change http github links to https [ci skip]Mehmet Emin İNAÇ2016-05-081-4/+4
| | | | Follow up to 7d55c846f11a435a4c7aae58f99279a2b9dd8506
* [ci skip] Update 'Testing Active Record'yui-knk2016-02-141-1/+1
| | | | | | | | | Follow up 8c629bf463b47643712570d4511a68b9a3da1476. `bundle exec rake test` in 'activerecord' runs tests for * sqlite3 * mysql2 * postgresql
* .git added to https repo urlsVishnu Ks2016-02-021-5/+5
|
* git protocol replaced with httpsVishnu Ks2016-02-021-5/+5
|
* typo fix [ci skip] Prayag Verma2016-01-311-1/+1
| | | Spelling mistake - direcotry > directory
* remove legacy mysql from guides to match #22715Scott Bronson2016-01-091-1/+0
|
* fix links to code of conduct [ci skip]yuuji.yaginuma2015-12-111-1/+1
| | | | CoC text has been moved to the Rails website in 90bcb6d
* [ci skip] Add `Translating Rails Guides` to contributing_to_ruby_on_railsyui-knk2015-11-231-0/+36
| | | | | | | Docrails is private now (6cb1b6724c313c608cf4063fc22886faa19df9be), anyone who does not have access right to docrails can't read "Translating Rails Guides" in wiki of docrails. To prevent someone from giving up to translate, publish them on Rails Guide.
* Remove links to docrailsRafael Mendonça França2015-11-051-2/+2
| | | | docrails is a private repository now to avoid pull requests to it.
* Fix pluralization in docs [ci skip]Scott González2015-10-071-1/+1
|
* [ci skip] Add `:` before code blocks.yui-knk2015-09-251-1/+1
|
* typo fix [ci skip]amitkumarsuroliya2015-09-011-1/+1
| | | sub-project's should be sub-projects' at all places
* Add code of conduct to README.md and to contributing guide [ci skip]maclover72015-08-181-0/+3
|
* [ci skip] Add `bundle exec` to test run commandyui-knk2015-07-171-1/+1
|
* the key is that the behavior is incorrect [ci skip]Tony Miller2015-07-111-1/+1
|
* saying that "behaviour" "behaves" is kind of awkward, how about "works"Tony Miller2015-07-101-1/+1
|
* [ci skip] change sentence about reporting bugs in contributing guideTony Miller2015-07-101-1/+1
| | | | | | I think I know what this sentence is trying to say, but the sentence didn't really make sense, bugs don't fix things! How about this take on it? :sweat_smile:
* [ci skip] Add `bundle exec` to Running a Single Testyui-knk2015-07-081-1/+1
|
* Maintaining consistency in wordings [ci skip]Rohan Daxini2015-06-271-1/+1
| | | "reproduce" word is better suited then "replicate" as its also used at other places in this same document having same context. It will then be consistent across document.
* Fixed the grammatical mistake in the sentence [ci skip]Rohan Daxini2015-05-251-1/+1
|
* Reword sentences in contributing docs for clarity.Daniel Levenson2015-05-231-3/+3
| | | | | | | | [skip ci] - removes use "squash" where it doesn't apply to git - "is a help" -> "helps" - "if your comment simply says" -> "... simply reads"
* Reword a sentence about GH Issues in contributing guide.Daniel Levenson2015-05-231-1/+1
| | | | | | | | | [skip ci] "Everyone's Issues" read pretty weird to me, specifically the use of capitalization. I changed the link text to be "issue list", which seems to better "go with the flow", IMHO.
* updated squash docs-section [ci skip]Gourav Tiwari2015-05-191-2/+1
| | | | | I happen to squash my couple of commits and when followed steps from guide, I observed that I have to give a commit id after which I want to squash. If I don't provide one it picks last 3 commits, which might not include my commits to squash. Refer: http://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git
* fixes some words missingTravis Yoder2015-05-041-1/+1
|
* Merge pull request #19779 from ↵Zachary Scott2015-04-211-13/+20
|\ | | | | | | | | jonatack/improve-contributing-to-ruby-on-rails-guide Improve the Contributing to Rails Guide [skip ci]
| * Improve the Contributing to Rails Guide [skip ci]Jon Atack2015-04-161-13/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | First commit: This PR improves the "4.12 Commit Your Changes" section of the Contributing to Ruby on Rails Guide: - Fix formatting of the commit message example - Improve readability and clarity - Fix grammar - Wrap lines See the before and after images below in this PR. ----- Second commit: - Rewrite to remove the word "buffer" [skip ci]
* | capitalize titleXavier Noria2015-04-201-1/+1
| | | | | | | | | | | | | | | | According to the guidelines: http://guides.rubyonrails.org/ruby_on_rails_guides_guidelines.html#headings References #19821.
* | correct link to Generic template [ci skip]yuuji.yaginuma2015-04-201-1/+1
| |
* | Consistency: Rails master -> edge Rails [ci skip]Godfrey Chan2015-04-201-1/+1
| |
* | Fix typos in contributing guide [ci skip]Godfrey Chan2015-04-191-2/+2
| | | | | | | | | | * includes -> include * "on your computer" is implied
* | Better explain the bug report templates [ci skip]Godfrey Chan2015-04-191-9/+13
|/
* Fix typos and improve the documentationJon Atack2015-04-151-8/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a squash of the following commits, from first to last: - Fix minor, random things I’ve come across lately that individually did not seem worth making a PR for, so I saved them for one commit. One common error is using “it’s” (which is an abbreviation of “it is”) when the possessive “its” should be used for indicating possession. - Changes include the name of a test, so remove the `[skip ci]` (thanks @senny). - Line wrap the changes at 80 chars and add one more doc fix. - Add a missing line wrap in the Contributing to Ruby on Rails Guide. - Line wrap the `TIP` section in the Contributing to Ruby on Rails Guide as well. Rendering the guide locally with `bundle exec rake guides:generate` did not show any change in on-screen formatting after adding the line wrap. The HTML generated is (extra line added to illustrate where the line wrap takes place): <div class="info"><p>Please squash your commits into a single commit when appropriate. This simplifies future cherry picks and also keeps the git log clean.</p></div> - Squash commits.
* [ci skip] Update contributing guideIslam Wazery2015-04-121-2/+2
|
* [ci skip] Subject-verb agreementJoel Brewer2015-03-141-1/+1
|
* Remove line wrapping from the benchmark/ips outputPiotr Szotkowski2015-03-031-4/+4
| | | | [ci skip]
* Talk about Gemfile.lock in the contributing guideRafael Mendonça França2015-02-181-3/+7
| | | | [ci skip]
* Doc: run bundle update after cloning Rails.Brian Morearty2015-01-291-0/+8
|
* Changed "in GitHub" to "on GitHub" [ci skip]Prathamesh Sonpatki2015-01-141-1/+1
| | | | - Followup of https://github.com/rails/rails/pull/18503.
* - Changed `IN` to `ON` in markdown renderer conditionVipul A M2015-01-141-1/+1
| | | | - Changed `IN` to `ON` in all note sentences in guides.
* Minor documentation edits [ci skip]Robin Dupret2014-12-281-3/+3
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 02:30:26 +0000