| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
The phrasing of this struck we as odd, "To help our CI servers..." So I
feel it would be more useful if we explain more explicitly that ci skip
cuts down on usage by not running CI.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
supports it.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move all the testing related stuff to the contributing guide and
redirect the reader to this guide once the installation process
is finished as running tests is the logical next step.
* Group documentation instructions by OS, not by gem
* It eases the installation process and lessen the need to scroll
through the guide
* There's still a list of all additional services required for each
of the gems above the instructions for each OS.
* Also update a bit the instructions
* Update some package names
* Add `yarn` to the package list for Arch Linux and FreeBSD
* Use `dnf` instead of `yum` for Fedora and CentOS
* Advise the user to use `brew bundle` on macOS to lessen the
maintenance burden for this OS and ease the process for the user.
[ci skip]
|
|\
| |
| | |
Change contributing guide to suggest using safer force push
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit changes the contributing guide in rails to suggest using git
with force-with-lease over typical force pushing. In practice, most
rails contributors won't ever encounter a situation where updating their
local fork could result in lost changes as a result of a force push.
That being said, git is a complex tool and arcane flags like
force-with-lease are indeed safer, and by promoting it in rails, there's
a chance more people will discover it and use it in other contexts
outside of rails. In just the same way that herd immunity works by most
people being vaccinated, proliferating knowledge of force-with-lease
should help nudge people towards using safer git commands in general.
[ci skip]
|
|/
|
|
|
| |
This commit documents how to run all tests or a single test file with a
specific randomization seed.
|
| |
|
|
|
|
|
|
| |
ambigity -> ambiguity
Related to #33891
|
| |
|
|
|
|
|
|
|
| |
Contributors can run RuboCop locally to catch code style error in Ruby
code and npm lint task for `rails-ujs` CoffeeScript and JavaScript code.
[skip ci]
|
|
|
|
|
| |
http links will be redirected to the https version, but still better to
just directly link to the https version.
|
|
|
|
| |
This is not working. [ci skip]
|
|
|
|
|
|
|
| |
[ci skip] A regular expression was used to find a lot of missing Oxford
commas and add them. The regular expression was as follows.
", ([a-zA-Z0-9.\`:'\"]+ ){1,6}(or|and) "
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Update active_record_basics.md
I made a bit of clarification for people, who are not familiar with SQL (pretty much like me). However, I don't know what tutorial for MySQL is better, so I haven't inserted a link yet.
* [ci skip] For those who new to GitHub
Added more instructions for contributing guides. Without them, it was somewhat confusing for me to find what I should actually do.
* Update active_record_basics.md
Fixed grammar and text wrapping as requested.
* Update contributing_to_ruby_on_rails.md
Revised instructions.
* Update contributing_to_ruby_on_rails.md
Typos
* Update active_record_basics.md
* [ci skip] Update active_record_basics
Added a few links to SQL tutorials found on the net.
Also, changed MySQL to SQL (or one of its extensions) - I think that it's a good compromise.
* [ci skip] I think now it's more clear what to do.
* [ci skip] Fixed strings
[Rafael Mendonça França + loothunter1]
|
|
|
|
| |
Thanks to @Datasnuten for the suggestion.
|
|
|
|
|
|
|
|
|
| |
* Add Contributing to the Rails Code link.
* Wiki link for Spanish is redirect.
* The base branch of Polish repo is master. And Turkish is, too.
* Unified expression `rails-dev-box`
* The Clone url is wrong.
* The mailing list url is old.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
It's been retired; all contributions now come in via PRs.
|
|
|
|
|
|
| |
Add apostrophe.
[ci skip]
|
|
|
|
|
|
| |
Add necessary commas.
[ci skip]
|
|
|
|
|
| |
`judgment` is the preferred form as Rails usually follows en-us spelling
not en-gb.
|
|
|
|
| |
This will help people figure out what credentials and tables are required to
run ActiveRecord specs.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces boilerplate in the “benchmark your code” section of the
contributors’ guide with an executable template. I also amended the text
to encourage best practices and codified it in the template.
For now this is only good for relatively self-contained changes that can
be inlined into a simple script. In the future, this can be expanded to
cover how to measure the difference between two commits.
The output looks like this:
```
==================================== Empty =====================================
Warming up --------------------------------------
blank? 225.963k i/100ms
fast_blank? 238.147k i/100ms
Calculating -------------------------------------
blank? 8.825M (± 6.4%) i/s - 44.063M in 5.014824s
fast_blank? 9.311M (± 6.3%) i/s - 46.439M in 5.009153s
Comparison:
fast_blank?: 9310694.8 i/s
blank?: 8824801.7 i/s - same-ish: difference falls within error
================================= Single Space =================================
Warming up --------------------------------------
blank? 56.581k i/100ms
fast_blank? 232.774k i/100ms
Calculating -------------------------------------
blank? 813.985k (±16.7%) i/s - 4.017M in 5.076576s
fast_blank? 9.547M (± 5.2%) i/s - 47.719M in 5.013204s
Comparison:
fast_blank?: 9547414.0 i/s
blank?: 813985.0 i/s - 11.73x slower
================================== Two Spaces ==================================
Warming up --------------------------------------
blank? 58.265k i/100ms
fast_blank? 244.056k i/100ms
Calculating -------------------------------------
blank? 823.343k (±16.2%) i/s - 4.020M in 5.014213s
fast_blank? 9.484M (± 4.9%) i/s - 47.347M in 5.005339s
Comparison:
fast_blank?: 9484021.6 i/s
blank?: 823343.1 i/s - 11.52x slower
=============================== Mixed Whitspaces ===============================
Warming up --------------------------------------
blank? 53.919k i/100ms
fast_blank? 237.103k i/100ms
Calculating -------------------------------------
blank? 763.435k (±16.8%) i/s - 3.720M in 5.018029s
fast_blank? 9.672M (± 5.8%) i/s - 48.369M in 5.019356s
Comparison:
fast_blank?: 9672467.2 i/s
blank?: 763435.4 i/s - 12.67x slower
=============================== Very Long String ===============================
Warming up --------------------------------------
blank? 34.037k i/100ms
fast_blank? 240.366k i/100ms
Calculating -------------------------------------
blank? 409.731k (± 8.9%) i/s - 2.042M in 5.028235s
fast_blank? 9.794M (± 4.3%) i/s - 49.035M in 5.016328s
Comparison:
fast_blank?: 9794225.2 i/s
blank?: 409731.4 i/s - 23.90x slower
```
|
|
|
| |
* added bug report template for migrations
|
|
|
|
| |
Follow up to #26362
|
|
|
|
|
| |
Since only Rails 4 and above are currently supported, this updates a
3-2-stable example to be consistent with the support standard.
|
|\
| |
| | |
[ci skip] Fix link rubyonrails.org/core => http://rubyonrails.org/community
|
| | |
|
|/
|
|
|
|
|
|
|
| |
Not sure why #25239, but it had good changes, so I'm manually pulling in
the changes.
[Jon Moss, Rajat Bansal]
[ci skip]
|
|
|
|
| |
Follow up to 7d55c846f11a435a4c7aae58f99279a2b9dd8506
|
|
|
|
|
|
|
|
|
| |
Follow up 8c629bf463b47643712570d4511a68b9a3da1476.
`bundle exec rake test` in 'activerecord' runs tests for
* sqlite3
* mysql2
* postgresql
|
| |
|
| |
|
|
|
| |
Spelling mistake - direcotry > directory
|
| |
|
|
|
|
| |
CoC text has been moved to the Rails website in 90bcb6d
|
|
|
|
|
|
|
| |
Docrails is private now (6cb1b6724c313c608cf4063fc22886faa19df9be),
anyone who does not have access right to docrails can't read
"Translating Rails Guides" in wiki of docrails.
To prevent someone from giving up to translate, publish them on Rails Guide.
|
|
|
|
| |
docrails is a private repository now to avoid pull requests to it.
|
| |
|
| |
|