| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
| |
I think I know what this sentence is trying to say, but the sentence
didn't really make sense, bugs don't fix things! How about this take on
it? :sweat_smile:
|
| |
|
|
|
| |
"reproduce" word is better suited then "replicate" as its also used at other places in this same document having same context. It will then be consistent across document.
|
| |
|
|
|
|
|
|
|
|
| |
[skip ci]
- removes use "squash" where it doesn't apply to git
- "is a help" -> "helps"
- "if your comment simply says" -> "... simply reads"
|
|
|
|
|
|
|
|
|
| |
[skip ci]
"Everyone's Issues" read pretty weird to me, specifically
the use of capitalization. I changed the link text
to be "issue list", which seems to better "go with
the flow", IMHO.
|
|
|
|
|
| |
I happen to squash my couple of commits and when followed steps from guide, I observed that I have to give a commit id after which I want to squash. If I don't provide one it picks last 3 commits, which might not include my commits to squash.
Refer: http://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git
|
| |
|
|\
| |
| |
| |
| | |
jonatack/improve-contributing-to-ruby-on-rails-guide
Improve the Contributing to Rails Guide [skip ci]
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
First commit:
This PR improves the "4.12 Commit Your Changes" section of the
Contributing to Ruby on Rails Guide:
- Fix formatting of the commit message example
- Improve readability and clarity
- Fix grammar
- Wrap lines
See the before and after images below in this PR.
-----
Second commit:
- Rewrite to remove the word "buffer" [skip ci]
|
| |
| |
| |
| |
| |
| |
| |
| | |
According to the guidelines:
http://guides.rubyonrails.org/ruby_on_rails_guides_guidelines.html#headings
References #19821.
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
* includes -> include
* "on your computer" is implied
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a squash of the following commits, from first to last:
-
Fix minor, random things I’ve come across lately that individually
did not seem worth making a PR for, so I saved them for one commit.
One common error is using “it’s” (which is an abbreviation of “it is”)
when the possessive “its” should be used for indicating possession.
-
Changes include the name of a test, so remove the `[skip ci]` (thanks @senny).
-
Line wrap the changes at 80 chars and add one more doc fix.
-
Add a missing line wrap in the Contributing to Ruby on Rails Guide.
-
Line wrap the `TIP` section in the Contributing to Ruby on Rails Guide as well.
Rendering the guide locally with `bundle exec rake guides:generate` did
not show any change in on-screen formatting after adding the line wrap.
The HTML generated is (extra line added to illustrate where the line
wrap takes place):
<div class="info"><p>Please squash your commits into a single commit
when appropriate. This
simplifies future cherry picks and also keeps the git log
clean.</p></div>
-
Squash commits.
|
| |
|
| |
|
|
|
|
| |
[ci skip]
|
|
|
|
| |
[ci skip]
|
| |
|
|
|
|
| |
- Followup of https://github.com/rails/rails/pull/18503.
|
|
|
|
| |
- Changed `IN` to `ON` in all note sentences in guides.
|
| |
|
|
|
|
| |
References #18148.
|
|
|
|
|
|
|
|
|
|
|
| |
1. Specify that you need to create the test databases, and that no special
Rails command needs to be run to do that.
2. Although the underscore style of `rake test_mysql` works, make the
documentation of running the tests in RUNNING_UNIT_TESTS.rdoc
consistent with the "Contributing..." guide.
3. Promote "Testing Active Record" to not be a subsection of
"Running a Single Test," since it doesn't make sense as a subsection
of that.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
- Added note about force pushing same branch to update a existing pull
request instead of opening new one in contributing guide.
- [ci skip]
|
| |
|
|
|
|
| |
[ci skip]
|
| |
|
|
|
|
|
|
|
| |
guide.
I have seen many times that maintainers want people to use this gem to give
a benchmark report. It would be nice to add it and refer to it later.
|
| |
|
| |
|
|
|
|
| |
[ci skip]
|
|
|
|
|
| |
This reverts commit fe9859600824268ff614cb3eb48b62c7165a1fbd, reversing
changes made to add9560643ef79830febf47fa1228752d1df3502.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit adds new lines between titles, paragraphs and code blocks
for an easier reading.
Moreover, in order to be consistent with the other guides, let's remove
the sharps on the right side of the different titles.
The "Running a Single Test" part was also explained after the "Testing
Active Record" one which shows how to run a single test under the scope
of a specific adapter.
Finally, let's explain the `-n` option to run a specific test method.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 28bd442034e0974d0a4d664076dafb8e9555816d.
Reason: Existing text was clearer imo.
[ci skip]
|
| |
| |
| | |
[ci skip]
|
| |
| |
| | |
[ci skip]
|
|/ |
|
|
|
|
|
|
| |
Including replacing a few "smart quotes" with regular quotes (' and "),
for consistency.
[ci skip]
|