| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Before this commit, the sole presence of the Listen constant
enabled the evented file watcher (unless listen resorted to
the polling backend).
This way, applications may depend on listen for other stuff
independently of this feature. Also, allows teams with mixed
setups to decide at boot time whether the evented watcher
should be enabled for each particular instance.
|
|\
| |
| | |
Fix set_autoload_paths and set_load_path document [ci skip]
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
Add option to verify Origin header in CSRF checks
[Jeremy Daer + Rafael Mendonça França]
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Use an example from a default Rails app (4.2.5) rather than an outdated one in the Configuring Rails Components section.
I picked config.time_zone as it currently is the only 'setting for Rails' left in a default config/application.rb.
I stumbled upon this with investigating autoloading in a legacy app, which still included the example comment "# config.autoload_paths += %W(#{config.root}/extras)". Usually adding app/* directories to autoload_paths isn't necessary, so also finding this example within the current docs was a bit confusing initially.
[ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 16ce41b7f4449d6df15df30d69aef18da6510f36.
Reason: See
https://github.com/rails/rails/commit/16ce41b7f4449d6df15df30d69aef18da6510f36#commitcomment-14475125
|
| |/
|/| |
|
| |
| |
| |
| | |
Also call it `public_server.index_name` so it'll make more sense.
|
| |
| |
| |
| | |
3.0.3 has a bug in OS X.
|
|/ |
|
|
|
|
|
|
|
|
| |
Should use `public_file_server.enabled` instead.
Clarified that static files will be served from the public directory, where it made sense.
Also removed occurrence of the deprecated `static_cache_control`.
|
|\
| |
| |
| |
| |
| | |
Errors can be indexed with nested attributes
Close #8638
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`has_many` can now take `index_errors: true` as an
option. When this is enabled, errors for nested models will be
returned alongside an index, as opposed to just the nested model name.
This option can also be enabled (or disabled) globally through
`ActiveRecord::Base.index_nested_attribute_errors`
E.X.
```ruby
class Guitar < ActiveRecord::Base
has_many :tuning_pegs
accepts_nested_attributes_for :tuning_pegs
end
class TuningPeg < ActiveRecord::Base
belongs_to :guitar
validates_numericality_of :pitch
end
```
- Old style
- `guitar.errors["tuning_pegs.pitch"] = ["is not a number"]`
- New style (if defined globally, or set in has_many_relationship)
- `guitar.errors["tuning_pegs[1].pitch"] = ["is not a number"]`
[Michael Probber, Terence Sun]
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Original:
* `config.active_record.belongs_to_required_by_default` is a boolean
value and controls whether `belongs_to` association is required by
default.
Modified version:
* `config.active_record.belongs_to_required_by_default` is a boolean
value and controls whether validation error is triggered by
default if `belongs_to` association is not present or not valid.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Move from `AS::Callbacks::CallbackChain.halt_and_display_warning_on_return_false`
to `AS::Callbacks.halt_and_display_warning_on_return_false` base on
[this
discussion](https://github.com/rails/rails/pull/21218#discussion_r39354580)
Fix the documentation broken by 0a120a818d413c64ff9867125f0b03788fc306f8
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| |
| | |
This can still be added to the middleware stack, but is really not
necessary. I'll follow up with a commit that deprecates the constant
|
|\ \
| | |
| | | |
[Rails Guides] clarify `ActiveRecord::ConnectionTimeoutError`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Original:
* ActiveRecord::ConnectionTimeoutError - could not obtain a database
connection within 5 seconds. The max pool size is currently 5;
consider increasing it:
Modified version:
* ActiveRecord::ConnectionTimeoutError - could not obtain a database
connection within 5.000 seconds (waited 5.000 seconds)
[ci skip]
|
|/ /
| |
| | |
[Rails Guides] Clarify custom code configuration [ci skip]
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Prevents double submission by making disable_with the default.
Default disable_with option will only be applied if user has not
specified her/his own disable_with option, whether that is in the
`data-disable-with` string form or the
`:data => { :disable_with => "Saving..." }` hash form. disable_with
will default to the value attribute.
A configuration option was added to opt out of this functionality if
the user so desires.
`config.action_view.automatically_disable_submit_tag = false`
|
| |
| |
| |
| |
| |
| | |
`ActionView::Helpers::ActiveModelInstanceTag`
so replace `Active Record` with `Active Model`
|
| | |
|
|\ \
| | |
| | | |
[ci skip] docs: making clear that perform_caching has a limited impact
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Improve integration_tool documentation
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As per railties/lib/rails/test_unit/railtie.rb, where it sets it explicitly.
This can be confirmed by starting a new Rails console session in a new app and running this code:
Rails.application.config.app_generators.rails[:integration_tool]
I also beefed up the documentation slightly to be more explicit about what this configuration setting does.
|
| | |
|
| |
| |
| |
| | |
[Robin Dupret & Shunsuke Aida]
|
|\ \
| | |
| | | |
Remove `config.assets.version` from Configuring Rails Application Guide
|
| | | |
|
|/ /
| |
| |
| |
| |
| | |
Also add a CHANGELOG entry for #18587
[ci skip]
|
| |
| |
| |
| |
| |
| | |
This option has been removed in e6747d87f3a061d153215715d56acbb0be20191f
[ci skip]
|
| |
| |
| |
| |
| |
| | |
Set `config.static_index` to serve a static directory index file not
named `index`. For example, to serve `main.html` instead of `index.html`
for directory requests, set `config.static_index` to `"main"`.
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
vngrs/fix_wrong_default_value_of_javascript_engine
config.generators javascript_engine default value is :js not nil
|
| | | |
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Fix the guide to state that Rails uses Minitest as the default test
framework.
Remove unnecessary mention to Test::Unit from the API docs
('constantize' and 'safe_constantize').
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Explain config.active_support.test_order defaults
to :random in newly-generated applications thanks
to generated config/environments/test.rb, otherwise
default is :sorted (until Rails 5.0).
|
|\ \
| |/
|/| |
More docs on tagged logging [ci skip]
|
| |
| |
| |
| |
| | |
Mention that tags can also come from a Proc that accepts the request
object or something's to_s method
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is a squash of the following commits, from first to last:
-
Fix minor, random things I’ve come across lately that individually
did not seem worth making a PR for, so I saved them for one commit.
One common error is using “it’s” (which is an abbreviation of “it is”)
when the possessive “its” should be used for indicating possession.
-
Changes include the name of a test, so remove the `[skip ci]` (thanks @senny).
-
Line wrap the changes at 80 chars and add one more doc fix.
-
Add a missing line wrap in the Contributing to Ruby on Rails Guide.
-
Line wrap the `TIP` section in the Contributing to Ruby on Rails Guide as well.
Rendering the guide locally with `bundle exec rake guides:generate` did
not show any change in on-screen formatting after adding the line wrap.
The HTML generated is (extra line added to illustrate where the line
wrap takes place):
<div class="info"><p>Please squash your commits into a single commit
when appropriate. This
simplifies future cherry picks and also keeps the git log
clean.</p></div>
-
Squash commits.
|
| | |
|
| | |
|