| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Since we have `has_secure_token`, it is too confusing to use `_token`
suffix with `has_secure_password`.
Context https://github.com/rails/rails/pull/33307#discussion_r200807185
|
|
|
|
|
| |
`has_secure_password` allows configuring name of attribute since #26764.
This commit adds a mention about it in the Active Model Basics Guide.
|
|
|
|
|
|
|
| |
[ci skip] A regular expression was used to find a lot of missing Oxford
commas and add them. The regular expression was as follows.
", ([a-zA-Z0-9.\`:'\"]+ ){1,6}(or|and) "
|
| |
|
| |
|
|
|
|
| |
[ci skip]
|
|
|
|
|
|
| |
Lots of grammar, etc fixes.
[ci skip]
|
|
|
|
|
|
| |
Lots of grammar, etc fixes.
[ci skip]
|
|
|
| |
[ci skip]
|
| |
|
|
|
|
|
|
| |
integration and not complete i18n framework.
[ci skip]
|
| |
|
|
|
|
| |
Still more to do. Please assist!
|
|
|
|
| |
As discussed in the minitest-spec-rails issue (http://git.io/vlHxx) Rails uses setup/teardown callbacks. Defining `setup` or `teardown` methods vs. blocks will yield inconsistent behavior in the callback chain.
|
|
|
|
|
| |
* adds/removes a few words
* removes an unnecessary comma
|
| |
|
|
|
|
| |
guides
|
|
|
|
|
|
|
| |
This includes the following classes:
- ActiveModel::Serializers::Xml
- ActiveRecord::Serialization::XmlSerializer
|
|\
| |
| | |
Changed `IN` to `ON` in markdown renderer condition
|
| |
| |
| |
| | |
- Changed `IN` to `ON` in all note sentences in guides.
|
|/ |
|
|
|
|
| |
References #18148.
|
|
|
|
|
| |
- instrospection -> introspection.
- [ci skip]
|
|\
| |
| |
| |
| |
| |
| | |
Merge branch 'active-model-secure-password-guide' of https://github.com/aditya-kapoor/rails into aditya-kapoor-active-model-secure-password-guide
Conflicts:
guides/source/active_model_basics.md
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Some grammatical errors and rewording of sentences throughout document
- Renaming headers to be more human readable, and if following paragraphs do not include module
names, adding those in
- In ActiveModel::AttributeMethods
* formatting expected output correctly, changing from `#` to `# =>`
- In ActiveModel::Dirty
* changing expected output of person.first_name_was from "First Name" to nil
* removing 'active_model' requirement at top of code snippet
- In ActiveModel::Validations
* originally Person.new(token: "2b1f325") raises an argument error (1 for 0), so setting of
attribute occurs on the line after object instantiation
- In ActiveModel::Naming
* closing code snippet tag at end of section so ActiveModel::Model is a separate section
- In ActiveModel::Model
* fixing spelling mistake of attr_accessor
- In ActiveModel::Serialization
* adding edit to description of how from_json and from_xml works under serialization
- In ActiveModel::Lint::Tests
* capitalizing person for class name
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
These methods may cause confusion with the `reset_changes` that
behaves differently
of them.
Also rename undo_changes to restore_changes to match this new set of
methods.
|
|/ |
|
|
|
|
| |
Make AM::Dirty less dirty to plugin into AR or other library
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The other way it was not marking the text as italic, it was showing the
underlines as normal text.
Also fixes some code examples indentation and # => marks in Active Model
and Active Record guides.
[ci skip]
|
| |
|
| |
|
|
|
|
|
| |
We have three or four different introduction sentences to the guides.
After this commit, we use the same one everywhere.
|
|
|
|
| |
It's obvious that the guide is based on this version of Rails, and may not be backwards compatible.
|
|
|
|
|
| |
The proper name, as per the documentation guides, is 'Active Record.' I've
updated several references to it as 'ActiveRecord'.
|
| |
|
| |
|
| |
|
| |
|
|
|