| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pattern is too problematic and introduces a lot of edge cases:
* On 4.2, the issue https://github.com/rails/rails/issues/15124 is
back again.
* needs to define each action for each http status otherwise the
router raises ActionController::RoutingError (No route matches).
* If the router has `match "/*username",...` and some action is
missing, Rails will pick up the "match" and try to do its job.
* encourages people to copy & paste programming. Not DRY.
[ci skip]
|
| |
|
| |
|
|\
| |
| |
| |
| |
| | |
yuki24/another-improvements-for-dynamic-error-pages
A warning line should look like a warning section in Guides
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| |
| | |
Using `get` results in an unexpected error page(returning empty body) for requests of other HTTP mehtods other than GET. Use `match ..., via:
:all` so the exceptions app can be more stable.
|
|/
|
|
| |
[ci skip]
|
|
|
|
|
|
|
|
|
| |
ActionController::Base
Inheriting `ApplicationController` often causes an issue as it always
has before/after actions. It should encourage to use `ActionController::Base` instead.
[ci skip]
|
|
|
|
| |
[ci skip]
|
|
|
|
| |
* Should say "sensitive" instead of "sensible"
|
| |
|
|
|
|
|
|
|
| |
References to ``AppName::Application` removed in favour of ``Rails.application``
as generated with a new rails 4.1 app.
[ci skip]
|
|
|
| |
This is in the note at the end of Section 2: Controller Naming Convention. [ci skip]
|
|
|
|
| |
Closes #14409
|
|
|
|
| |
controller guide
|
|
|
|
|
| |
* Introduces `:plain`, `:html`, `:body` render option.
* Update guide to use `render :plain` instead of `render :text`.
|
|
|
|
| |
Also added a `cookies_serializer.rb` initializer to the app template.
|
| |
|
|
|
|
|
| |
Rename allowed options to :marshal and :json, for custom serializers
only allow the use of custom classes.
|
|
|
|
|
|
|
|
|
| |
The api for filters with classes change and the guides weren't updated.
Now the class must respond for methods with the same name as the filter,
so the `before_action` calls a `before` method, and so on.
The method `#filter` has been deprecated in 4.0.0 and has been removed
in 4.1.0: #7560
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageEncryptor has :serializer option, where any serializer object can
be passed. This commit make it possible to set this serializer from configuration
level.
There are predefined serializers (:marshal_serializer, :json_serialzier)
and custom serializer can be passed as String, Symbol (camelized and
constantized in ActionDispatch::Session namepspace) or serializer object.
Default :json_serializer was also added to generators to provide secure
defalt.
|
|
|
|
|
|
|
|
| |
deep_munge solves CVE-2013-0155 security vulnerability, but its
behaviour is definately confuisng. This commit adds logging to deep_munge.
It logs keys for which values were set to nil.
Also mentions in guides were added.
|
| |
|
|
|
|
| |
Also make all three examples consistent.
|
| |
|
|
|
|
|
|
|
|
|
| |
[ci skip]
This is a follow up to #12609 and integrates #12158.
Thanks @aspiers.
Closes #12158.
|
|\
| |
| |
| |
| |
| | |
Conflicts:
activesupport/lib/active_support/core_ext/hash/deep_merge.rb
activesupport/lib/active_support/core_ext/hash/keys.rb
|
| |
| |
| | |
Code style adherence
|
| | |
|
| |
| |
| | |
Add .try to prevent undefined method error for NilClass.
|
|/
|
| |
The previous example of how to permit a hash of unknown keys used .tap, but had the side effect of logging an "Unpermitted parameters" message despite being a successful workaround. The proposed workaround is ever so slightly better, imo, because it won't result in an "Unpermitted parameters" message being logged.
|
| |
|
|
|
|
|
|
|
|
| |
* Indent after private/protected
* Ruby >= 1.9 syntax for hashes
* Prefer method { do_stuff } instead of method{do_stuff} for single-line blocks.
[ci skip]
|
| |
|
|
|
|
|
| |
I'm adding documentation to the action_controller_overview guide which
should tell people how to stream arbitrary data.
|
|\ |
|
| | |
|
| | |
|
|/ |
|
|
|
|
| |
http://stackoverflow.com/questions/8501021/rails-json-request-is-not-parsed-correctly-into-post-parameters
|
| |
|
| |
|
| |
|
| |
|
|\ |
|
| | |
|
| |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
activerecord/test/cases/adapter_test.rb
guides/source/testing.md
[ci skip]
|
| | | |
|
| | |
| | |
| | |
| | | |
- Consistent hash structure
- Rewording / typo fixes
|
| | |
| | |
| | | |
The error that's raised in case the required key is missing it's actually `ActionController::ParameterMissing` not `ActionController::MissingParameter`. It's important to fix so that people reading the guides knows what error to rescue from when needed.
|