| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
To prevent style check in review like https://github.com/rails/rails/pull/33608#discussion_r211087605.
|
|
|
|
|
| |
In cases where the MatchData object is not used, this provides a speed-up:
https://github.com/JuanitoFatas/fast-ruby/#stringmatch-vs-stringmatch-vs-stringstart_withstringend_with-code-start-code-end
|
| |
|
|
|
|
|
|
|
| |
Not generate needless files:
* _license.html.erb, _welcome.html.erb are partial files.
* layout.html.erb is the layout file.
|
|
|
|
|
|
| |
Found several instances.
Follow up on 63d530c5e68a8cf53603744789f53ccbc7ac1a0e
|
| |
|
|
|
|
| |
Follow up of #31004.
|
| |
|
|
|
|
|
| |
This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing
changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
|
| |
|
|
|
|
|
|
| |
".. with __dir__ we can restore order in the Universe." - by @fxn
Related to 5b8738c2df003a96f0e490c43559747618d10f5f
|
|
|
|
| |
resolve
|
|\
| |
| | |
Fix to use correct path with language on guide
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Let me build guide with "ko" language,
Before:
- It try to use guides/source/documents.yaml
After:
- It try to use guides/source/ko/documents.yaml
|
| |
| |
| |
| |
| | |
Closes #28382
Closes #28651
|
|/
|
|
| |
To allow easy linking at all levels and not just from index
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit is not precisely atomic, but the changes have evolved, summary:
* The ENV-based interface has been moved upwards, the generator has now a conventional
initializer.
* RAILS_VERSION is now assumed to be a Git tag. A blank RAILS_VERSION means edge guides.
* In consequence, the EDGE env variable is gone.
* The "local" version is also gone, the current SHA1 is computed for edge guides.
* Assumes guides are generated from a repo checkout (time ago users could
generate them from gems.)
* The WARNINGS flag is gone in consequence, you cannot disable warnings.
* The `api_link` Markdown helper is fixed.
* Docs about usage have one single place: rake guides:help.
* Links in guides have been revised.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
To ease reading the "Active Support Core Extensions" guide, let's
automatically link references to Ruby files.
It's also possible to reference other components' files in the even
though it's not used in the guides at the moment.
[Petr Skocik & Robin Dupret]
|
|
|
|
|
|
|
| |
To make sure that the user won't look at a feature that doesn't
already exist if they are looking at a previous version of the guides,
let's automatically inject the Rails version the guides have been
generated against.
|
|
|
|
|
|
| |
Some methods were added to public API in
5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of
the public API.
|
| |
|
| |
|
|
|
|
| |
render :html escapes the argument if not provided as html safe.
|
| |
|
| |
|
| |
|
|
|
|
| |
Lacks some proper creds to the homies who went the... distance ;)
|
| |
|
|
|
|
|
|
|
|
| |
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces
Fix all violations in the repository.
|
|
|
|
| |
Hash syntax auto-correcting breaks alignments. 411ccbdab2608c62aabdb320d52cb02d446bb39c
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| |
|
| |
|
|
|
| |
The main goal is to improve readability, but as a side effect this commit makes the method a bit faster.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some translations of rails guides has their own documents.yaml, for example
Japanese:
https://github.com/yasslab/railsguides.jp/blob/japanese/guides/source/documents.yaml
Traditional Chinese:
https://github.com/docrails-tw/guides/blob/master/rails_guides/helpers.rb#L21,L27
https://github.com/docrails-tw/guides/blob/master/source/documents_zh-TW.yaml
The [Translating Rails Guides](https://github.com/rails/docrails/wiki/translating-rails-guides) says
> Copy the contents of guides/source into your own language directory and translate them.
So that sounds ok to copy guides/source/documents.yaml into language
specific directly and translating them like other markdown files.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calculating -------------------------------------
each_char 924.000 i/100ms
each_codepoint 1.381k i/100ms
-------------------------------------------------
each_char 9.320k (¡Þ 5.1%) i/s - 47.124k
each_codepoint 13.857k (¡Þ 3.6%) i/s - 70.431k
Comparison:
each_codepoint: 13857.4 i/s
each_char: 9319.5 i/s - 1.49x slower
The full report can be found here:
https://gist.github.com/yuki24/a80988f35aceac76f1d5
|
| |
|
|
|
|
| |
Bug was discovered and discussed in #18395.
|
|
|
|
| |
- Changed `IN` to `ON` in all note sentences in guides.
|
|
|
|
|
|
| |
To highlight ERB snippets, both `erb` and `html+erb` are used as a
language passed to the code block. However, only the former will be
correctly highlighted.
|
| |
|